Skip to contentSkip to conversation

be2iscsi: Fixing the number of SGE's

PATCH In review Jayamohan Kallickal 2 participants 4 messages Jan 6, 2010 – Jan 7, 2010

Subsystems (2)
SCSI Emulex 10Gbps iSCSI - OneConnect driver
lore
Share & tools
lore

Jayamohan Kallickal

author
#0 lore raw

PATCH 2/3 be2iscsi: Fixing the number of SGE's

The number of SGE's supported is fixed to what the
chip expects. Also, the max sectors set to tested values

Signed-off-by Jayamohan Kallickal <[email protected]>
---
 drivers/scsi/be2iscsi/be_main.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/be2iscsi/be_main.h +2 -2
index 4cde8f6..13ff02c 100644
@@ -56,10 +56,10 @@
 #define BE2_DEFPDU_DATA_SZ	8192
 
 #define MAX_CPUS		31
-#define BEISCSI_SGLIST_ELEMENTS	BE2_SGE
+#define BEISCSI_SGLIST_ELEMENTS	30
 
 #define BEISCSI_CMD_PER_LUN	128	/* scsi_host->cmd_per_lun */
-#define BEISCSI_MAX_SECTORS	2048	/* scsi_host->max_sectors */
+#define BEISCSI_MAX_SECTORS	256	/* scsi_host->max_sectors */
 
 #define BEISCSI_MAX_CMD_LEN	16	/* scsi_host->max_cmd_len */
 #define BEISCSI_NUM_MAX_LUN	256	/* scsi_host->max_lun */
Signature · 1 line
1.6.4
#1 lore raw
Quoted 13 lines · Jayamohan Kallickal

The number of SGE's supported is fixed to what the
chip expects. Also, the max sectors set to tested values

Signed-off-by Jayamohan Kallickal<[email protected]>
---
  drivers/scsi/be2iscsi/be_main.h |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/be2iscsi/be_main.h +0 -0
index 4cde8f6..13ff02c 100644

drivers/scsi/be2iscsi/be_main.h line 59

Quoted 5 lines
drivers/scsi/be2iscsi/be_main.h +1 -1
@@ -56,10 +56,10 @@
  #define BE2_DEFPDU_DATA_SZ	8192
 
  #define MAX_CPUS		31
-#define BEISCSI_SGLIST_ELEMENTS	BE2_SGE
+#define BEISCSI_SGLIST_ELEMENTS	30

BE2_SGE is now not used, so you can kill it.

author
#2 lore raw

It is used in be_main.c (num_sge_per_io).

The FW expects and sglist with 32 SGE's but 2 are used internally.

-Jay

--
_____
From: Mike Christie [mailto:[email protected]]
To: Jayamohan Kalickal [mailto:[email protected]]
Cc: [email protected], [email protected]
Sent: Wed, 06 Jan 2010 12:30:52 -0800
Subject: Re: [PATCH 2/3] be2iscsi: Fixing the number of SGE's

Quoted 13 lines · Jayamohan Kallickal

The number of SGE's supported is fixed to what the
chip expects. Also, the max sectors set to tested values

Signed-off-by Jayamohan Kallickal<[email protected]>
---
  drivers/scsi/be2iscsi/be_main.h |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/be2iscsi/be_main.h +0 -0
index 4cde8f6..13ff02c 100644

drivers/scsi/be2iscsi/be_main.h line 59

Quoted 5 lines
drivers/scsi/be2iscsi/be_main.h +1 -1
@@ -56,10 +56,10 @@
  #define BE2_DEFPDU_DATA_SZ	8192
 
  #define MAX_CPUS		31
-#define BEISCSI_SGLIST_ELEMENTS	BE2_SGE
+#define BEISCSI_SGLIST_ELEMENTS	30

BE2_SGE is now not used, so you can kill it.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

___________________________________________________________________________________
This message, together with any attachment(s), contains confidential and proprietary information of ServerEngines Corporation and is intended only for the designated recipient(s) named above. Any unauthorized review, printing, retention, copying, disclosure or distribution is strictly prohibited. If you are not the intended recipient of this message, please immediately advise the sender by reply email message and delete all copies of this message and any attachment(s). Thank you.

#3 lore raw
Quoted 4 lines · Jayamohan Kalickal

It is used in be_main.c (num_sge_per_io).

The FW expects and sglist with 32 SGE's but 2 are used internally.

My fault. Patches look ok to me.