mtest01: free memory allocated

Hi All,

I'm running LTP (I'm using ltp-full-20090731....but asap I will upgrade to latest) on SH based platforms.
Now, during a test-session. I've noted that the test "mtest01" reduced drastically the system memory and after its execution this memory wasn't de-allocated.

I've analysed the mtest01.c code and I've noted that no "free()" istruction was associated to the related malloc:

......
if((mem = (char*)malloc(chunksize)) == NULL) {
......

I've simply added a "free(mem)" of the allocated memory and the issue was addressed successfully.

I've attached the trivial patch I've developed.

Best Regards,
--
Francesco
Added missed "free" istruction to release memory previosuly allocated.

Signed-off-by Francesco Rundo <[email protected]>

--- ltp-full-20090731/testcases/kernel/mem/mtest01/
mtest01.c.origin 2009-02-26 13:02:27.000000000 +0100
+++ ltp-full-20090731/testcases/kernel/mem/mtest01/mtest01.c

2009-12-15 14:03:28.779240000 +0100

testcases/kernel/mem/mtest01/mtest01.c renamed from testcases/kernel/mem/mtest01/mtest01.c.origin +3 -0

@@ -258,5 +258,8 @@
    else
      tst_resm(TPASS, "%llu kbytes allocated only.",  
 original_maxbytes/1024);
  }
+
+  free(mem);
+
  exit(0);

}

2. Unless the test exits the code block immediately, I'd definitely do:

if (mem)

     free (mem);

to avoid making a bad free call.

Quoted 38 lines · Francesco RUNDO

Hi All,

I'm running LTP (I'm using ltp-full-20090731....but asap I will upgrade to latest) on SH based platforms.
Now, during a test-session. I've noted that the test "mtest01" reduced drastically the system memory and after its execution this memory wasn't de-allocated.

I've analysed the mtest01.c code and I've noted that no "free()" istruction was associated to the related malloc:

......
if((mem = (char*)malloc(chunksize)) == NULL) {
......

I've simply added a "free(mem)" of the allocated memory and the issue was addressed successfully.

I've attached the trivial patch I've developed.

Best Regards,
--
Francesco
Added missed "free" istruction to release memory previosuly allocated.

Signed-off-by Francesco Rundo <[email protected]>

--- ltp-full-20090731/testcases/kernel/mem/mtest01/
mtest01.c.origin 2009-02-26 13:02:27.000000000 +0100
+++ ltp-full-20090731/testcases/kernel/mem/mtest01/mtest01.c

2009-12-15 14:03:28.779240000 +0100

testcases/kernel/mem/mtest01/mtest01.c renamed from testcases/kernel/mem/mtest01/mtest01.c.origin +3 -0

@@ -258,5 +258,8 @@
    else
      tst_resm(TPASS, "%llu kbytes allocated only.",  
 original_maxbytes/1024);
  }
+
+  free(mem);
+
  exit(0);

Quoted 1 line

}

1. Does the version off cvs still have this issue?
2. Unless the test exits the code block immediately, I'd definitely do:

if (mem)

     free (mem);

to avoid making a bad free call.

Thanks,
-Garrett

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Garrett,

Quoted 49 lines · Garrett Cooper

Quoted 38 lines · Francesco RUNDO

Hi All,

I'm running LTP (I'm using ltp-full-20090731....but asap I will upgrade to latest) on SH based platforms.
Now, during a test-session. I've noted that the test "mtest01" reduced drastically the system memory and after its execution this memory wasn't de-allocated.

I've analysed the mtest01.c code and I've noted that no "free()" istruction was associated to the related malloc:

......
if((mem = (char*)malloc(chunksize)) == NULL) {
......

I've simply added a "free(mem)" of the allocated memory and the issue was addressed successfully.

I've attached the trivial patch I've developed.

Best Regards,
--
Francesco
Added missed "free" istruction to release memory previosuly allocated.

Signed-off-by Francesco Rundo <[email protected]>

--- ltp-full-20090731/testcases/kernel/mem/mtest01/
mtest01.c.origin 2009-02-26 13:02:27.000000000 +0100
+++ ltp-full-20090731/testcases/kernel/mem/mtest01/mtest01.c

2009-12-15 14:03:28.779240000 +0100

testcases/kernel/mem/mtest01/mtest01.c renamed from testcases/kernel/mem/mtest01/mtest01.c.origin +3 -0

@@ -258,5 +258,8 @@
   else
     tst_resm(TPASS, "%llu kbytes allocated only.",  
 original_maxbytes/1024);
 }
+
+  free(mem);
+
 exit(0);

Quoted 1 line

}

1. Does the version off cvs still have this issue?
2. Unless the test exits the code block immediately, I'd definitely do:

if (mem)

    free (mem);

Quoted 1 line

to avoid making a bad free call.

Have you made any changes to this ? I do not see any commits.

Regards--
Subrata

Garrett,

Quoted 46 lines · Garrett Cooper

Quoted 33 lines · Francesco RUNDO

Hi All,

I'm running LTP (I'm using ltp-full-20090731....but asap I will upgrade to latest) on SH based platforms.
Now, during a test-session. I've noted that the test "mtest01" reduced drastically the system memory and after its execution this memory wasn't de-allocated.

I've analysed the mtest01.c code and I've noted that no "free()" istruction was associated to the related malloc:

......
if((mem = (char*)malloc(chunksize)) == NULL) {
......

I've simply added a "free(mem)" of the allocated memory and the issue was addressed successfully.

I've attached the trivial patch I've developed.

Best Regards,
--
Francesco
Added missed "free" istruction to release memory previosuly allocated.

Signed-off-by Francesco Rundo <[email protected]>

--- ltp-full-20090731/testcases/kernel/mem/mtest01/
mtest01.c.origin 2009-02-26 13:02:27.000000000 +0100
+++ ltp-full-20090731/testcases/kernel/mem/mtest01/mtest01.c

2009-12-15 14:03:28.779240000 +0100

testcases/kernel/mem/mtest01/mtest01.c renamed from testcases/kernel/mem/mtest01/mtest01.c.origin +3 -0

@@ -258,5 +258,8 @@
   else
     tst_resm(TPASS, "%llu kbytes allocated only.",  
 original_maxbytes/1024);
 }
+
+  free(mem);
+
 exit(0);

Quoted 3 lines

}

1. Does the version off cvs still have this issue?
2. Unless the test exits the code block immediately, I'd definitely do:

if (mem)

    free (mem);

Quoted 3 lines

to avoid making a bad free call.

Have you made any changes to this ? I do not see any commits.

Regards--
Subrata

Quoted 14 lines

Thanks,
-Garrett

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Hi All,

I'm running LTP (I'm using ltp-full-20090731....but asap I will upgrade to latest) on SH based platforms.
Now, during a test-session. I've noted that the test "mtest01" reduced drastically the system memory and after its execution this memory wasn't de-allocated.

I've analysed the mtest01.c code and I've noted that no "free()" istruction was associated to the related malloc:

......
if((mem = (char*)malloc(chunksize)) == NULL) {
......

I've simply added a "free(mem)" of the allocated memory and the issue was addressed successfully.

-----Original Message-----
From: Jiri Palecek [mailto:[email protected]]
Sent: Tuesday, January 05, 2010 5:20 PM
To: Francesco RUNDO
Cc: LTP
Subject: Re: [LTP] mtest01: free memory allocated

Francesco RUNDO napsal(a):

Quoted 3 lines

Hi All,

I'm running LTP (I'm using ltp-full-20090731....but asap I will

upgrade

Quoted 2 lines

to latest) on SH based platforms.
Now, during a test-session. I've noted that the test "mtest01"

reduced

Quoted 1 line

drastically the system memory and after its execution this memory

wasn't

Quoted 4 lines

de-allocated.

I've analysed the mtest01.c code and I've noted that no "free()" istruction was associated to the related malloc:

Does this mean the kernel doesn't free processes' allocated memory on exit? Is
this intentional (and documented somewhere)?

Quoted 6 lines

......
if((mem = (char*)malloc(chunksize)) == NULL) {
......

I've simply added a "free(mem)" of the allocated memory and the issue was addressed successfully.

This isn't complete by far. You don't free all the allocations, and there are
code paths which don't pass your line before exit.

Regards
Jiri Palecek

Quoted 33 lines

-----Original Message-----
From: Jiri Palecek [mailto:[email protected]]
Sent: Tuesday, January 05, 2010 5:20 PM
To: Francesco RUNDO
Cc: LTP
Subject: Re: [LTP] mtest01: free memory allocated

Francesco RUNDO napsal(a):

Quoted 3 lines

Hi All,

I'm running LTP (I'm using ltp-full-20090731....but asap I will

upgrade

Quoted 2 lines

to latest) on SH based platforms.
Now, during a test-session. I've noted that the test "mtest01"

reduced

Quoted 1 line

drastically the system memory and after its execution this memory

wasn't

Quoted 4 lines

de-allocated.

I've analysed the mtest01.c code and I've noted that no "free()" istruction was associated to the related malloc:

Does this mean the kernel doesn't free processes' allocated memory on exit? Is
this intentional (and documented somewhere)?

Quoted 6 lines

......
if((mem = (char*)malloc(chunksize)) == NULL) {
......

I've simply added a "free(mem)" of the allocated memory and the issue was addressed successfully.

Quoted 7 lines

This isn't complete by far. You don't free all the allocations, and there are
code paths which don't pass your line before exit.

Regards
Jiri Palecek

We've documented this behavior internally as a low priority issue for a while now.
This is the root cause one of our developers came back with, which might clarify what Francesco is seeing:

Issue:

Across architectures, mtest tests sometimes report a fail because they won't run unless less than 80% of memory is used. This is because the test attempts to fill up the memory to the 80% limit specified by the -p option.

Some previous test in the LTP suite is taking up memory it should not have, as this happens even on machines with 1GB of memory.

mtest01 runs "mtest01 -p80" which mallocs chunks of memory until 80% of memory is used.
mtest01w runs "mtest01 -p80 -w" which mallocs and writes chunks of memory until 80% of memory is used.

Response:

mtest01 -p80 -w; mtest01 -p80 -w; free; free; free... ; mtest01 -p80 -w

on the same command line. the second mtest01 always returns with a failure. while the mtest01 after enough free(usually 4 or 5) always passes.

Looks like it is because of the aging of the caches, which are not freed yet when the second mtest01 is executed and are dropped due to aging by the time last mtest01 is executed.
The information (sysinfo()) mtest is using to determine the amount of memory allocated does not include the memory in caches(free). mtest01 sees that 80% of the memory is already in use and thus do not go for malloc-ing and returns with a failure, however if it had tried, the malloc would have succeeded because of the reuse of the free slab caches.