Skip to contentSkip to conversation

drivers/mtd/chips/cfi_probe.c:18 remove unneeded comment

PATCH In review René Bolldorf 2 participants 2 messages Jan 7, 2010 – Jan 13, 2010 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/mtd/chips/cfi_probe.c:18 remove unneeded comment

drivers/mtd/chips/cfi_probe.c 2010-01-04 22:38:31.536678726 +0100 renamed from drivers/mtd/chips/cfi_probe.c 2009-12-28 21:09:46.638828686 +0100 +0 -2
@@ -18,8 +18,6 @@
 #include <linux/mtd/cfi.h>
 #include <linux/mtd/gen_probe.h>
 
-//#define DEBUG_CFI
-
 #ifdef DEBUG_CFI
 static void print_cfi_ident(struct cfi_ident *);
 #endif
#1 lore raw

drivers/mtd/chips/cfi_probe.c 2010-01-04 22:38:31.536678726 +0100 line 23

Quoted 11 lines · René Bolldorf
drivers/mtd/chips/cfi_probe.c 2010-01-04 22:38:31.536678726 +0100 renamed from drivers/mtd/chips/cfi_probe.c 2009-12-28 21:09:46.638828686 +0100 +0 -2
@@ -18,8 +18,6 @@
  #include <linux/mtd/cfi.h>
  #include <linux/mtd/gen_probe.h>
 
-//#define DEBUG_CFI
-
  #ifdef DEBUG_CFI
  static void print_cfi_ident(struct cfi_ident *);
  #endif

I do not think this is is needed. The commented out define shows what one should do to debug the thing. Without that line it is not so obvious. So, nack from me.

Signature · 2 lines
Best Regards,
Artem Bityutskiy (Артём Битюцкий)