Skip to contentSkip to conversation

input: make xenbus device id constant

PATCH Applied Németh Márton 1 participant 1 message Jan 9, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 5/5 input: make xenbus device id constant

From: Márton Németh <[email protected]>

The ids field of the struct xenbus_device_id is constant in <linux/xen/xenbus.h> so it is worth to make xenkbd_ids also constant.

The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@

	struct I1 {
	  ...
	  const struct I2 *x;
	  ...
	};

@s@
identifier r.I1, y;
identifier r.x, E;
@@

	struct I1 y = {
	  .x = E,
	};

@c@
identifier r.I2;
identifier s.E;
@@

	const struct I2 E[] = ... ;

@depends on !c@
identifier r.I2;
identifier s.E;
@@
+ const

	struct I2 E[] = ...;

// </smpl>

---

drivers/input/xen-kbdfront.c 2010-01-08 19:23:27.000000000 +0100 renamed from drivers/input/xen-kbdfront.c 2010-01-07 19:08:40.000000000 +0100 +1 -1
diff -u -p a/drivers/input/xen-kbdfront.c b/drivers/input/xen-kbdfront.c
@@ -321,7 +321,7 @@ InitWait:
 	}
 }
 
-static struct xenbus_device_id xenkbd_ids[] = {
+static const struct xenbus_device_id xenkbd_ids[] = {
 	{ "vkbd" },
 	{ "" }
 };