Skip to contentSkip to conversation

block: make virtio device id constant

PATCH New Németh Márton 1 participant 1 message Jan 10, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 5/5 block: make virtio device id constant

From: Márton Németh <[email protected]>

The id_table field of the struct virtio_driver is constant in <linux/virtio.h> so it is worth to make id_table also constant.

The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@

	struct I1 {
	  ...
	  const struct I2 *x;
	  ...
	};

@s@
identifier r.I1, y;
identifier r.x, E;
@@

	struct I1 y = {
	  .x = E,
	};

@c@
identifier r.I2;
identifier s.E;
@@

	const struct I2 E[] = ... ;

@depends on !c@
identifier r.I2;
identifier s.E;
@@
+ const

	struct I2 E[] = ...;

// </smpl>

---

drivers/block/virtio_blk.c 2010-01-08 09:30:00.000000000 +0100 renamed from drivers/block/virtio_blk.c 2009-12-03 04:51:21.000000000 +0100 +1 -1
diff -u -p a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
@@ -404,7 +404,7 @@ static void __devexit virtblk_remove(str
 	kfree(vblk);
 }
 
-static struct virtio_device_id id_table[] = {
+static const struct virtio_device_id id_table[] = {
 	{ VIRTIO_ID_BLOCK, VIRTIO_DEV_ANY_ID },
 	{ 0 },
 };