Skip to contentSkip to conversation

drm/radeon/kms: crtc_ omitted in display assignments in radeon_atom_mode_fixup()?

PATCH In review Roel Kluin 2 participants 2 messages Jan 15, 2010

Subsystems (2)
DRM drivers Radeon and amdgpu DRM drivers
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 drm/radeon/kms: crtc_ omitted in display assignments in radeon_atom_mode_fixup()?

The crtc_ prefix was omitted in h/vdisplay assignments

Signed-off-by Roel Kluin <[email protected]>

---
Not sure, but maybe the change below is needed? please ack/nack.

drivers/gpu/drm/radeon/radeon_encoders.c +2 -2
index 82eb551..a9dc073 100644
@@ -233,8 +233,8 @@ static bool radeon_atom_mode_fixup(struct drm_encoder *encoder,
 		if (!ASIC_IS_AVIVO(rdev)) {
 			adjusted_mode->hdisplay = mode->hdisplay;
 			adjusted_mode->vdisplay = mode->vdisplay;
-			adjusted_mode->crtc_hdisplay = mode->hdisplay;
-			adjusted_mode->crtc_vdisplay = mode->vdisplay;
+			adjusted_mode->crtc_hdisplay = mode->crtc_hdisplay;
+			adjusted_mode->crtc_vdisplay = mode->crtc_vdisplay;
 		}
 		adjusted_mode->base.id = mode_id;
 	}
#1 lore raw
Quoted 5 lines · Roel Kluin

The crtc_ prefix was omitted in h/vdisplay assignments

Signed-off-by Roel Kluin <[email protected]>

---
Not sure, but maybe the change below is needed? please ack/nack.

NAK. the code is correct as is.

Quoted 29 lines
drivers/gpu/drm/radeon/radeon_encoders.c +2 -3
index 82eb551..a9dc073 100644
@@ -233,8 +233,8 @@ static bool radeon_atom_mode_fixup(struct drm_encoder *encoder,
                if (!ASIC_IS_AVIVO(rdev)) {
                        adjusted_mode->hdisplay = mode->hdisplay;
                        adjusted_mode->vdisplay = mode->vdisplay;
-                       adjusted_mode->crtc_hdisplay = mode->hdisplay;
-                       adjusted_mode->crtc_vdisplay = mode->vdisplay;
+                       adjusted_mode->crtc_hdisplay = mode->crtc_hdisplay;
+                       adjusted_mode->crtc_vdisplay = mode->crtc_vdisplay;
                }
                adjusted_mode->base.id = mode_id;
        }
 
------------------------------------------------------------------------------

Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel