Skip to contentSkip to conversation

V4L/DVB ivtv-yuv.c: args->dst.left assigned to both nf->tru_x and nf->dst_x in ivtv_yuv_setup_frame()

DISCUSSION Roel Kluin 2 participants 2 messages Jan 15, 2010 Media (V4L/DVB)

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

vi drivers/media/video/ivtv/ivtv-yuv.c +971

and note that `args->dst.left' is assigned both to nf->tru_x and nf->dst_x, is that ok?

Roel

#1 lore raw
Quoted 4 lines · Roel Kluin

vi drivers/media/video/ivtv/ivtv-yuv.c +971

and note that `args->dst.left' is assigned both to nf->tru_x and nf->dst_x, is that ok?

It's fine. dst_x is used to set a hardware register and may be changed in ivtv_yuv_window_setup()

tru_x is never altered & is used in a special condition where the original unaltered value is required.

Signature · 1 line
Ian