Skip to contentSkip to conversation

section mismatch: pcibios_scan_specific_bus()

PATCH In review René Bolldorf 2 participants 3 messages Jan 13, 2010 – Jan 16, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 section mismatch: pcibios_scan_specific_bus()

Hi all,
pcibios_scan_specific_bus() is only invoked from
__devinit pcibios_fixup_peer_bridges(void).

Mark it as __devinit.
Sry for the first mail, I hadn't sleep enough...

arch/x86/pci/legacy.c +1 -1
@@ -39,7 +39,7 @@ static int __init pci_legacy_init(void)
        return 0;
 }
 
-void pcibios_scan_specific_bus(int busn)
+void __devinit pcibios_scan_specific_bus(int busn)
 {
        int devfn;
        long node;
#1 lore raw
Quoted 11 lines · On Wed, 13 Jan 2010 22:41:52 +0100 René Bolldorf <[email protected]> wrote:

Hi all,
pcibios_scan_specific_bus() is only invoked from
__devinit pcibios_fixup_peer_bridges(void).

Mark it as __devinit.
Sry for the first mail, I hadn't sleep enough...

arch/x86/pci/legacy.c static int __init pci_legacy_init(void) · line 45

Quoted 8 lines
arch/x86/pci/legacy.c +1 -1
@@ -39,7 +39,7 @@ static int __init pci_legacy_init(void)
         return 0;
  }
 
-void pcibios_scan_specific_bus(int busn)
+void __devinit pcibios_scan_specific_bus(int busn)
  {
         int devfn;
         long node;

Doesn't apply to my for-linus branch, also missing a Signed-off-by. I guess you need more sleep. :) Care to refresh if it's still necessary?

Thanks,

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
#2 lore raw
Quoted 26 lines · Jesse Barnes
Quoted 11 lines · On Wed, 13 Jan 2010 22:41:52 +0100 René Bolldorf<[email protected]> wrote:

Hi all,
pcibios_scan_specific_bus() is only invoked from
__devinit pcibios_fixup_peer_bridges(void).

Mark it as __devinit.
Sry for the first mail, I hadn't sleep enough...

arch/x86/pci/legacy.c static int __init pci_legacy_init(void) · line 45

Quoted 8 lines
arch/x86/pci/legacy.c +1 -1
@@ -39,7 +39,7 @@ static int __init pci_legacy_init(void)
          return 0;
   }
 
-void pcibios_scan_specific_bus(int busn)
+void __devinit pcibios_scan_specific_bus(int busn)
   {
          int devfn;
          long node;

Doesn't apply to my for-linus branch, also missing a Signed-off-by. I guess you need more sleep. :) Care to refresh if it's still necessary?

Quoted 1 line

Thanks,

I pulled today git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6 linux-next. pci legacy was deleted. Now patch can be ignored.