Skip to contentSkip to conversation

GE GPIO and PIC support.

DISCUSSION Martyn Welch 2 participants 2 messages Jan 18, 2010

lore
Share & tools
lore
#0 lore raw

Hi,

I'm currently adding support for a GE board based on the Freescale P2020. This board has a cascaded interrupt controller and GPIO which should be compatible with drivers currently provided for the MPC8641D based boards that are already in the kernel.

At the moment the drivers (in gef_gpio.c and gef_pic.c) are in the "arch/powerpc/platforms/86xx" folder. As the p2020 is not 86xx, I guess I should move these drivers to a more central location. I'm currently not sure where would be best to move them to, I see "arch/powerpc/sysdev" and "arch/powerpc/platforms" as potential locations, where would be the most suitable?

Martyn

Signature · 4 lines
Martyn Welch (Principal Software Engineer)   |   Registered in England and
GE Intelligent Platforms                     |   Wales (3828642) at 100
T +44(0)127322748                            |   Barbirolli Square, Manchester,
E [email protected]                        |   M2 3AB  VAT:GB 927559189
#1 lore raw
Quoted 9 lines · Martyn Welch

Hi,
=20
I'm currently adding support for a GE board based on the Freescale P2020. This board has a cascaded interrupt controller and GPIO which should be compatible with drivers currently provided for the MPC8641D based boards that are already in the kernel.
=20
At the moment the drivers (in gef_gpio.c and gef_pic.c) are in the "arch/powerpc/platforms/86xx" folder. As the p2020 is not 86xx, I =

guess

Quoted 4 lines

I should move these drivers to a more central location. I'm currently not sure where would be best to move them to, I see "arch/powerpc/sysdev" and "arch/powerpc/platforms" as potential locations, where would be the most suitable?

I would suggest arch/powerpc/platforms as its board specific code and = not chip specific. However others gripe at me about that from time to = time.

- k=