Build fbv with JPEG and PNG enabled
PATCH 1/1 Build fbv with JPEG and PNG enabled
Build fbv with jpeg and png enabled
--- recipes/fbv/fbv-1.0b/fbv-1.0b.patch | 12 ++++++++++++ recipes/fbv/fbv_1.0b.bb | 23 +++++++++++++++-------- 2 files changed, 27 insertions(+), 8 deletions(-) create mode 100644 recipes/fbv/fbv-1.0b/fbv-1.0b.patch
(quoted diff) +0 -0
b/recipes/fbv/fbv-1.0b/fbv-1.0b.patch
new file mode 100644
index 0000000..6fbd1fb
recipes/fbv/fbv-1.0b/fbv-1.0b.patch new file +12 -0
@@ -0,0 +1,12 @@ +diff -urN fbv-1.0b-0rig/Makefile fbv-1.0b/Makefile +--- fbv-1.0b-0rig/Makefile 2009-08-20 00:33:58.000000000 +0200 ++++ fbv-1.0b/Makefile 2009-08-20 00:34:16.000000000 +0200 +@@ -12,7 +12,7 @@ + OBJECTS = ${SOURCES:.c=.o} + + OUT = fbv +-#LIBS = -lungif -L/usr/X11R6/lib -ljpeg -lpng ++LIBS = -L/usr/lib -ljpeg -lpng #-lungif + + all: $(OUT) + @echo Build DONE.
recipes/fbv/fbv_1.0b.bb +15 -8
@@ -1,25 +1,32 @@ DESCRIPTION = "Frame Buffer Viewer" LICENSE = "GPL" -DEPENDS = "libpng" +DEPENDS = "libpng jpeg" PR = "r1" SRC_URI = "http://s-tech.elsat.net.pl/fbv/fbv-1.0b.tar.gz \ - file://cross_compile.patch;patch=1" + file://cross_compile.patch;patch=1 \ + file://fbv-1.0b.patch;patch=1 \ + " + +#inherit autotools do_configure() { - CC="${CC}" ./configure --without-libungif --without-bmp \ - --without-libjpeg + CC="${CC}" ./configure --without-libungif } do_compile() { oe_runmake CFLAGS="-O2 -Wall -D_GNU_SOURCE -D__KERNEL_STRICT_NAMES" \ CC="${CC}" } + do_install() { install -d ${D}${bindir} - install -m 0755 fbv ${D}${bindir} + install -m 0755 fbv ${D}${bindir} - # man - install -d ${D}${mandir}/man1/ - install -m 0644 fbv.1 ${D}${mandir}/man1/fbv.1 +# man +# install -d ${D}${mandir}/man1/ +# install -m 0644 fbv.1 ${D}${mandir}/man1/fbv.1 } + +PACKAGES = "fbv" +
Signature · 4 lines
1.6.0.2 -- Best Regards Ulf Samuelsson
Am Mittwoch, den 20.01.2010, 00:06 +0100 schrieb Ulf Samuelsson:
Quoted 33 lines
Build fbv with jpeg and png enabled
Signed-off-by Ulf Samuelsson <[email protected]>--- recipes/fbv/fbv-1.0b/fbv-1.0b.patch | 12 ++++++++++++ recipes/fbv/fbv_1.0b.bb | 23 +++++++++++++++-------- 2 files changed, 27 insertions(+), 8 deletions(-) create mode 100644 recipes/fbv/fbv-1.0b/fbv-1.0b.patchrecipes/fbv/fbv-1.0b/fbv-1.0b.patch new file +12
-0@@ -0,0 +1,12 @@ +diff -urN fbv-1.0b-0rig/Makefile fbv-1.0b/Makefile +--- fbv-1.0b-0rig/Makefile 2009-08-20 00:33:58.000000000 +0200 ++++ fbv-1.0b/Makefile 2009-08-20 00:34:16.000000000 +0200 +@@ -12,7 +12,7 @@ + OBJECTS = ${SOURCES:.c=.o} + + OUT = fbv +-#LIBS = -lungif -L/usr/X11R6/lib -ljpeg -lpng ++LIBS = -L/usr/lib -ljpeg -lpng #-lungif + + all: $(OUT) + @echo Build DONE.recipes/fbv/fbv_1.0b.bb +0
-0
recipes/fbv/fbv_1.0b.bb line 4
Quoted 5 lines
recipes/fbv/fbv_1.0b.bb +1
-1@@ -1,25 +1,32 @@ DESCRIPTION = "Frame Buffer Viewer" LICENSE = "GPL" -DEPENDS = "libpng" +DEPENDS = "libpng jpeg" PR = "r1"
Should not this be increased because of the changed DEPENDS? Why is PR not just a number?
recipes/fbv/fbv_1.0b.bb line 11
Quoted 7 lines
recipes/fbv/fbv_1.0b.bb +5
-1SRC_URI = "http://s-tech.elsat.net.pl/fbv/fbv-1.0b.tar.gz \ - file://cross_compile.patch;patch=1" + file://cross_compile.patch;patch=1 \ + file://fbv-1.0b.patch;patch=1 \ + " + +#inherit autotools
Please do not comment out code. Everything is under versioning control.
Quoted 5 lines
recipes/fbv/fbv_1.0b.bb +1
-2do_configure() { - CC="${CC}" ./configure --without-libungif --without-bmp \ - --without-libjpeg + CC="${CC}" ./configure --without-libungif }
recipes/fbv/fbv_1.0b.bb line 24
Quoted 10 lines
recipes/fbv/fbv_1.0b.bb +2
-1do_compile() { oe_runmake CFLAGS="-O2 -Wall -D_GNU_SOURCE -D__KERNEL_STRICT_NAMES" \ CC="${CC}" } + do_install() { install -d ${D}${bindir} - install -m 0755 fbv ${D}${bindir} + install -m 0755 fbv ${D}${bindir}
What changed?
recipes/fbv/fbv_1.0b.bb line 29
Quoted 7 lines
recipes/fbv/fbv_1.0b.bb +3
-3- # man - install -d ${D}${mandir}/man1/ - install -m 0644 fbv.1 ${D}${mandir}/man1/fbv.1 +# man +# install -d ${D}${mandir}/man1/ +# install -m 0644 fbv.1 ${D}${mandir}/man1/fbv.1 }
Why did you disable this? If it is not needed, please do it in a separate patch or at least mention it in the commit message.
recipes/fbv/fbv_1.0b.bb line 32
Quoted 3 lines
recipes/fbv/fbv_1.0b.bb +3
-0+ +PACKAGES = "fbv" +
Thanks,
Paul
Am Mittwoch, den 20.01.2010, 00:25 +0100 schrieb Paul Menzel:
Quoted 34 lines
Am Mittwoch, den 20.01.2010, 00:06 +0100 schrieb Ulf Samuelsson:
Quoted 33 lines
Build fbv with jpeg and png enabled
Signed-off-by Ulf Samuelsson <[email protected]>--- recipes/fbv/fbv-1.0b/fbv-1.0b.patch | 12 ++++++++++++ recipes/fbv/fbv_1.0b.bb | 23 +++++++++++++++-------- 2 files changed, 27 insertions(+), 8 deletions(-) create mode 100644 recipes/fbv/fbv-1.0b/fbv-1.0b.patchrecipes/fbv/fbv-1.0b/fbv-1.0b.patch new file +12
-0@@ -0,0 +1,12 @@ +diff -urN fbv-1.0b-0rig/Makefile fbv-1.0b/Makefile +--- fbv-1.0b-0rig/Makefile 2009-08-20 00:33:58.000000000 +0200 ++++ fbv-1.0b/Makefile 2009-08-20 00:34:16.000000000 +0200 +@@ -12,7 +12,7 @@ + OBJECTS = ${SOURCES:.c=.o} + + OUT = fbv +-#LIBS = -lungif -L/usr/X11R6/lib -ljpeg -lpng ++LIBS = -L/usr/lib -ljpeg -lpng #-lungif + + all: $(OUT) + @echo Build DONE.recipes/fbv/fbv_1.0b.bb +0
-0@@ -1,25 +1,32 @@
Quoted 8 lines
recipes/fbv/fbv_1.0b.bb line 4
Quoted 5 lines
recipes/fbv/fbv_1.0b.bb +1
-1DESCRIPTION = "Frame Buffer Viewer" LICENSE = "GPL" -DEPENDS = "libpng" +DEPENDS = "libpng jpeg" PR = "r1"Should not this be increased because of the changed
DEPENDS? Why isPRnot just a number?
Sorry, please ignore that second question. It is late!
Quoted 51 lines
recipes/fbv/fbv_1.0b.bb line 11
Quoted 7 lines
recipes/fbv/fbv_1.0b.bb +5
-1SRC_URI = "http://s-tech.elsat.net.pl/fbv/fbv-1.0b.tar.gz \ - file://cross_compile.patch;patch=1" + file://cross_compile.patch;patch=1 \ + file://fbv-1.0b.patch;patch=1 \ + " + +#inherit autotoolsPlease do not comment out code. Everything is under versioning control.
Quoted 5 lines
recipes/fbv/fbv_1.0b.bb +1
-2do_configure() { - CC="${CC}" ./configure --without-libungif --without-bmp \ - --without-libjpeg + CC="${CC}" ./configure --without-libungif }recipes/fbv/fbv_1.0b.bb line 24
Quoted 10 lines
recipes/fbv/fbv_1.0b.bb +2
-1do_compile() { oe_runmake CFLAGS="-O2 -Wall -D_GNU_SOURCE -D__KERNEL_STRICT_NAMES" \ CC="${CC}" } + do_install() { install -d ${D}${bindir} - install -m 0755 fbv ${D}${bindir} + install -m 0755 fbv ${D}${bindir}What changed?
recipes/fbv/fbv_1.0b.bb line 29
Quoted 7 lines
recipes/fbv/fbv_1.0b.bb +3
-3- # man - install -d ${D}${mandir}/man1/ - install -m 0644 fbv.1 ${D}${mandir}/man1/fbv.1 +# man +# install -d ${D}${mandir}/man1/ +# install -m 0644 fbv.1 ${D}${mandir}/man1/fbv.1 }Why did you disable this? If it is not needed, please do it in a separate patch or at least mention it in the commit message.
recipes/fbv/fbv_1.0b.bb line 32
Quoted 3 lines
recipes/fbv/fbv_1.0b.bb +3
-0+ +PACKAGES = "fbv" +Thanks,
Paul
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Quoted 8 lines · Paul Menzel
Am Mittwoch, den 20.01.2010, 00:25 +0100 schrieb Paul Menzel:
Quoted 5 lines
Am Mittwoch, den 20.01.2010, 00:06 +0100 schrieb Ulf Samuelsson:
Quoted 1 line
PR = "r1"
Should not this be increased because of the changed
DEPENDS? Why isPRnot just a number?Sorry, please ignore that second question. It is late!
That's actually a good question, though not one that's specific to this one recipe. That leading "r" in ${PR} doesn't really serve any purpose other than to make all the recipes one byte bigger, and it might be nice to get rid of it at some point.
p.