Skip to contentSkip to conversation

ep93xx: Add support for Simplemachines Sim.One board

PATCH New Ryan Mallon 1 participant 2 messages Jan 20, 2010 4 messages not in the archive

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/Cirrus logic EP93XX Arm architecture
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

Ryan Mallon

author
#2 lore raw

PATCH 1/1 ep93xx: Add support for Simplemachines Sim.One board

Quoted 23 lines · H Hartley Sweeten
Quoted 13 lines · Ryan Mallon

The following patch adds support for the ep9307 based Sim.One board from Simplemachines. The code is based on the patches from Simplemachines for the 2.6.24.7 kernel available here:
http://sim1.googlecode.com/files/linux-2.6.24.7-patches-20091001.tgz.
Support for SPI and Audio is not included since we do not support them in mainline yet. The framebuffer support has been tested with a standard desktop monitor. LCD support is not included because I do not have hardware to test.

I have specified the maintainer for this board as Nuccio Raciti (CC'ed), who is the maintainer for Simplemachine's 2.6.24.7 patches. If this is not okay, I can put myself as the maintainer.

Quoted 7 lines
Signed-off-by Ryan Mallon <[email protected]>
Cc Nuccio Raciti <[email protected]>
Cc Peter Ivanov <[email protected]>
Cc Sergio Sorrenti <[email protected]>
Cc Hartley Sweeten <[email protected]>

----

Quoted 8 lines

Ryan,

Thanks for doing this. I had a similar patch almost ready but have not had the time to finish it.

A couple comments below.

(Fixed the ARM kernel list Cc, I accidentally sent it to the old list server originally. Can people please reply to this email rather than the other one so the ARM kernel list gets Cc'ed correctly.)

Thanks. I have also changed the maintainer to me, which is just easier I think. Updated patch below:
----

arch/arm/mach-ep93xx/Kconfig +7 -0
index 9167c3d..5231a3a 100644
@@ -161,6 +161,13 @@ config MACH_MICRO9S
 	  Say 'Y' here if you want your kernel to support the
 	  Contec Micro9-Slim board.
 
+config MACH_SIM_ONE
+        bool "Support Simplemachines Sim.One board"
+        depends on EP93XX_SDCE0_PHYS_OFFSET
+        help
+          Say 'Y' here if you want your kernel to support the
+          Simplemachines Sim.One board.
+
 config MACH_TS72XX
 	bool "Support Technologic Systems TS-72xx SBC"
 	depends on EP93XX_SDCE3_SYNC_PHYS_OFFSET
arch/arm/mach-ep93xx/Makefile +1 -0
index eae6199..c731fa9 100644
@@ -10,4 +10,5 @@ obj-$(CONFIG_MACH_ADSSPHERE)	+= adssphere.o
 obj-$(CONFIG_MACH_EDB93XX)	+= edb93xx.o
 obj-$(CONFIG_MACH_GESBC9312)	+= gesbc9312.o
 obj-$(CONFIG_MACH_MICRO9)	+= micro9.o
+obj-$(CONFIG_MACH_SIM_ONE)	+= simone.o
 obj-$(CONFIG_MACH_TS72XX)	+= ts72xx.o
arch/arm/mach-ep93xx/simone.c new file +97 -0

97 lines not on this page · raw message

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#5 lore raw

PATCH 1/1 ep93xx: Add support for Simplemachines Sim.One board

Quoted 9 lines · H Hartley Sweeten
Quoted 3 lines · Ryan Mallon

H Hartley Sweeten wrote:

Two minor nitpicks below...

Quoted 12 lines

arch/arm/mach-ep93xx/simone.c line 5

Quoted 9 lines
arch/arm/mach-ep93xx/simone.c new file +5 -0
@@ -0,0 +1,97 @@
+/*
+ * arch/arm/mach-ep93xx/simone.c
+ * Simplemachines Sim.One support.
+ *
+ * Copyright (C) 2009 Ryan Mallon <[email protected]>

2010?

I started writing the patch last year, hence the 2009. Can update if necessary.

Quoted 9 lines

arch/arm/mach-ep93xx/simone.c line 10

Quoted 6 lines
arch/arm/mach-ep93xx/simone.c new file +5 -0
+static struct ep93xxfb_mach_info simone_fb_info = {
+	.num_modes	= EP93XXFB_USE_MODEDB,
+	.bpp		= 16,
+	.flags		= EP93XXFB_USE_SDCSN0 | EP93XXFB_PCLK_FALLING,
+};

Nitpick.. Please put the fb stuff above after the i2c stuff below.

Can do if necessary. Its pretty minor though.

Quoted 9 lines

Did you happen to look at the patch I sent on 12/23/2009 with subject [PATCH] ep93xx: add missing SDRAM options for EDB93xx

I think the EP93XX_SDCE0_PHYS_BASE can be changed to PHYS_OFFSET in all the ep93xx platform init code. I'm not sure what Uwe Kleine-K?nig is going to do with the run time determined PHYS_OFFSET but I think that would at least get ep93xx ready for it.

The other boards are all still using the old way. I can change this board now, or just leave as is and we can change all of the boards later?

Quoted 9 lines

Other that that, looks good to me. This pretty much matches what I had pending. Have you at least compile tested this?

It would be nice if someone could actually test this to make sure the kernel boots correctly on the Sim.One. But for what it's worth:

Acked-by H Hartley Sweeten <[email protected]>

I'll wait on the guys from Simplemachines to have their say before I put this into the patch system.

~Ryan

Signature · 7 lines
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon         		5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com         	PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com	New Zealand
Phone: +64 3 3779127		Freecall: Australia 1800 148 751 
Fax:   +64 3 3779135			  USA 1800 261 2934