Unreferenced config in kernel (libata-sff.c) source (NO_ATA_LEGACY)

Hi all!

As part of the VAMOS[0] research project at the University of
Erlangen we're checking referential integrity between kernel KConfig options and in-code Conditional blocks.

./drivers/ata/libata-sff.c:2948:#if defined(CONFIG_NO_ATA_LEGACY)

That's the only place where it is checked for
NO_ATA_LEGACY. As this Item does appear nowhere in KConfig and therefor is not selectable I'm wondering whether that small Code fragment should be dropped or a new KConfig option should be added?

Please keep me informed of this patch getting confirmed /
merged so we can keep track of it.

Regards

Christoph Egger

CONFIG_NO_ATA_LEGACY isn't used by anyone. Drop it.

---

It's supposed to be set by architecture code to prevent SFF controller attach if it's in legacy mode. There apparently is no user left. Trying to find the last user... it seems it hasn't been unused for at least two year. I guess it can be removed then.

Thanks!

 drivers/ata/libata-sff.c |    9 ---------
 1 file changed, 9 deletions(-)

index 741065c..b9df435 100644
@@ -2945,15 +2945,6 @@ int ata_pci_sff_activate_host(struct ata_host *host,
 		mask = (1 << 2) | (1 << 0);
 		if ((tmp8 & mask) != mask)
 			legacy_mode = 1;
-#if defined(CONFIG_NO_ATA_LEGACY)
-		/* Some platforms with PCI limits cannot address compat
-		   port space. In that case we punt if their firmware has
-		   left a device in compatibility mode */
-		if (legacy_mode) {
-			printk(KERN_ERR "ata: Compatibility mode ATA is not supported on this platform, skipping.\n");
-			return -EOPNOTSUPP;
-		}
-#endif
 	}
 
 	if (!devres_open_group(dev, NULL, GFP_KERNEL))

Oops, Jeff, please send this #upstream. I was thinking #upstream but my fingers had their own mind. Thanks.

tejun

yep, definitely #upstream material...

Not unless this is cleared with the FRV maintainers who were using it and I believe may still need it.

Mr Howells ?

(cc'ing David Howells, who BTW is on vacation till Feb) Hi!

David, the patch in question is,

http://lkml.org/lkml/2010/1/20/396

Does FRV still need it?

Thanks.

tejun