Skip to contentSkip to conversation

hdpvr-video: cleanup signedness

PATCH In review Németh Márton 2 participants 2 messages Jan 23, 2010 – Feb 3, 2010 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hdpvr-video: cleanup signedness

From: Márton Németh <[email protected]>

The fifth parameter of usb_bulk_msg() is a pointer to signed (see <linux/usb.h>) so also call this function with pointer to signed.

This will remove the following sparse warning (see "make C=1"):
* warning: incorrect type in argument 5 (different signedness) expected int *actual_length
got unsigned int *<noident>

---

linux/drivers/media/video/hdpvr/hdpvr-video.c +2 -1
diff -r 2a50a0a1c951 linux/drivers/media/video/hdpvr/hdpvr-video.c
@@ -302,7 +302,8 @@
 /* function expects dev->io_mutex to be hold by caller */
 static int hdpvr_stop_streaming(struct hdpvr_device *dev)
 {
-	uint actual_length, c = 0;
+	int actual_length;
+	uint c = 0;
 	u8 *buf;
 
 	if (dev->status == STATUS_IDLE)
#1 lore raw
Quoted 11 lines · Németh Márton

From: Márton Németh <[email protected]>

The fifth parameter of usb_bulk_msg() is a pointer to signed (see <linux/usb.h>) so also call this function with pointer to signed.

This will remove the following sparse warning (see "make C=1"):
* warning: incorrect type in argument 5 (different signedness) expected int *actual_length
got unsigned int *<noident>

Thanks, I'll send a git pull request including the second patch for Mauro later today.

cheers Janne