Skip to contentSkip to conversation

SDL needs tslib to be compiled first when selected.

PATCH New julien.boibessot at free.fr 2 participants 4 messages Jan 26, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SDL needs tslib to be compiled first when selected.

From: Julien Boibessot <[email protected]>

If SDL is built before tslib, then SDL can't detect it at configure time and so touchscreen's support in SDL is crappy.

---
 package/sdl/sdl.mk |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
package/sdl/sdl.mk +4 -0
index f66ecc4..959be7e 100644
@@ -41,6 +41,10 @@ else
 SDL_X11=--enable-video-x11=no
 endif
 
+ifeq ($(BR2_PACKAGE_TSLIB),y)
+SDL_DEPENDENCIES += tslib
+endif
+
 $(DL_DIR)/$(SDL_SOURCE):
 	$(call DOWNLOAD,$(SDL_SITE),$(SDL_SOURCE))
 
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH 1/1 SDL needs tslib to be compiled first when selected.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"julien" == julien boibessot <[email protected]> writes:

julien> From: Julien Boibessot <[email protected]>

julien> If SDL is built before tslib, then SDL can't detect it at julien> configure time and so touchscreen's support in SDL is crappy.

Committed, thanks!

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 SDL needs tslib to be compiled first when selected.

Peter Korsgaard a ?crit :

Quoted 8 lines

julien> From: Julien Boibessot <[email protected]>

julien> If SDL is built before tslib, then SDL can't detect it at julien> configure time and so touchscreen's support in SDL is crappy.

Committed, thanks!

Should I also add a "--enable-tslib=no" configure option (not tested) to SDL, when tslib is not selected in BR ?
(like for directfb or x11)

Regards,
Julien

#3 lore raw

PATCH 1/1 SDL needs tslib to be compiled first when selected.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Julien" == Julien Boibessot <[email protected]> writes:

Hi,

Julien> Should I also add a "--enable-tslib=no" configure option (not Julien> tested) to SDL, when tslib is not selected in BR ? (like for Julien> directfb or x11)

Only if configure does the wrong thing (E.G. detects tslib being installed on the host when you do a target == host build).

Signature · 1 line
Bye, Peter Korsgaard