Skip to contentSkip to conversation

qla2xxx: negative error return in qla2x00_change_queue_depth()

PATCH In review Roel Kluin 2 participants 2 messages Jan 29, 2010 – Feb 2, 2010

Subsystems (2)
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 qla2xxx: negative error return in qla2x00_change_queue_depth()

The *change_queue_depth functions usually return a negative error return.

---

drivers/scsi/qla2xxx/qla_os.c +1 -1
index 8529eb1..0753877 100644
@@ -1258,7 +1258,7 @@ qla2x00_change_queue_depth(struct scsi_device *sdev, int qdepth, int reason)
 		qla2x00_adjust_sdev_qdepth_up(sdev, qdepth);
 		break;
 	default:
-		return EOPNOTSUPP;
+		return -EOPNOTSUPP;
 	}
 
 	return sdev->queue_depth;
Acked-by on v1 1/1
#1 lore raw
Quoted 18 lines · Roel Kluin

The *change_queue_depth functions usually return a negative error return.

---

drivers/scsi/qla2xxx/qla_os.c +1 -1
index 8529eb1..0753877 100644
@@ -1258,7 +1258,7 @@ qla2x00_change_queue_depth(struct scsi_device  
 *sdev, int qdepth, int reason)
 		qla2x00_adjust_sdev_qdepth_up(sdev, qdepth);
 		break;
 	default:
-		return EOPNOTSUPP;
+		return -EOPNOTSUPP;
 	}
 
	return sdev->queue_depth;