hdpvr-core: make module parameters local

PATCH New Németh Márton 1 participant 1 message Jan 29, 2010 Media (V4L/DVB)

lore

Share & tools

lore

Németh Márton

author

2010-01-29 20:31 UTC #0 lore raw

PATCH 1/1 hdpvr-core: make module parameters local

From: Márton Németh <[email protected]>

The default_video_input and default_audio_input module parameters are only used inside the hdpvr-core.c file so make them static.

This will remove the following sparse warnings (see "make C=1"):
* warning: symbol 'default_video_input' was not declared. Should it be static?
* warning: symbol 'default_audio_input' was not declared. Should it be static?

Signed-off-by Márton Németh <[email protected]>

---

linux/drivers/media/video/hdpvr/hdpvr-core.c +2 -2

diff -r 8b9a62386b64 linux/drivers/media/video/hdpvr/hdpvr-core.c
@@ -39,12 +39,12 @@
 module_param(hdpvr_debug, int, S_IRUGO|S_IWUSR);
 MODULE_PARM_DESC(hdpvr_debug, "enable debugging output");
 
-uint default_video_input = HDPVR_VIDEO_INPUTS;
+static uint default_video_input = HDPVR_VIDEO_INPUTS;
 module_param(default_video_input, uint, S_IRUGO|S_IWUSR);
 MODULE_PARM_DESC(default_video_input, "default video input: 0=Component / "
 		 "1=S-Video / 2=Composite");
 
-uint default_audio_input = HDPVR_AUDIO_INPUTS;
+static uint default_audio_input = HDPVR_AUDIO_INPUTS;
 module_param(default_audio_input, uint, S_IRUGO|S_IWUSR);
 MODULE_PARM_DESC(default_audio_input, "default audio input: 0=RCA back / "
 		 "1=RCA front / 2=S/PDIF");