Skip to contentSkip to conversation

may be wrong place #endif in include/linux/netfilter_ipv4.h

REPORT Helight.Xu 3 participants 3 messages Jan 31, 2010 – Feb 1, 2010 netfilter

lore
Share & tools
lore

Helight.Xu

author
#0 lore raw

hi all gys:

when I make LKM with netfilter on "NF_IP_PRE_ROUTING" point, but it
was reported that "NF_IP_PRE_ROUTING" is not defined.

but I am surely including <linux/netfilter_ipv4.h>, when I opened
include/linux/netfilter_ipv4.h I found that "NF_IP_PRE_ROUTING" is in this lable :
#ifndef __KERNEL__
.....
/* IP Hooks */
/* After promisc drops, checksum checks. */
#define NF_IP_PRE_ROUTING 0
/* If the packet is destined for this box. */
#define NF_IP_LOCAL_IN 1
/* If the packet is destined for another interface. */
#define NF_IP_FORWARD 2
/* Packets coming from a local process. */
#define NF_IP_LOCAL_OUT 3
/* Packets about to hit the wire. */
#define NF_IP_POST_ROUTING 4
#define NF_IP_NUMHOOKS 5
#endif /* ! __KERNEL__ */

So I think the "endif" is ended a little early!

Signature · 2 lines
Zhenwen Xu - Seven Helight
Home Page: http://zhwen.org
#1 lore raw
Quoted 24 lines · Helight.Xu

hi all gys:

when I make LKM with netfilter on "NF_IP_PRE_ROUTING" point, but it was
reported that "NF_IP_PRE_ROUTING" is not defined.

but I am surely including <linux/netfilter_ipv4.h>, when I opened
include/linux/netfilter_ipv4.h I found that "NF_IP_PRE_ROUTING" is in this lable :
#ifndef __KERNEL__
.....
/* IP Hooks */
/* After promisc drops, checksum checks. */
#define NF_IP_PRE_ROUTING 0
/* If the packet is destined for this box. */
#define NF_IP_LOCAL_IN 1
/* If the packet is destined for another interface. */
#define NF_IP_FORWARD 2
/* Packets coming from a local process. */
#define NF_IP_LOCAL_OUT 3
/* Packets about to hit the wire. */
#define NF_IP_POST_ROUTING 4
#define NF_IP_NUMHOOKS 5
#endif /* ! __KERNEL__ */

Quoted 1 line

So I think the "endif" is ended a little early!

Seems so. Are there any out-of-tree nf_ip_hook_priorities users? If not, we could possibly move it further below.

#2 lore raw
Quoted 26 lines · Jan Engelhardt
Quoted 24 lines · Helight.Xu

hi all gys:

when I make LKM with netfilter on "NF_IP_PRE_ROUTING" point, but it was
reported that "NF_IP_PRE_ROUTING" is not defined.

but I am surely including <linux/netfilter_ipv4.h>, when I opened
include/linux/netfilter_ipv4.h I found that "NF_IP_PRE_ROUTING" is in this lable :
#ifndef __KERNEL__
.....
/* IP Hooks */
/* After promisc drops, checksum checks. */
#define NF_IP_PRE_ROUTING 0
/* If the packet is destined for this box. */
#define NF_IP_LOCAL_IN 1
/* If the packet is destined for another interface. */
#define NF_IP_FORWARD 2
/* Packets coming from a local process. */
#define NF_IP_LOCAL_OUT 3
/* Packets about to hit the wire. */
#define NF_IP_POST_ROUTING 4
#define NF_IP_NUMHOOKS 5
#endif /* ! __KERNEL__ */

Quoted 4 lines
Quoted 1 line

So I think the "endif" is ended a little early!

Seems so. Are there any out-of-tree nf_ip_hook_priorities users? If not, we could possibly move it further below.

Its only available for userspace for compatibility reasons, the kernel doesn't use the old definitions.