Re-enabling non-GPL driver access to disk partition information
Hi Linuxers,
I've been working on a proprietary disk driver which has been working for the past couple years on Linux as old as 2.6.18. Unfortunately, as of 2.6.28 it appears that some of the gendisk interfaces (read:
structure members) I was using were moved behind an RCU and other GPL-ONLY accessor interfaces. I appologize for coming at this so late, but I don't monitor LKML and I only noticed this when we tried to port our driver to Ubuntu 9.04 and Fedora 11, and then had delays in getting this email out.
In particular, there is now no way for a proprietary driver to access the gendisk partition array, to enumerate the existing partitions, or to get information about existing partitions. All those interfaces are now GPL-Only, (whereas access to the structure members before were perfectly legal for non-GPL modules). But now the partition structure is sitting behind the GPL-Only RCU abstraction.
While I can hack around this to some extent, I'd rather have real interfaces I can use and play nicely with the Linux disk driver APIs. Therefore, I propose to convert a few of these interfaces to non-GPL export for general driver use. The list of functions I propose to change:
disk_get_part()put_device() (needed for the inline disk_put_part() function)
disk_part_iter_init()disk_part_iter_next()disk_part_iter_exit()
I hope this patch is acceptable to the Linux community and makes it quickly into a published Linux release.
Thanks,
-derek
** drivers/base/core.c
** block/genhd.c
Re-enable non-GPL access to disk partition information
Approved By: Derek Atkins <[email protected]>
base/core.c renamed from base/core.c~ +1 -1
@@ -1200,7 +1200,7 @@EXPORT_SYMBOL_GPL (device_del);EXPORT_SYMBOL_GPL (device_unregister);EXPORT_SYMBOL_GPL (get_device); -EXPORT_SYMBOL_GPL (put_device); +EXPORT_SYMBOL (put_device);EXPORT_SYMBOL_GPL (device_create_file);EXPORT_SYMBOL_GPL (device_remove_file);
genhd.c renamed from genhd.c~ +4 -4
@@ -72,7 +72,7 @@return part; } -EXPORT_SYMBOL_GPL (disk_get_part); +EXPORT_SYMBOL (disk_get_part);/** * disk_part_iter_init - initialize partition iterator
@@ -107,7 +107,7 @@rcu_read_unlock (); } -EXPORT_SYMBOL_GPL (disk_part_iter_init); +EXPORT_SYMBOL (disk_part_iter_init);/** * disk_part_iter_next - proceed iterator to the next partition and return it
@@ -163,7 +163,7 @@return piter->part; } -EXPORT_SYMBOL_GPL (disk_part_iter_next); +EXPORT_SYMBOL (disk_part_iter_next);/** * disk_part_iter_exit - finish up partition iteration
@@ -179,7 +179,7 @@disk_put_part (piter->part); piter->part =NULL ; } -EXPORT_SYMBOL_GPL (disk_part_iter_exit); +EXPORT_SYMBOL (disk_part_iter_exit);static inline int sector_in_part (struct hd_struct *part,sector_t sector) {
Signature · 5 lines
--
Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
Member, MIT Student Information Processing Board (SIPB)
URL: http://web.mit.edu/warlord/ PP-ASEL-IA N1NWH
[email protected] PGP key availableQuoted 6 lines · Derek Atkins
In particular, there is now no way for a proprietary driver to access the gendisk partition array, to enumerate the existing partitions, or to get information about existing partitions. All those interfaces are now GPL-Only, (whereas access to the structure members before were perfectly legal for non-GPL modules). But now the partition structure is sitting behind the GPL-Only RCU abstraction.
Why the hell does disk driver care about partitioning in the first place?
Quoted 7 lines · Derek Atkins
Hi Linuxers,
I've been working on a proprietary disk driver which has been working for the past couple years on Linux as old as 2.6.18. Unfortunately, as of 2.6.28 it appears that some of the gendisk interfaces (read:
structure members) I was using were moved behind an RCU and other GPL-ONLY accessor interfaces.
RCU is patented, with permission for GPL code to use the algorithm.
Exposing RCU bits to non-GPL modules would be rather pointless, since those don't have permission (from IBM, the RCU patent holder) to use RCU, anyway.
Signature · 1 line
All rights reversed.
Hi,
Quoted 5 lines · Rik van Riel
RCU is patented, with permission for GPL code to use the algorithm.
Exposing RCU bits to non-GPL modules would be rather pointless, since those don't have permission (from IBM, the RCU patent holder) to use RCU, anyway.
I'm neither asking for or suggesting non-GPL access to RCU. Rather I'm asking for non-GPL access to genhd partition information. In particular I'm looking for:
- # of actual partitions (which I used to obtain by iterating the table and counting -- yes, I know, gross)
- for each partition:
* partition start sector
* partition size
Quoted 6 lines · Alan Cox
Quoted 2 lines
get information about existing partitions. All those interfaces are now GPL-Only,
The kernel is GPL licensed. Please don't assume an
EXPORT_SYMBOL()means the GPL does not apply or that this magically indicates it isn't a derivative work.
I'm not making that assumption, and the lawyers involved have made that very very clear. (I've spent more time in meetings with lawyers in the past month than I have working on code). However, that's why I'm just asking for EXPORT_SYMBOL() instead of EXPORT_SYMBOL_GPL(), because I'm not sure I can license my module under the GPL (although it can be released under other licenses, but that doesn't give me access to GPL-Only symbols).
I'd prefer to be able to access the partition objects directly as I had been doing for a couple years. However I do have other alternatives if this patch (or something like it) wont be accepted.
-derek
Signature · 4 lines
Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
Member, MIT Student Information Processing Board (SIPB)
URL: http://web.mit.edu/warlord/ PP-ASEL-IA N1NWH
[email protected] PGP key availableQuoted 2 lines
get information about existing partitions. All those interfaces are now GPL-Only,
The kernel is GPL licensed. Please don't assume an EXPORT_SYMBOL() means the GPL does not apply or that this magically indicates it isn't a derivative work.
Alan
Quoted 2 lines · Derek Atkins
Approved By: Derek Atkins <[email protected]>
What does that mean?
base/core.c
Quoted 2 lines
base/core.c renamed from base/core.c~ +0
-0
Wrong diff level.
base/core.c line 1203
Quoted 6 lines
base/core.c renamed from base/core.c~ +1
-1@@ -1200,7 +1200,7 @@EXPORT_SYMBOL_GPL (device_del);EXPORT_SYMBOL_GPL (device_unregister);EXPORT_SYMBOL_GPL (get_device); -EXPORT_SYMBOL_GPL (put_device); +EXPORT_SYMBOL (put_device);
No, sorry, I've already successfully taken legal action against companies who have tried to go around the driver core's GPL-only symbols, so I can not, and will not, make this change.
thanks,
greg k-h
Quoted 8 lines · Greg KH
base/core.c line 1203
Quoted 3 lines · Derek Atkins
base/core.c renamed from base/core.c~ +1
-1-EXPORT_SYMBOL_GPL (put_device); +EXPORT_SYMBOL (put_device);No, sorry, [...] I can not, and will not, make this change.
Derek,
Consider writing a GPL wrapper module.
David
Quoted 11 lines · David Newall
Quoted 8 lines · Greg KH
base/core.c line 1203
Quoted 3 lines · Derek Atkins
base/core.c renamed from base/core.c~ +1
-1-EXPORT_SYMBOL_GPL (put_device); +EXPORT_SYMBOL (put_device);No, sorry, [...] I can not, and will not, make this change.
Quoted 3 lines
Derek,
Consider writing a GPL wrapper module.
Ah, the old "GPL condom" try. Sorry, but this has been tried many times in the past, and have been shut down every time. See the Samba history of this for lots of details as to why this does not work.
good luck,
greg k-h
Quoted 14 lines · Greg KH
Quoted 12 lines · David Newall
Quoted 10 lines · Greg KH
base/core.c line 1203
Quoted 4 lines · Derek Atkins
base/core.c renamed from base/core.c~ +1
-1-EXPORT_SYMBOL_GPL (put_device); +EXPORT_SYMBOL (put_device);No, sorry, [...] I can not, and will not, make this change.
Quoted 8 lines
Quoted 4 lines
Derek,
Consider writing a GPL wrapper module.
Ah, the old "GPL condom" try. Sorry, but this has been tried many times in the past, and have been shut down every time. See the Samba history of this for lots of details as to why this does not work.
Samba vs The Money merely shows that The Money failed to put up a sufficient defence. Good result for FOSS, but I recommend against you betting your home on it.
Anyway, I was thinking of something a little more substantial that what you perhaps read into my suggestion. There's usually a substantial gap between the pure needs of a driver and the facilities offered by an operating system. In the case in question, for example, the need is to count the number of partitions, and the facility offered is get_device, or something. A tiny GPL module that calls get_device and returns a count sounds eminently defensible.
In addition--and please keep in mind that I'm unfamiliar with the internals of the kernel--it seems to me there's an obvious similarity with USL vs BSD, alleging copyright for verbatim copying of macro constants, amongst other things. A lesson that learned then was that you can't prevent someone from using provided facilities necessary for use of the operating system. I don't know what put_device does, but I know what it sounds like; it sounds like it's something that you have to use, and so one can use it, even in proprietary code. I imagine this idea will irritate those who put in the hard yards, but FOSS has to play by the same rules as the monied end of town. You might want to think about this carefully, because if it's taken all the way through court and the GPL-only claim rejected, there may well be a run-on effect on all of the symbols marked GPL-only. Those who want to thwart proprietary kernel modules may find it prudent to generously give up this symbol rather than risking the lot.
Quoted 28 lines · David Newall
Quoted 6 lines · Greg KH
Quoted 5 lines · David Newall
Quoted 4 lines · Greg KH
base/core.c line 1203
Quoted 2 lines · Derek Atkins
base/core.c renamed from base/core.c~ +1
-1-EXPORT_SYMBOL_GPL (put_device); +EXPORT_SYMBOL (put_device);No, sorry, [...] I can not, and will not, make this change.
Quoted 7 lines
Quoted 3 lines
Derek,
Consider writing a GPL wrapper module.
Ah, the old "GPL condom" try. Sorry, but this has been tried many times in the past, and have been shut down every time. See the Samba history of this for lots of details as to why this does not work.
Samba vs The Money merely shows that The Money failed to put up a sufficient defence. Good result for FOSS, but I recommend against you betting your home on it.
Anyway, I was thinking of something a little more substantial that what you perhaps read into my suggestion. There's usually a substantial gap between the pure needs of a driver and the facilities offered by an operating system. In the case in question, for example, the need is to count the number of partitions, and the facility offered is
get_device, or something. A tiny GPL module that callsget_deviceand returns a count sounds eminently defensible.
Quoted 15 lines
In addition--and please keep in mind that I'm unfamiliar with the internals of the kernel--it seems to me there's an obvious similarity with USL vs BSD, alleging copyright for verbatim copying of macro constants, amongst other things. A lesson that learned then was that you can't prevent someone from using provided facilities necessary for use of the operating system. I don't know what
put_devicedoes, but I know what it sounds like; it sounds like it's something that you have to use, and so one can use it, even in proprietary code. I imagine this idea will irritate those who put in the hard yards, but FOSS has to play by the same rules as the monied end of town. You might want to think about this carefully, because if it's taken all the way through court and the GPL-only claim rejected, there may well be a run-on effect on all of the symbols marked GPL-only. Those who want to thwart proprietary kernel modules may find it prudent to generously give up this symbol rather than risking the lot.
The GPL flag on the symbols has no legal weight. What does have legal weight is whether whatever you're linking into the kernel can be considered a derivative work of the kernel or not. The intent of the EXPORT_SYMBOL_GPL flag is to warn that if you're using these symbols, then you're hooking into something sufficiently internal that you may be considered a derivative work. However, using symbols marked GPL in a non-GPL module doesn't necessarily mean you're violating the GPL, nor does not using them mean you're not. The only one that can give a definitive answer for any particular piece of code is likely a lawyer.