Constify struct acpi_dock_ops for v2.6.33-rc6
A message that is not in the archive (sent off-list or not yet received): [email protected]
Jeff Garzik
Acked-byQuoted 23 lines · Emese Revfy
From: Emese Revfy<[email protected]>
Constify struct
acpi_dock_ops.This is part of the ops structure constification
effort started by Arjan van de Ven et al.Benefits of this constification:
* prevents modification of data that is shared (referenced) by many other structure instances at runtime
* detects/prevents accidental (but not intentional) modification attempts on archs that enforce read-only kernel data at runtime
* potentially better optimized code as the compiler can assume that the const data cannot be changed
* the compiler/linker move const data into .rodata and therefore exclude them from false sharing
Quoted 8 lines
Signed-off-by Emese Revfy<[email protected]>---
drivers/acpi/dock.c | 4 ++-- drivers/ata/libata-acpi.c | 4 ++-- drivers/pci/hotplug/acpiphp_glue.c | 2 +- include/acpi/acpi_drivers.h | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-)
Acked-by Jeff Garzik <[email protected]>