kbuild: move -fno-dwarf2-cfi-asm to powerpc only
PATCH 2/2 kbuild: move -fno-dwarf2-cfi-asm to powerpc only
From: Andi Kleen <[email protected]>
Better dwarf2 unwind information is a good thing, it allows better debugging with kgdb and crash and helps systemtap.
Commit 003086497f07f7f1e67c0c295e261740f822b377 ("Build with -fno-dwarf2-cfi-asm") disabled some CFI information globally to work around a module loader bug on powerpc.
But this disables the better unwind tables for all architectures, not just powerpc. Move the workaround to powerpc and also add a suitable comment that's it really a workaround.
This improves dwarf2 unwind tables on x86 at least.
---
Makefile | 3 --- arch/powerpc/Makefile | 5 +++++ 2 files changed, 5 insertions(+), 3 deletions(-)
Makefile renamed from Makefile~kbuild-move-fno-dwarf2-cfi-asm-to-powerpc-only +0 -3
@@ -579,9 +579,6 @@ KBUILD_CFLAGS += $(call cc-option,-Wno-p # disable invalid "can't wrap" optimizations for signed / pointers KBUILD_CFLAGS += $(call cc-option,-fno-strict-overflow) -# revert to pre-gcc-4.4 behaviour of .eh_frame -KBUILD_CFLAGS += $(call cc-option,-fno-dwarf2-cfi-asm) - # conserve stack if available KBUILD_CFLAGS += $(call cc-option,-fconserve-stack)
arch/powerpc/Makefile renamed from arch/powerpc/Makefile~kbuild-move-fno-dwarf2-cfi-asm-to-powerpc-only +5 -0
@@ -112,6 +112,11 @@ KBUILD_CFLAGS += $(call cc-option,-mspe= # kernel considerably. KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time) +# FIXME: the module load should be taught about the additional relocs +# generated by this. +# revert to pre-gcc-4.4 behaviour of .eh_frame +KBUILD_CFLAGS += $(call cc-option,-fno-dwarf2-cfi-asm) + # Never use string load/store instructions as they are # often slow when they are implemented at all KBUILD_CFLAGS += -mno-string
_
Quoted 9 lines · On Tue, 2010-02-02 at 14:40 -0800, [email protected] wrote:
From: Andi Kleen <[email protected]>
Better dwarf2 unwind information is a good thing, it allows better debugging with kgdb and crash and helps systemtap.
Commit
003086497f07f7f1e67c0c295e261740f822b377("Build with -fno-dwarf2-cfi-asm") disabled some CFI information globally to work around a module loader bug on powerpc.
Quoted 8 lines
But this disables the better unwind tables for all architectures, not just powerpc. Move the workaround to powerpc and also add a suitable comment that's it really a workaround.
This improves dwarf2 unwind tables on x86 at least.
Signed-off-by Andi Kleen <[email protected]>Cc Kyle McMartin <[email protected]>
Do you want me to carry that in powerpc-next ?
Cheers,
Ben.
Quoted 37 lines
Cc Michal Marek <[email protected]>Signed-off-by Andrew Morton <[email protected]>---
Makefile | 3 --- arch/powerpc/Makefile | 5 +++++ 2 files changed, 5 insertions(+), 3 deletions(-)diff -puN Makefile~kbuild-move-fno-dwarf2-cfi-asm-to-powerpc-only
MakefileMakefile renamed from Makefile~kbuild-move-fno-dwarf2-cfi-asm-to-powerpc-only +0
-3@@ -579,9 +579,6 @@ KBUILD_CFLAGS += $(call cc-option,-Wno-p # disable invalid "can't wrap" optimizations for signed / pointers KBUILD_CFLAGS += $(call cc-option,-fno-strict-overflow) -# revert to pre-gcc-4.4 behaviour of .eh_frame -KBUILD_CFLAGS += $(call cc-option,-fno-dwarf2-cfi-asm) - # conserve stack if available KBUILD_CFLAGS += $(call cc-option,-fconserve-stack)diff -puN
arch/powerpc/Makefile~kbuild-move-fno-dwarf2-cfi-asm-to-powerpc-onlyarch/powerpc/Makefilearch/powerpc/Makefile renamed from arch/powerpc/Makefile~kbuild-move-fno-dwarf2-cfi-asm-to-powerpc-only +5
-0@@ -112,6 +112,11 @@ KBUILD_CFLAGS += $(call cc-option,-mspe= # kernel considerably. KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time) +# FIXME: the module load should be taught about the additional relocs +# generated by this. +# revert to pre-gcc-4.4 behaviour of .eh_frame +KBUILD_CFLAGS += $(call cc-option,-fno-dwarf2-cfi-asm) + # Never use string load/store instructions as they are # often slow when they are implemented at all KBUILD_CFLAGS += -mno-string_
Quoted 14 lines · Benjamin Herrenschmidt
Quoted 13 lines · On Tue, 2010-02-02 at 14:40 -0800, [email protected] wrote:
From: Andi Kleen <[email protected]>
Better dwarf2 unwind information is a good thing, it allows better debugging with kgdb and crash and helps systemtap.
Commit
003086497f07f7f1e67c0c295e261740f822b377("Build with -fno-dwarf2-cfi-asm") disabled some CFI information globally to work around a module loader bug on powerpc.But this disables the better unwind tables for all architectures, not just powerpc. Move the workaround to powerpc and also add a suitable comment that's it really a workaround.
Quoted 8 lines
Quoted 4 lines
This improves dwarf2 unwind tables on x86 at least.
Signed-off-by Andi Kleen <[email protected]>Cc Kyle McMartin <[email protected]>Do you want me to carry that in powerpc-next ?
I can add it to kbuild-next. Changes to the top-level Makefile usually go through kbuild, so it will avoid potential conflicts.
Michal