Skip to contentSkip to conversation

xfstests: make 204 generic

PATCH In review Eric Sandeen 2 participants 3 messages Feb 9, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: make 204 generic

204 can be generic.

Also remove a stray _scratch_mkfs that snuck into
_scratch_mkfs_sized :/

---

204 +3 -2
index 1ac9ebf..14ebcdc 100755
@@ -35,12 +35,13 @@ status=1	# failure is the default!
 . ./common.filter
 
 # real QA test starts here
-_supported_fs xfs
+_supported_fs generic
 _supported_os Linux
 
 _require_scratch
 
-_scratch_mkfs_xfs -d size=104m >/dev/null
+SIZE=104*1024*1024
+_scratch_mkfs_sized $SIZE  &> /dev/null
 _scratch_mount
 
 for i in `seq 1 22500`; do
common.rc +0 -1
index 0a02a2b..c76bcde 100644
@@ -325,7 +325,6 @@ _scratch_mkfs_sized()
 	_notrun "Filesystem $FSTYP not supported in _scratch_mkfs_sized"
 	;;
     esac
-    _scratch_mkfs
 }
 
 # Emulate an N-data-disk stripe w/ various stripe units

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · Eric Sandeen

204 can be generic.

Looks good.

Quoted 2 lines

Also remove a stray _scratch_mkfs that snuck into
_scratch_mkfs_sized :/

Heh, that might have made the ENOSPC tests pass rather easily before..

Quoted 1 line

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw
Quoted 9 lines · Christoph Hellwig
Quoted 1 line · Eric Sandeen

204 can be generic.

Looks good.

Quoted 2 lines

Also remove a stray _scratch_mkfs that snuck into
_scratch_mkfs_sized :/

Heh, that might have made the ENOSPC tests pass rather easily before..

Yeah :/

Quoted 4 lines
Quoted 1 line

Thanks,
-eric

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs