Skip to contentSkip to conversation

KVM: Fix properties of instructions in group 1_82

PATCH Applied Gleb Natapov 2 participants 2 messages Feb 11, 2010

Subsystems (3)
x86 KVM KVM x86
lore
Share & tools
lore

Gleb Natapov

author
#0 lore raw

PATCH 1/1 KVM: Fix properties of instructions in group 1_82

Instructions with opcode 82 are not valid in 64bit mode and can be locked.

Signed-off-by Gleb Natapov <[email protected]>
arch/x86/kvm/emulate.c +8 -4
index f7bb5ef..741b0be 100644
@@ -310,10 +310,14 @@ static u32 group_table[] = {
 	DstMem | SrcImm | ModRM | Lock,
 	DstMem | SrcImm | ModRM,
 	[Group1_82*8] =
-	ByteOp | DstMem | SrcImm | ModRM, ByteOp | DstMem | SrcImm | ModRM,
-	ByteOp | DstMem | SrcImm | ModRM, ByteOp | DstMem | SrcImm | ModRM,
-	ByteOp | DstMem | SrcImm | ModRM, ByteOp | DstMem | SrcImm | ModRM,
-	ByteOp | DstMem | SrcImm | ModRM, ByteOp | DstMem | SrcImm | ModRM,
+	ByteOp | DstMem | SrcImm | ModRM | No64 | Lock,
+	ByteOp | DstMem | SrcImm | ModRM | No64 | Lock,
+	ByteOp | DstMem | SrcImm | ModRM | No64 | Lock,
+	ByteOp | DstMem | SrcImm | ModRM | No64 | Lock,
+	ByteOp | DstMem | SrcImm | ModRM | No64 | Lock,
+	ByteOp | DstMem | SrcImm | ModRM | No64 | Lock,
+	ByteOp | DstMem | SrcImm | ModRM | No64 | Lock,
+	ByteOp | DstMem | SrcImm | ModRM | No64,
 	[Group1_83*8] =
 	DstMem | SrcImmByte | ModRM | Lock,
 	DstMem | SrcImmByte | ModRM | Lock,

--
Gleb.

Applied
#1 lore raw
Quoted 3 lines · Gleb Natapov

Instructions with opcode 82 are not valid in 64bit mode and can be locked.

Applied, thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function