Skip to contentSkip to conversation

arm: add support for the suen3 board from keymile

PATCH Superseded Heiko Schocher 2 participants 3 messages Feb 12, 2010 – Feb 15, 2010 Kbuild

v4 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 2/4 arm: add support for the suen3 board from keymile

This patch adds support for the Keymile suen3 board which is based on the Marvell Kirkwood (88F6281) SoC. As this is a variant of the mgcoge2_arm_p1a board, this board also uses common code stored in board/keymile/km_arm/km_arm.c

---
- changes since v1:
added comments from Wolfgang Denk:
get rid of flash_info_t define in board config (to get this working patch 1/2 is introduced/needed)

- changes since v2:
added comments from Wolfgang Denk
- rearranged if/else in do_spi_toggle()
- added I/O accessor functions for bootcounter

- changes since v3:
added comment Scott Wood
- removed nand_init in do_spi_toggle()

added comments from Prafulla Wadagaskar
- km-arm.h renamed to km_arm.h
- reworked eeprom_write_enable() (deleted it) (when reviewing this function, it cropped up, that this pin is connected through a gpio pin, not as in previous version, through the boco (a FPGA))
- moved set_sda(), set_scl(), get_sda(), get_scl() to km_arm.c
- split patch in 4 patches (for each board an extra patch)
- renamed sdramregs.txt in kwbimage.cfg, also license info added.

 MAINTAINERS             |    1 +
 MAKEALL                 |    1 +
 Makefile                |    3 +
 include/configs/suen3.h |  103 +++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 108 insertions(+), 0 deletions(-)
 create mode 100644 include/configs/suen3.h
MAINTAINERS +1 -0
index eda15c8..ab27afc 100644
@@ -411,6 +411,7 @@ Heiko Schocher <[email protected]>
 	muas3001	MPC8270
 	municse		MPC5200
 	sc3		PPC405GP
+	suen3		ARM926EJS (Kirkwood SoC)
 	uc101		MPC5200
 
 
MAKEALL +1 -0
index 1c18734..7577ea5 100755
@@ -580,6 +580,7 @@ LIST_ARM9="			\
 	spear310		\
 	spear320		\
 	spear600		\
+	suen3			\
 	trab			\
 	VCMA9			\
 	versatile		\
Makefile +3 -0
index 990f932..3ea2b53 100644
@@ -3050,6 +3050,9 @@ spear320_config :	unconfig
 spear600_config :	unconfig
 	@$(MKCONFIG) -n $@ -t $(@:_config=) spear6xx arm arm926ejs $(@:_config=) spear spear
 
+suen3_config:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs km_arm keymile kirkwood
+
 SX1_stdout_serial_config \
 SX1_config:		unconfig
 	@mkdir -p $(obj)include
include/configs/suen3.h new file +103 -0

103 lines not on this page · raw message

Signature · 5 lines
1.6.2.5

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#1 lore raw

PATCH v4 2/4 arm: add support for the suen3 board from keymile

Quoted 43 lines

-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Friday, February 12, 2010 1:36 PM
To: U-Boot user list
Cc: Wolfgang Denk; Prafulla Wadaskar; Scott Wood; Stefan Roese
Subject: [PATCH 2/4 v4] arm: add support for the suen3 board from keymile

This patch adds support for the Keymile suen3 board which is based on the Marvell Kirkwood (88F6281) SoC. As this is a variant of the mgcoge2_arm_p1a board, this board also uses common code stored in board/keymile/km_arm/km_arm.c

---
- changes since v1:
added comments from Wolfgang Denk:
get rid of flash_info_t define in board config (to get this working patch 1/2 is introduced/needed)

- changes since v2:
added comments from Wolfgang Denk
- rearranged if/else in do_spi_toggle()
- added I/O accessor functions for bootcounter

- changes since v3:
added comment Scott Wood
- removed nand_init in do_spi_toggle()

added comments from Prafulla Wadagaskar
- km-arm.h renamed to km_arm.h
- reworked eeprom_write_enable() (deleted it) (when reviewing this function, it cropped up, that this pin is connected through a gpio pin, not as in previous version, through the boco (a FPGA))
- moved set_sda(), set_scl(), get_sda(), get_scl() to km_arm.c
- split patch in 4 patches (for each board an extra patch)
- renamed sdramregs.txt in kwbimage.cfg, also license info added.

Quoted 4 lines
 MAINTAINERS             |    1 +
 MAKEALL                 |    1 +
 Makefile                |    3 +
 include/configs/suen3.h |  103

There is some code in earlier patch (i.e 1/4) for this board support that should reflect here. This gives better understanding

Regards..
Prafulla . .

#2 lore raw

PATCH v4 2/4 arm: add support for the suen3 board from keymile

Hello Prafulla,

Quoted 41 lines · Prafulla Wadaskar
Quoted 41 lines

-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Friday, February 12, 2010 1:36 PM
To: U-Boot user list
Cc: Wolfgang Denk; Prafulla Wadaskar; Scott Wood; Stefan Roese
Subject: [PATCH 2/4 v4] arm: add support for the suen3 board from keymile

This patch adds support for the Keymile suen3 board which is based on the Marvell Kirkwood (88F6281) SoC. As this is a variant of the mgcoge2_arm_p1a board, this board also uses common code stored in board/keymile/km_arm/km_arm.c

---
- changes since v1:
added comments from Wolfgang Denk:
get rid of flash_info_t define in board config (to get this working patch 1/2 is introduced/needed)

- changes since v2:
added comments from Wolfgang Denk
- rearranged if/else in do_spi_toggle()
- added I/O accessor functions for bootcounter

- changes since v3:
added comment Scott Wood
- removed nand_init in do_spi_toggle()

added comments from Prafulla Wadagaskar
- km-arm.h renamed to km_arm.h
- reworked eeprom_write_enable() (deleted it) (when reviewing this function, it cropped up, that this pin is connected through a gpio pin, not as in previous version, through the boco (a FPGA))
- moved set_sda(), set_scl(), get_sda(), get_scl() to km_arm.c
- split patch in 4 patches (for each board an extra patch)
- renamed sdramregs.txt in kwbimage.cfg, also license info added.

Quoted 7 lines
Quoted 4 lines
 MAINTAINERS             |    1 +
 MAKEALL                 |    1 +
 Makefile                |    3 +
 include/configs/suen3.h |  103

There is some code in earlier patch (i.e 1/4) for this board support that should reflect here. This gives better understanding

Hmm.. or I should better make the suen3 port as the first patch, and the other board revisions as follow ups ... ?

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany