Skip to contentSkip to conversation

Fix hanging user monitor when using balloon command

PATCH In review Adam Litke 2 participants 2 messages Feb 12, 2010

lore
Share & tools
lore

Adam Litke

author
#0 lore raw

PATCH 1/1 Fix hanging user monitor when using balloon command

Hi Anthony. I wonder if there was a problem when importing my async command handler patchset. Since the 'balloon' command completes immediately, it must call the completion callback before returning. That call was missing but is added by the patch below.

monitor.c +1 -0
index ae125b8..f94794d 100644
@@ -2258,6 +2258,7 @@ static int do_balloon(Monitor *mon, const QDict *params,
         return -1;
     }
 
+    cb(opaque, NULL);
     return 0;
 }
 
Signature · 2 lines
Thanks,
Adam
#1 lore raw
Quoted 5 lines · Adam Litke

Hi Anthony. I wonder if there was a problem when importing my async command handler patchset. Since the 'balloon' command completes immediately, it must call the completion callback before returning. That call was missing but is added by the patch below.

Needs a Signed-off-by. I don't recall any fuzz with your patch but that was a few hundred patches ago :-)

Regards,

Anthony Liguori

Quoted 13 lines
monitor.c +1 -0
index ae125b8..f94794d 100644
@@ -2258,6 +2258,7 @@ static int do_balloon(Monitor *mon, const QDict *params,
          return -1;
      }
 
+    cb(opaque, NULL);
      return 0;
  }