Skip to contentSkip to conversation

qemu-kvm: pcnet APROMWE bit location

PATCH In review Chris Kilgour 2 participants 2 messages Feb 14, 2010 – Feb 17, 2010 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qemu-kvm: pcnet APROMWE bit location

I don't subscribe to the list, so please excuse any breach of etiquette.

According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2.

Signed-off-by Christopher Kilgour <techie <at> whiterocker.com>

---

hw/pcnet.c +0 -0
index 44b5b31..f889898 100644
@@ -1601,7 +1601,7 @@ static void pcnet_aprom_writeb(void *opaque,

uint32_t addr

     printf("pcnet_aprom_writeb addr=0x%08x val=0x%02x\n", addr, val);
 #endif
     /* Check APROMWE bit to enable write access */
-    if (pcnet_bcr_readw(s,2) & 0x80)
+    if (pcnet_bcr_readw(s,2) & 0x100)
         s->prom[addr & 15] = val;

}

#1 lore raw
Quoted 4 lines · Chris Kilgour

I don't subscribe to the list, so please excuse any breach of etiquette.

According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2.

Please send this to the qemu mailing list, [email protected], as this code is shared between qemu and qemu-kvm. Thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function