Skip to contentSkip to conversation

pcnet APROMWE bit location

PATCH In review Chris Kilgour 2 participants 4 messages Feb 15, 2010 – Mar 9, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pcnet APROMWE bit location

I don't subscribe to the list, so please excuse any breach of etiquette.

According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2.

Signed-off-by Christopher Kilgour <techie <at> whiterocker.com>

---

hw/pcnet.c +0 -0
index 44b5b31..f889898 100644
@@ -1601,7 +1601,7 @@ static void pcnet_aprom_writeb(void *opaque,

uint32_t addr

     printf("pcnet_aprom_writeb addr=0x%08x val=0x%02x\n", addr, val);
 #endif
     /* Check APROMWE bit to enable write access */
-    if (pcnet_bcr_readw(s,2) & 0x80)
+    if (pcnet_bcr_readw(s,2) & 0x100)
         s->prom[addr & 15] = val;

}

#1 lore raw
Quoted 6 lines · Chris Kilgour

I don't subscribe to the list, so please excuse any breach of etiquette.

According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2.

Signed-off-by Christopher Kilgour<techie<at> whiterocker.com>

Your mailer munged this patch so it doesn't apply. Please resend. Also, please use a proper email address in the Signed-off-by line.

Regards,

Anthony Liguori

Quoted 20 lines

---

hw/pcnet.c +0 -0
index 44b5b31..f889898 100644
@@ -1601,7 +1601,7 @@ static void pcnet_aprom_writeb(void *opaque,

uint32_t addr

      printf("pcnet_aprom_writeb addr=0x%08x val=0x%02x\n", addr, val);
  #endif
      /* Check APROMWE bit to enable write access */
hw/pcnet.c +1 -1
-    if (pcnet_bcr_readw(s,2)&  0x80)
+    if (pcnet_bcr_readw(s,2)&  0x100)
          s->prom[addr&  15] = val;
  }
#2 lore raw

PATCH 1/1 pcnet APROMWE bit location (retry)

According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2.

---

hw/pcnet.c +1 -1
index 44b5b31..f889898 100644
@@ -1601,7 +1601,7 @@ static void pcnet_aprom_writeb(void *opaque, uint32_t addr, uint32_t val)
     printf("pcnet_aprom_writeb addr=0x%08x val=0x%02x\n", addr, val);
 #endif
     /* Check APROMWE bit to enable write access */
-    if (pcnet_bcr_readw(s,2) & 0x80)
+    if (pcnet_bcr_readw(s,2) & 0x100)
         s->prom[addr & 15] = val;
 }
#3 lore raw

Re: [Qemu-devel] [PATCH] pcnet APROMWE bit location (retry)

Quoted 4 lines · Chris Kilgour

According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2.

Applied. Thanks.

Regards,

Anthony Liguori

Quoted 18 lines

---

hw/pcnet.c +1 -1
index 44b5b31..f889898 100644
@@ -1601,7 +1601,7 @@ static void pcnet_aprom_writeb(void *opaque, uint32_t addr, uint32_t val)
      printf("pcnet_aprom_writeb addr=0x%08x val=0x%02x\n", addr, val);
  #endif
      /* Check APROMWE bit to enable write access */
-    if (pcnet_bcr_readw(s,2)&  0x80)
+    if (pcnet_bcr_readw(s,2)&  0x100)
          s->prom[addr&  15] = val;
  }