Skip to contentSkip to conversation

OMAP3: workaround for ARM Cortex-A8 erratum 725233

PATCH New Siarhei Siamashka 3 participants 4 messages Feb 21, 2010 – Feb 25, 2010

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 OMAP3: workaround for ARM Cortex-A8 erratum 725233

725233: PLD instructions executed with PLD data forwarding enabled can result in a processor deadlock

This deadlock can happen when NEON load instructions are used together with cache preload instructions (PLD). The problematic conditions can be triggered in-the-wild by NEON optimized functions from pixman library (http://cgit.freedesktop.org/pixman), which perform dynamic adjustment of prefetch distance.

The workaround disables PLD data forwarding by setting PLD_FWD bit in L2 Cache Auxiliary Control Register as recommended in ARM Cortex-A8 errata list.

The deadlock can only happen on r1pX revisions of Cortex-A8 (used in OMAP34xx/OMAP35xx). Performance impact of the workaround is practically non-existant.

---
Revision history:
v2 - Comment text extended with a bit more information about the
affected Cortex-A8 core revisions, potential drawbacks (none known at the moment) and the information about where this CPU bug can be encountered in practice. No changes to the patch itself.

 cpu/arm_cortexa8/omap3/board.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
cpu/arm_cortexa8/omap3/board.c +6 -0
index 2aa69b3..7b78fa4 100644
@@ -146,6 +146,12 @@ void setup_auxcr()
 	__asm__ __volatile__("orr r0, r0, #1 << 5");
 	/* SMI instruction to call ROM Code API */
 	__asm__ __volatile__(".word 0xE1600070");
+	/* Set PLD_FWD bit in L2AUXCR (Cortex-A8 erratum 725233 workaround) */
+	__asm__ __volatile__("mov r12, #0x2");
+	__asm__ __volatile__("mrc p15, 1, r0, c9, c0, 2");
+	__asm__ __volatile__("orr r0, r0, #1 << 27");
+	/* SMI instruction to call ROM Code API */
+	__asm__ __volatile__(".word 0xE1600070");
 	__asm__ __volatile__("mov r0, %0":"=r"(i));
 	__asm__ __volatile__("mov r12, %0":"=r"(j));
 }
Signature · 1 line
1.5.4.3
#1 lore raw

PATCH v2 1/1 OMAP3: workaround for ARM Cortex-A8 erratum 725233

Quoted 13 lines · Siarhei Siamashka

725233: PLD instructions executed with PLD data forwarding enabled can result in a processor deadlock

This deadlock can happen when NEON load instructions are used together with cache preload instructions (PLD). The problematic conditions can be triggered in-the-wild by NEON optimized functions from pixman library (http://cgit.freedesktop.org/pixman), which perform dynamic adjustment of prefetch distance.

The workaround disables PLD data forwarding by setting PLD_FWD bit in L2 Cache Auxiliary Control Register as recommended in ARM Cortex-A8 errata list.

Quoted 5 lines

The deadlock can only happen on r1pX revisions of Cortex-A8 (used in OMAP34xx/OMAP35xx). Performance impact of the workaround is practically non-existant.

Thank you for the improvements on the comment.
Ack-ed.

Tom

#2 lore raw

PATCH v2 1/1 OMAP3: workaround for ARM Cortex-A8 erratum 725233

Quoted 16 lines
Quoted 13 lines · Siarhei Siamashka

725233: PLD instructions executed with PLD data forwarding enabled can result in a processor deadlock

This deadlock can happen when NEON load instructions are used together with cache preload instructions (PLD). The problematic conditions can be triggered in-the-wild by NEON optimized functions from pixman library (http://cgit.freedesktop.org/pixman), which perform dynamic adjustment of prefetch distance.

The workaround disables PLD data forwarding by setting PLD_FWD bit in L2 Cache Auxiliary Control Register as recommended in ARM Cortex-A8 errata list.

Quoted 8 lines
Quoted 5 lines

The deadlock can only happen on r1pX revisions of Cortex-A8 (used in OMAP34xx/OMAP35xx). Performance impact of the workaround is practically non-existant.

Thank you for the improvements on the comment.
Ack-ed.

Seems important to me.
I'm going to push it to u-boot-ti and send a pull request for the same

Quoted 2 lines

Tom

#3 lore raw

PATCH v2 1/1 OMAP3: workaround for ARM Cortex-A8 erratum 725233

Quoted 18 lines · Sandeep
Quoted 18 lines
Quoted 17 lines · Siarhei Siamashka

725233: PLD instructions executed with PLD data forwarding enabled can result in a processor deadlock

This deadlock can happen when NEON load instructions are used together with cache preload instructions (PLD). The problematic conditions can be triggered in-the-wild by NEON optimized functions from pixman library (http://cgit.freedesktop.org/pixman), which perform dynamic adjustment of prefetch distance.

The workaround disables PLD data forwarding by setting PLD_FWD bit in L2 Cache Auxiliary Control Register as recommended in ARM Cortex-A8 errata list.

The deadlock can only happen on r1pX revisions of Cortex-A8 (used in OMAP34xx/OMAP35xx). Performance impact of the workaround is practically non-existant.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Thank you for the improvements on the comment.
Ack-ed.

Seems important to me.
I'm going to push it to u-boot-ti and send a pull request for the same

I saw the merge on TI so I went ahead and pulled.
Applied to ARM.
Thanks
Tom

Quoted 2 lines
Quoted 2 lines

Tom