Skip to contentSkip to conversation

ath9k: disable RIFS search for AR91xx based chips

PATCH In review Felix Fietkau 2 participants 2 messages Feb 24, 2010 Qualcomm Atheros ATH9K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath9k: disable RIFS search for AR91xx based chips

While ath9k does not support RIFS yet, the ability to receive RIFS frames is currently enabled for most chipsets in the initvals. This is causing baseband related issues on AR9160 and AR9130 based chipsets, which can lock up under certain conditions.

This patch fixes these issues by overriding the initvals, effectively disabling RIFS for all affected chipsets.

---

drivers/net/wireless/ath/ath9k/hw.c +10 -0
@@ -1326,6 +1326,16 @@ static void ath9k_hw_override_ini(struct
 	 * Necessary to avoid issues on AR5416 2.0
 	 */
 	REG_WRITE(ah, 0x9800 + (651 << 2), 0x11);
+
+	/*
+	 * Disable RIFS search on some chips to avoid baseband
+	 * hang issues.
+	 */
+	if (AR_SREV_9100(ah) || AR_SREV_9160(ah)) {
+		val = REG_READ(ah, AR_PHY_HEAVY_CLIP_FACTOR_RIFS);
+		val &= ~AR_PHY_RIFS_INIT_DELAY;
+		REG_WRITE(ah, AR_PHY_HEAVY_CLIP_FACTOR_RIFS, val);
+	}
 }
 
 static u32 ath9k_hw_def_ini_fixup(struct ath_hw *ah,
drivers/net/wireless/ath/ath9k/phy.h +3 -0
@@ -384,6 +384,9 @@ bool ath9k_hw_set_rf_regs(struct ath_hw 
 
 #define AR_PHY_HEAVY_CLIP_ENABLE         0x99E0
 
+#define AR_PHY_HEAVY_CLIP_FACTOR_RIFS    0x99EC
+#define AR_PHY_RIFS_INIT_DELAY         0x03ff0000
+
 #define AR_PHY_M_SLEEP      0x99f0
 #define AR_PHY_REFCLKDLY    0x99f4
 #define AR_PHY_REFCLKPD     0x99f8
Acked-by on v1 1/1
#1 lore raw
Quoted 1 line · Felix Fietkau

While ath9k does not support RIFS yet,

Not 100% sure but I actually think we do have it enabled for single-chip solutions and I think it should work.

Quoted 10 lines

the ability to receive RIFS
frames is currently enabled for most chipsets in the initvals. This is causing baseband related issues on AR9160 and AR9130 based chipsets, which can lock up under certain conditions.

This patch fixes these issues by overriding the initvals, effectively disabling RIFS for all affected chipsets.

Luis