Bugfixing and improvement of the AT91 MCI driver
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 Bugfixing and improvement of the AT91 MCI driver
Le 25/02/2010 08:59, Wolfgang M?es :
Quoted 1 line
Nicolas,
Hi Wolfgang,
Thanks a lot for your hard work on this driver and your patch.
Quoted 15 lines
as we are working on a project regarding AT91SAM9260 and using the MCI interface for SD/SDHC data transfer, we are forced to make a series of bugfixes and improvements to the AT91 MCI driver:
- Fix a buf in the dmabuf pointer calculation.
- Use a fixed DMA buffer instead of allocating a DMA buffer each time a data transfer is requested.
- Fix address error inkunmap_atomic().
- Use the dma buffer also for reads, because we found that double buffering PDC was NOT working, and we need a solution which allows bigger stream sizes.
- Usedmac_flush_range()becauseflush_dcache_page()was not OK if more than one page is transferred.
- Extend card timeout to 2s because some cards need it.
- Extend card detect time to 500ms (usefull if the user
Quoted 8 lines
is inserting the card gentle into the slot).
- Fill in themmc->max_variables to allow the IO elevator to do the job. Without these variables filled in, each IO transfer is limited to 4096 bytes, which is limiting transfer speed and - most important - is triggering ACCELLERATED WEAR-OUT of the flash sectors of the card (because the card has to do a lot of partial sector erases).
A big amount of updates, indeed !
Quoted 5 lines
We have tested this driver which a lot of SD and SDHC cards and we think the driver is ready for production use now.
For reads, we get about 90% of the expected maximum calculated speed (from the clock frequency). For writes, we get about 50%.
This is a precious feedback. Thanks.
Quoted 5 lines
As we are using a slightly older kernel, I have ported this patch to latest 2.6.33 by hand. So please take care to compile and look for compile-time errors. I've done my very best.
Signed-off-by Wolfgang Muees <[email protected]>
The problem is that we should change this big patch into a patch series for integrating one enhancement at a time...
As you say that you are working on an old kernel release, I guess that you may not have time to rework this patch and split it into a patch series?
In short, I see at least four patches:
- pointer calculation fixes
- timeouts and detect time
- use of dma buffer for read
- mmc->max_ variables update
So, tell me, and I will see how we can move forward together with those very interesting enhancements...
Best regards,
Signature · 1 line
Nicolas Ferre
PATCH 1/1 Bugfixing and improvement of the AT91 MCI driver
Nicolas,
Am Donnerstag, 25. Februar 2010 schrieb Nicolas Ferre:
Quoted 1 line
Thanks a lot for your hard work on this driver and your patch.
Thank YOU for the development of the driver. It's a lot easier if there IS a driver if you start a project.
Quoted 2 lines
The problem is that we should change this big patch into a patch series for integrating one enhancement at a time...
Oh, yes, I should have known this..
Quoted 3 lines
As you say that you are working on an old kernel release, I guess that you may not have time to rework this patch and split it into a patch series?
Hrmmmpf. I've done it now.
best regards
i. A. Wolfgang M?es
Signature · 12 lines
Auerswald Gesellschaft f?r Datensysteme mbH Hardware Development Telefon: +49 (0)5306 9219 562 Telefax: +49 (0)5306 9219 94 E-Mail: Wolfgang.Mues at Auerswald.de Web: http://www.auerswald.de -------------------------------------------------------------- Auerswald Gesellschaft f?r Datensysteme mbH Vor den Grash?fen 1, 38162 Cremlingen Registriert beim AG Braunschweig HRB 7499 Gesch?ftsf?hrer: Dipl-Ing. Gerhard Auerswald