gspca pac7302: remove LED blinking when switching stream on and off
PATCH 3/3 gspca pac7302: remove LED blinking when switching stream on and off
From: Márton Németh <[email protected]>
The init sequences for PAC7302 contained register settings affecting the LED state which can result blinking of the LED when it is set to always on or always off. The blinking happened when the stream was switched on or off.
Remove the register changes from the init sequence and handle it with the function set_streaming_led().
Signed-off-by Márton Németh <[email protected]>
---
linux/drivers/media/video/gspca/pac7302.c renamed from linux/drivers/media/video/gspca/pac7302.c.orig +3 -20
@@ -326,13 +326,6 @@#define END_OF_SEQUENCE 0/* pac 7302 */ -static const __u8 init_7302[] = { -/* index,value */ -0xff ,0x01 ,/* page 1 */ -0x78 ,0x00 ,/* deactivate */ -0xff ,0x01 , -0x78 ,0x40 ,/* led off */ -};static const __u8 start_7302[] = {/* index, len, [value]* */ 0xff ,1 ,0x00 ,/* page 0 */
@@ -368,7 +361,8 @@0xff ,1 ,0x01 ,/* page 1 */ 0x12 ,3 ,0x02 ,0x00 ,0x01 ,0x3e ,2 ,0x00 ,0x00 , -0x76 ,5 ,0x01 ,0x20 ,0x40 ,0x00 ,0xf2 , +0x76 ,2 ,0x01 ,0x20 , +0x79 ,2 ,0x00 ,0xf2 ,0x7c ,1 ,0x00 ,0x7f ,10 ,0x4b ,0x0f ,0x01 ,0x2c ,0x02 ,0x58 ,0x03 ,0x20 , 0x02, 0x00,
@@ -392,8 +386,6 @@0x2a ,5 ,0xc8 ,0x00 ,0x18 ,0x12 ,0x22 ,0x64 ,8 ,0x00 ,0x00 ,0xf0 ,0x01 ,0x14 ,0x44 ,0x44 ,0x44 ,0x6e ,1 ,0x08 , -0xff ,1 ,0x01 ,/* page 1 */ -0x78 ,1 ,0x00 ,0 ,END_OF_SEQUENCE /* end of sequence */ };
@@ -491,15 +483,6 @@ } } -static void reg_w_seq (struct gspca_dev *gspca_dev, -const __u8 *seq,int len) -{ -while (--len >=0 ) { -reg_w (gspca_dev, seq[0 ], seq[1 ]); - seq +=2 ; - } -} -/* load the beginning of a page */ static void reg_w_page (struct gspca_dev *gspca_dev,const __u8 *page,int len)
@@ -769,7 +752,7 @@/* this function is called at probe and resume time for pac7302 */ static int sd_init (struct gspca_dev *gspca_dev) { -reg_w_seq (gspca_dev, init_7302,sizeof (init_7302)/2 ); +set_streaming_led (gspca_dev,0 );return gspca_dev->usb_err; }