v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below.
Results of the daily build of v4l-dvb:
date: Sun Feb 28 19:00:21 CET 2010 path: http://www.linuxtv.org/hg/v4l-dvb changeset: 14319:37581bb7e6f1 gcc version: i686-linux-gcc (GCC) 4.4.3 host hardware: x86_64 host os: 2.6.32.5
linux-2.6.32.6-armv5: OK
linux-2.6.33-armv5: OK
linux-2.6.32.6-armv5-davinci: WARNINGS
linux-2.6.33-armv5-davinci: WARNINGS
linux-2.6.32.6-armv5-dm365: ERRORS
linux-2.6.33-armv5-dm365: ERRORS
linux-2.6.32.6-armv5-ixp: OK
linux-2.6.33-armv5-ixp: OK
linux-2.6.32.6-armv5-omap2: OK
linux-2.6.33-armv5-omap2: OK
linux-2.6.22.19-i686: OK
linux-2.6.23.17-i686: OK
linux-2.6.24.7-i686: OK
linux-2.6.25.20-i686: OK
linux-2.6.26.8-i686: OK
linux-2.6.27.44-i686: OK
linux-2.6.28.10-i686: OK
linux-2.6.29.1-i686: WARNINGS
linux-2.6.30.10-i686: WARNINGS
linux-2.6.31.12-i686: OK
linux-2.6.32.6-i686: OK
linux-2.6.33-i686: OK
linux-2.6.32.6-m32r: OK
linux-2.6.33-m32r: OK
linux-2.6.32.6-mips: OK
linux-2.6.33-mips: OK
linux-2.6.32.6-powerpc64: WARNINGS
linux-2.6.33-powerpc64: WARNINGS
linux-2.6.22.19-x86_64: OK
linux-2.6.23.17-x86_64: OK
linux-2.6.24.7-x86_64: OK
linux-2.6.25.20-x86_64: OK
linux-2.6.26.8-x86_64: OK
linux-2.6.27.44-x86_64: OK
linux-2.6.28.10-x86_64: OK
linux-2.6.29.1-x86_64: WARNINGS
linux-2.6.30.10-x86_64: WARNINGS
linux-2.6.31.12-x86_64: OK
linux-2.6.32.6-x86_64: OK
linux-2.6.33-x86_64: OK
spec: OK
sparse (linux-2.6.33): ERRORS
linux-2.6.16.62-i686: ERRORS
linux-2.6.17.14-i686: ERRORS
linux-2.6.18.8-i686: OK
linux-2.6.19.7-i686: OK
linux-2.6.20.21-i686: OK
linux-2.6.21.7-i686: OK
linux-2.6.16.62-x86_64: ERRORS
linux-2.6.17.14-x86_64: ERRORS
linux-2.6.18.8-x86_64: OK
linux-2.6.19.7-x86_64: OK
linux-2.6.20.21-x86_64: OK
linux-2.6.21.7-x86_64: OK
Detailed results are available here:
http://www.xs4all.nl/~hverkuil/logs/Sunday.log
Full logs are available here:
http://www.xs4all.nl/~hverkuil/logs/Sunday.tar.bz2
The V4L-DVB specification from this daily build is here:
az6027: variables may be used uninitialized in az6027_i2c_xfer()
Hi Adams,
Quoted 9 lines · Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below.
[...]Detailed results are available here:
Quoted 7 lines
linux-2.6.29.1-i686: WARNINGS
/home/hans/work/build/v4l-dvb-master/v4l/az6027.c: In function 'az6027_i2c_xfer':/home/hans/work/build/v4l-dvb-master/v4l/az6027.c:942: warning: 'index' may be used uninitialized in this function/home/hans/work/build/v4l-dvb-master/v4l/az6027.c:943: warning: 'value' may be used uninitialized in this function/home/hans/work/build/v4l-dvb-master/v4l/az6027.c:944: warning: 'length' may be used uninitialized in this function/home/hans/work/build/v4l-dvb-master/v4l/az6027.c:945: warning: 'req' may be used uninitialized in this function
I checked what can cause these warning messages and found that in line 990 of linux/drivers/media/dvb/dvb-usb/az6027.c the function az6027_usb_out_op() is called. Before that call it seems that the condition (msg[i].addr == 0xd0) is checked for the second time which is redundant.
Regards,
Márton Németh
PATCH 1/1 az6027: remove redundant condition check
From: Márton Németh <[email protected]>
The condition (msg[i].addr == 0xd0) is checked twice the second one is not necessary.
This will remove the following compiler warning:
az6027.c: In function 'az6027_i2c_xfer':
az6027.c:942: warning: 'index' may be used uninitialized in this function az6027.c:943: warning: 'value' may be used uninitialized in this function az6027.c:944: warning: 'length' may be used uninitialized in this function az6027.c:945: warning: 'req' may be used uninitialized in this function
---
linux/drivers/media/dvb/dvb-usb/az6027.c +8 -11
@@ -976,17 +976,14 @@ i++; }else { -if (msg[i].addr ==0xd0 ) { -/* demod 16bit addr */ - req =0xBD ; - index = (((msg[i].buf[0 ] <<8 ) &0xff00 ) | (msg[i].buf[1 ] &0x00ff )); - value = msg[i].addr + (2 <<8 ); - length = msg[i].len -2 ; - len = msg[i].len -2 ; -for (j =0 ; j < len; j++) - data[j] = msg[i].buf[j +2 ]; - - } +/* demod 16bit addr */ + req =0xBD ; + index = (((msg[i].buf[0 ] <<8 ) &0xff00 ) | (msg[i].buf[1 ] &0x00ff )); + value = msg[i].addr + (2 <<8 ); + length = msg[i].len -2 ; + len = msg[i].len -2 ; +for (j =0 ; j < len; j++) + data[j] = msg[i].buf[j +2 ];az6027_usb_out_op (d, req, value, index, data, length); } }