Skip to contentSkip to conversation

Pull request u-boot-marvell.git

U-Boot New Prafulla Wadaskar 3 participants 9 messages Feb 26, 2010 – Mar 5, 2010

lore
Share & tools
lore
#0 lore raw

Hi Tom

Pls pull the following

The following changes since commit 1b063b552e815f90a6a880e78fc40cc309dd52ad:
Anders Darander (1):
Add bootcount to AT91

are available in the git repository at:

http://git.denx.de/u-boot/u-boot-marvell.git master branch

Heiko Schocher (1):
arm: add support for the suen3 board from keymile

 MAINTAINERS                       |    2 +-
 MAKEALL                           |    1 +
 Makefile                          |    3 +
 board/keymile/common/common.c     |    6 +-
 board/keymile/km_arm/Makefile     |   51 ++++++
 board/keymile/km_arm/config.mk    |   28 ++++
 board/keymile/km_arm/km_arm.c     |  324 +++++++++++++++++++++++++++++++++++++
 board/keymile/km_arm/kwbimage.cfg |  176 ++++++++++++++++++++
 include/configs/km_arm.h          |  191 ++++++++++++++++++++++
 include/configs/suen3.h           |  103 ++++++++++++
 10 files changed, 882 insertions(+), 3 deletions(-)
 create mode 100644 board/keymile/km_arm/Makefile
 create mode 100644 board/keymile/km_arm/config.mk
 create mode 100644 board/keymile/km_arm/km_arm.c
 create mode 100644 board/keymile/km_arm/kwbimage.cfg
 create mode 100644 include/configs/km_arm.h
 create mode 100644 include/configs/suen3.h

Regards..
Prafulla . .

#1 lore raw
Quoted 8 lines · Prafulla Wadaskar

Hi Tom

Pls pull the following

The following changes since commit 1b063b552e815f90a6a880e78fc40cc309dd52ad:
Anders Darander (1):
Add bootcount to AT91

Quoted 6 lines

are available in the git repository at:

http://git.denx.de/u-boot/u-boot-marvell.git master branch

Heiko Schocher (1):
arm: add support for the suen3 board from keymile

For the regression test, I get a failure to build error. This must be fixed.
Other warnings should also be fixed.

Tom

jffs2_1pass.c: In function 'get_fl_mem':
jffs2_1pass.c:399: warning: unused variable 'id'
jffs2_1pass.c: In function 'get_node_mem':
jffs2_1pass.c:423: warning: unused variable 'id'
kirkwood_egiga.c: In function 'kwgbe_init':
kirkwood_egiga.c:448: warning: dereferencing type-punned pointer will break strict-aliasing rules
kirkwood_egiga.c: In function 'kwgbe_recv':
kirkwood_egiga.c:609: warning: dereferencing type-punned pointer will break strict-aliasing rules
Assembler messages:
Fatal error: can't create .../build/board/keymile/km_arm/../common/common.o: No such file or directory
make[1]: *** [.../build/board/keymile/km_arm/../common/common.o] Error 2
make: *** [.../build/board/keymile/km_arm/libkm_arm.a] Error 2

The '...' is my reduction of path
T

#2 lore raw

Hello Tom,

Quoted 12 lines · Tom
Quoted 11 lines · Prafulla Wadaskar

Hi Tom

Pls pull the following

The following changes since commit
1b063b552e815f90a6a880e78fc40cc309dd52ad:
Anders Darander (1):
Add bootcount to AT91

are available in the git repository at:

Quoted 7 lines
Quoted 4 lines

http://git.denx.de/u-boot/u-boot-marvell.git master branch

Heiko Schocher (1):
arm: add support for the suen3 board from keymile

For the regression test, I get a failure to build error. This must be fixed.

Yes, you are right, good catch. The following patch will help:

board/keymile/km_arm/Makefile +3 -0
index fffc6a3..c5b0be1 100644
@@ -23,6 +23,9 @@
 #
 
 include $(TOPDIR)/config.mk
+ifneq ($(OBJTREE),$(SRCTREE))
+$(shell mkdir -p $(obj)../common)
+endif
 
 LIB    = $(obj)lib$(BOARD).a
 

Should I make a new version of the "arm: add support for the suen3 board from keymile" patch, or a patch based on the actual

git://git.denx.de/u-boot-marvell.git ?

bye
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#3 lore raw
Quoted 40 lines · Heiko Schocher

Hello Tom,

Quoted 10 lines · Tom
Quoted 9 lines · Prafulla Wadaskar

Hi Tom

Pls pull the following

The following changes since commit
1b063b552e815f90a6a880e78fc40cc309dd52ad:
Anders Darander (1):
Add bootcount to AT91

Quoted 8 lines
Quoted 6 lines

are available in the git repository at:

http://git.denx.de/u-boot/u-boot-marvell.git master branch

Heiko Schocher (1):
arm: add support for the suen3 board from keymile

For the regression test, I get a failure to build error. This must be fixed.

Yes, you are right, good catch. The following patch will help:

board/keymile/km_arm/Makefile +3 -0
index fffc6a3..c5b0be1 100644
@@ -23,6 +23,9 @@
 #
 
 include $(TOPDIR)/config.mk
+ifneq ($(OBJTREE),$(SRCTREE))
+$(shell mkdir -p $(obj)../common)
+endif
 
 LIB    = $(obj)lib$(BOARD).a
 
Quoted 5 lines

Should I make a new version of the "arm: add support for the suen3 board from keymile" patch, or a patch based on the actual

git://git.denx.de/u-boot-marvell.git ?

Please just the much smaller 'Compiler fix.. ' patch. Thanks,
Tom

Quoted 2 lines

bye
Heiko

#4 lore raw

PATCH 1/1 arm, suen3: fix compile error, if doing not a local build

---

Patch against current git://git.denx.de/u-boot-marvell.git

 board/keymile/km_arm/Makefile |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
board/keymile/km_arm/Makefile +3 -0
index fffc6a3..c5b0be1 100644
@@ -23,6 +23,9 @@
 #
 
 include $(TOPDIR)/config.mk
+ifneq ($(OBJTREE),$(SRCTREE))
+$(shell mkdir -p $(obj)../common)
+endif
 
 LIB	= $(obj)lib$(BOARD).a
 
Signature · 4 lines
1.6.2.5
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#5 lore raw

PATCH 1/1 arm, suen3: fix compile error, if doing not a local build

Quoted 8 lines · Heiko Schocher

---

Patch against current git://git.denx.de/u-boot-marvell.git

 board/keymile/km_arm/Makefile |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

This fixes the build errors.
There are still some compile warnings wrt dereferencing pointers. Do you have a fix for these?

Prafulla,
Are you ok with me pushing this directly to ARM ?

Tom

Quoted 14 lines
board/keymile/km_arm/Makefile +3 -0
index fffc6a3..c5b0be1 100644
@@ -23,6 +23,9 @@
 #
 
 include $(TOPDIR)/config.mk
+ifneq ($(OBJTREE),$(SRCTREE))
+$(shell mkdir -p $(obj)../common)
+endif
 
 LIB	= $(obj)lib$(BOARD).a
 
#6 lore raw

PATCH 1/1 arm, suen3: fix compile error, if doing not a local build

Quoted 14 lines

-----Original Message-----
From: Tom [mailto:Tom.Rix at windriver.com]
Sent: Wednesday, March 03, 2010 2:55 AM
To: hs at denx.de; Prafulla Wadaskar
Cc: u-boot at lists.denx.de
Subject: Re: [PATCH] arm, suen3: fix compile error, if doing not a local build

Quoted 3 lines · Heiko Schocher

---

Quoted 8 lines
Quoted 5 lines

Patch against current git://git.denx.de/u-boot-marvell.git

 board/keymile/km_arm/Makefile |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

This fixes the build errors.
There are still some compile warnings wrt dereferencing pointers. Do you have a fix for these?

For the warnings in kirkwood_egiga.c, I am posting a patch soon

Quoted 3 lines

Prafulla,
Are you ok with me pushing this directly to ARM ?

Sure, no issues

Regards..
Prafulla . .

#7 lore raw

PATCH 1/1 arm, suen3: fix compile error, if doing not a local build

Quoted 27 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de
[mailto:u-boot-bounces at lists.denx.de] On Behalf Of Prafulla Wadaskar
Sent: Wednesday, March 03, 2010 10:07 AM
To: Tom; hs at denx.de
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] arm, suen3: fix compile error, if doing not a local build

Quoted 14 lines

-----Original Message-----
From: Tom [mailto:Tom.Rix at windriver.com]
Sent: Wednesday, March 03, 2010 2:55 AM
To: hs at denx.de; Prafulla Wadaskar
Cc: u-boot at lists.denx.de
Subject: Re: [PATCH] arm, suen3: fix compile error, if doing not a local build

Quoted 5 lines · Heiko Schocher

---

Patch against current git://git.denx.de/u-boot-marvell.git

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
 board/keymile/km_arm/Makefile |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

This fixes the build errors.
There are still some compile warnings wrt dereferencing pointers. Do you have a fix for these?

For the warnings in kirkwood_egiga.c, I am posting a patch soon

Hi Ben
I have posted patch fix patch for this, that should go to net repository.
http://lists.denx.de/pipermail/u-boot/2010-March/068201.html

Hi Tom
Also I have posted a patch for build warning fix for suen3 board.
http://lists.denx.de/pipermail/u-boot/2010-March/068202.html
You may push this patch directly to ARM, or suggest if I should provide you pull request.

Regards..
Prafulla . .

#8 lore raw

PATCH 1/1 arm, suen3: fix compile error, if doing not a local build

In reply to Prafulla Wadaskar
Quoted 16 lines · Prafulla Wadaskar
Quoted 16 lines

-----Original Message-----
From: Tom [mailto:Tom.Rix at windriver.com]
Sent: Wednesday, March 03, 2010 2:55 AM
To: hs at denx.de; Prafulla Wadaskar
Cc: u-boot at lists.denx.de
Subject: Re: [PATCH] arm, suen3: fix compile error, if doing not a local build

Quoted 5 lines · Heiko Schocher

---

Patch against current git://git.denx.de/u-boot-marvell.git

Quoted 11 lines
Quoted 6 lines
Quoted 3 lines
 board/keymile/km_arm/Makefile |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

This fixes the build errors.
There are still some compile warnings wrt dereferencing pointers. Do you have a fix for these?

For the warnings in kirkwood_egiga.c, I am posting a patch soon

Quoted 2 lines

Prafulla,
Are you ok with me pushing this directly to ARM ?

I have applied the marvell pull request and this patch to ARM. Thanks
Tom

Quoted 7 lines

Sure, no issues

Regards..
Prafulla . .