tracing: fix warning in s_next
PATCH 1/1 tracing: fix warning in s_next
This warning in s_next() can be triggered by lseek():
[<c018b3f7>] ? s_next+0x77/0x80
[<c013e3c1>] warn_slowpath_common+0x81/0xa0 [<c018b3f7>] ? s_next+0x77/0x80 [<c013e3fa>] warn_slowpath_null+0x1a/0x20 [<c018b3f7>] s_next+0x77/0x80 [<c01efa77>] traverse+0x117/0x200 [<c01eff13>] seq_lseek+0xa3/0x120 [<c01efe70>] ? seq_lseek+0x0/0x120 [<c01d7081>] vfs_llseek+0x41/0x50 [<c01d8116>] sys_llseek+0x66/0xa0 [<c0102bd0>] sysenter_do_call+0x12/0x26
It is because s_start() calls s_next() without reset leftover.
---
kernel/trace/trace.c +1 -0
@@ -1703,6 +1703,7 @@ static void *s_start(struct seq_file *m, loff_t *pos)ftrace_enable_cpu (); + iter->leftover =0 ;for (p = iter; p && l < *pos; p =s_next (m, p, &l)) ;
Quoted 13 lines · Lai Jiangshan
This warning in
s_next()can be triggered bylseek():
[<c018b3f7>] ?s_next+0x77/0x80[<c013e3c1>] warn_slowpath_common+0x81/0xa0 [<c018b3f7>] ? s_next+0x77/0x80 [<c013e3fa>] warn_slowpath_null+0x1a/0x20 [<c018b3f7>] s_next+0x77/0x80 [<c01efa77>] traverse+0x117/0x200 [<c01eff13>] seq_lseek+0xa3/0x120 [<c01efe70>] ? seq_lseek+0x0/0x120 [<c01d7081>] vfs_llseek+0x41/0x50 [<c01d8116>] sys_llseek+0x66/0xa0 [<c0102bd0>] sysenter_do_call+0x12/0x26
Quoted 1 line
It is because
s_start()callss_next()without reset leftover.
Applied, Thanks!
-- Steve
Quoted 15 lines
Signed-off-by Lai Jiangshan <[email protected]>---
kernel/trace/trace.c +1
-0@@ -1703,6 +1703,7 @@ static void *s_start(struct seq_file *m, loff_t *pos)ftrace_enable_cpu (); + iter->leftover =0 ;for (p = iter; p && l < *pos; p =s_next (m, p, &l)) ;
[tip:tracing/urgent] tracing: Fix warning in s_next of trace file ops
In reply to Lai JiangshanCommit-ID: ac91d85456372a90af5b85eb6620fd2efb1e431b Gitweb: http://git.kernel.org/tip/ac91d85456372a90af5b85eb6620fd2efb1e431b Author: Lai Jiangshan <[email protected]> AuthorDate: Tue, 2 Mar 2010 17:54:50 +0800 Committer: Steven Rostedt <[email protected]> CommitDate: Tue, 2 Mar 2010 21:11:47 -0500
tracing: Fix warning in s_next of trace file ops
This warning in s_next() can be triggered by lseek():
[<c018b3f7>] ? s_next+0x77/0x80
[<c013e3c1>] warn_slowpath_common+0x81/0xa0 [<c018b3f7>] ? s_next+0x77/0x80 [<c013e3fa>] warn_slowpath_null+0x1a/0x20 [<c018b3f7>] s_next+0x77/0x80 [<c01efa77>] traverse+0x117/0x200 [<c01eff13>] seq_lseek+0xa3/0x120 [<c01efe70>] ? seq_lseek+0x0/0x120 [<c01d7081>] vfs_llseek+0x41/0x50 [<c01d8116>] sys_llseek+0x66/0xa0 [<c0102bd0>] sysenter_do_call+0x12/0x26
The iterator "leftover" variable is zeroed in the opening of the trace file. But lseek can call s_start() which will call s_next() without reseting the "leftover" variable back to zero, which might trigger the WARN_ON_ONCE(iter->leftover) that is in s_next().
LKML-Reference: <[email protected]>
--- kernel/trace/trace.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
kernel/trace/trace.c +1 -0
@@ -1703,6 +1703,7 @@ static void *s_start(struct seq_file *m, loff_t *pos)ftrace_enable_cpu (); + iter->leftover =0 ;for (p = iter; p && l < *pos; p =s_next (m, p, &l)) ;