Skip to contentSkip to conversation

arm: kirkwood: suen3: fixed build warning

PATCH New Prafulla Wadaskar 2 participants 6 messages Mar 3, 2010 – Mar 6, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: kirkwood: suen3: fixed build warning

This patch fixes following build warning

Invalid Kwbimage command Type - valid names are: BOOT_FROM, NAND_ECC_MODE, NAND_PAGE_SIZE, SATA_PIO_MODE, DDR_INIT_DELAY, DATA, , spi, nand, sata, pex, uart

---
 board/keymile/km_arm/kwbimage.cfg |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
board/keymile/km_arm/kwbimage.cfg +1 -2
index d6edd27..26d6aa0 100644
@@ -64,7 +64,6 @@ DATA 0xFFD01400 0x43000400	# SDRAM Configuration Register
 # bit31-30: 01
 
 DATA 0xFFD01404 0x36343000	# DDR Controller Control Low
-		0x38543000
 # bit 3-0:  0 reserved
 # bit 4:    0=addr/cmd in smame cycle
 # bit 5:    0=clk is driven during self refresh, we don't care for APX
@@ -170,7 +169,7 @@ DATA 0xFFD0149C 0x0000E90F	# CPU ODT Control
 # bit11-10:2, DQ_ODTSel. ODT select turned on, 75 ohm
 
 DATA 0xFFD01480 0x00000001	# DDR Initialization Control
-#bit0=1, enable DDR init upon this register write
+# bit0=1, enable DDR init upon this register write
 
 # End of Header extension
 DATA 0x0 0x0
Signature · 1 line
1.5.3.3
#1 lore raw

PATCH 1/1 arm: kirkwood: suen3: fixed build warning

Quoted 22 lines · Prafulla Wadaskar

This patch fixes following build warning

Invalid Kwbimage command Type - valid names are: BOOT_FROM, NAND_ECC_MODE, NAND_PAGE_SIZE, SATA_PIO_MODE, DDR_INIT_DELAY, DATA, , spi, nand, sata, pex, uart

---
 board/keymile/km_arm/kwbimage.cfg |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
board/keymile/km_arm/kwbimage.cfg +0 -1
index d6edd27..26d6aa0 100644
@@ -64,7 +64,6 @@ DATA 0xFFD01400 0x43000400	# SDRAM Configuration Register
 # bit31-30: 01
 
 DATA 0xFFD01404 0x36343000	# DDR Controller Control Low
-		0x38543000
 # bit 3-0:  0 reserved
 # bit 4:    0=addr/cmd in smame cycle
 # bit 5:    0=clk is driven during self refresh, we don't care for APX

board/keymile/km_arm/kwbimage.cfg DATA 0xFFD0149C 0x0000E90F # CPU ODT Control · line 175

Quoted 8 lines
board/keymile/km_arm/kwbimage.cfg +1 -1
@@ -170,7 +169,7 @@ DATA 0xFFD0149C 0x0000E90F	# CPU ODT Control
 # bit11-10:2, DQ_ODTSel. ODT select turned on, 75 ohm
 
 DATA 0xFFD01480 0x00000001	# DDR Initialization Control
-#bit0=1, enable DDR init upon this register write
+# bit0=1, enable DDR init upon this register write
 
 # End of Header extension
 DATA 0x0 0x0

This patch did not fix any of the warnings I saw.
Please recheck.
Tom

#2 lore raw

PATCH 1/1 arm: kirkwood: suen3: fixed build warning

Quoted 41 lines

-----Original Message-----
From: Tom [mailto:Tom.Rix at windriver.com]
Sent: Thursday, March 04, 2010 7:25 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
Subject: Re: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning

Quoted 3 lines · Prafulla Wadaskar

This patch fixes following build warning

Invalid Kwbimage command Type - valid names are: BOOT_FROM,

NAND_ECC_MODE, NAND_PAGE_SIZE, SATA_PIO_MODE, DDR_INIT_DELAY, DATA, , spi, nand, sata, pex, uart

Review

Quoted 7 lines
---
 board/keymile/km_arm/kwbimage.cfg |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/board/keymile/km_arm/kwbimage.cfg

board/keymile/km_arm/kwbimage.cfg DATA 0xFFD01400 0x43000400 # SDRAM

Quoted 4 lines

index d6edd27..26d6aa0 100644

board/keymile/km_arm/kwbimage.cfg +0 -0
@@ -64,7 +64,6 @@ DATA 0xFFD01400 0x43000400	# SDRAM 

Configuration Register

board/keymile/km_arm/kwbimage.cfg DATA 0xFFD01400 0x43000400 # SDRAM Configuration Register

Quoted 7 lines
board/keymile/km_arm/kwbimage.cfg +0 -1
 # bit31-30: 01
 
 DATA 0xFFD01404 0x36343000	# DDR Controller Control Low
-		0x38543000
 # bit 3-0:  0 reserved
 # bit 4:    0=addr/cmd in smame cycle
 # bit 5:    0=clk is driven during self refresh, we don't 

care for APX

board/keymile/km_arm/kwbimage.cfg DATA 0xFFD0149C 0x0000E90F # CPU

Quoted 1 line
board/keymile/km_arm/kwbimage.cfg +0 -0
@@ -170,7 +169,7 @@ DATA 0xFFD0149C 0x0000E90F	# CPU 

ODT Control

Quoted 2 lines
board/keymile/km_arm/kwbimage.cfg +0 -0
 # bit11-10:2, DQ_ODTSel. ODT select turned on, 75 ohm
 
Quoted 8 lines

board/keymile/km_arm/kwbimage.cfg DATA 0xFFD0149C 0x0000E90F # CPU ODT Control · line 175

Quoted 6 lines
board/keymile/km_arm/kwbimage.cfg +1 -1
 DATA 0xFFD01480 0x00000001	# DDR Initialization Control
-#bit0=1, enable DDR init upon this register write
+# bit0=1, enable DDR init upon this register write
 
 # End of Header extension
 DATA 0x0 0x0

This patch did not fix any of the warnings I saw.
Please recheck.

Hi Tom
I am sorry to say,
it is not build warning but it is runtime stderr generated during kwbimage.cfg parsing.
This patch removes above mentioned "Invalid Kwbimage command Type" error reported by mkimage tool during u-boot.kwb target creation for this board.

Regards..
Prafulla . .

Quoted 3 lines

Tom

#3 lore raw

PATCH 1/1 arm: kirkwood: suen3: fixed build warning

Quoted 49 lines · Prafulla Wadaskar
Quoted 40 lines

-----Original Message-----
From: Tom [mailto:Tom.Rix at windriver.com]
Sent: Thursday, March 04, 2010 7:25 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
Subject: Re: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning

Quoted 3 lines · Prafulla Wadaskar

This patch fixes following build warning

Invalid Kwbimage command Type - valid names are: BOOT_FROM,

NAND_ECC_MODE, NAND_PAGE_SIZE, SATA_PIO_MODE, DDR_INIT_DELAY, DATA, , spi, nand, sata, pex, uart

Review

Quoted 6 lines
---
 board/keymile/km_arm/kwbimage.cfg |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/board/keymile/km_arm/kwbimage.cfg

board/keymile/km_arm/kwbimage.cfg DATA 0xFFD01400 0x43000400 # SDRAM

Quoted 4 lines

index d6edd27..26d6aa0 100644

board/keymile/km_arm/kwbimage.cfg +0 -0
@@ -64,7 +64,6 @@ DATA 0xFFD01400 0x43000400	# SDRAM 

Configuration Register

board/keymile/km_arm/kwbimage.cfg DATA 0xFFD01400 0x43000400 # SDRAM Configuration Register

Quoted 7 lines
board/keymile/km_arm/kwbimage.cfg +0 -1
 # bit31-30: 01
 
 DATA 0xFFD01404 0x36343000	# DDR Controller Control Low
-		0x38543000
 # bit 3-0:  0 reserved
 # bit 4:    0=addr/cmd in smame cycle
 # bit 5:    0=clk is driven during self refresh, we don't 

care for APX

board/keymile/km_arm/kwbimage.cfg DATA 0xFFD0149C 0x0000E90F # CPU

Quoted 1 line
board/keymile/km_arm/kwbimage.cfg +0 -0
@@ -170,7 +169,7 @@ DATA 0xFFD0149C 0x0000E90F	# CPU 

ODT Control

Quoted 2 lines
board/keymile/km_arm/kwbimage.cfg +0 -0
 # bit11-10:2, DQ_ODTSel. ODT select turned on, 75 ohm
 
Quoted 8 lines

board/keymile/km_arm/kwbimage.cfg DATA 0xFFD0149C 0x0000E90F # CPU ODT Control · line 175

Quoted 6 lines
board/keymile/km_arm/kwbimage.cfg +1 -1
 DATA 0xFFD01480 0x00000001	# DDR Initialization Control
-#bit0=1, enable DDR init upon this register write
+# bit0=1, enable DDR init upon this register write
 
 # End of Header extension
 DATA 0x0 0x0

This patch did not fix any of the warnings I saw.
Please recheck.

Quoted 5 lines

Hi Tom
I am sorry to say,
it is not build warning but it is runtime stderr generated during kwbimage.cfg parsing.
This patch removes above mentioned "Invalid Kwbimage command Type" error reported by mkimage tool during u-boot.kwb target creation for this board.

Ah!
Ok that helps.
I did not hold up your pull request for this.
Would you like this to go into ARM now?

Tom

Quoted 5 lines

Regards..
Prafulla . .

Quoted 2 lines

Tom

#4 lore raw

PATCH 1/1 arm: kirkwood: suen3: fixed build warning

Quoted 65 lines

-----Original Message-----
From: Tom [mailto:Tom.Rix at windriver.com]
Sent: Friday, March 05, 2010 7:49 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
Subject: Re: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning

Quoted 44 lines · Prafulla Wadaskar
Quoted 44 lines

-----Original Message-----
From: Tom [mailto:Tom.Rix at windriver.com]
Sent: Thursday, March 04, 2010 7:25 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
Subject: Re: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning

Quoted 3 lines · Prafulla Wadaskar

This patch fixes following build warning

Invalid Kwbimage command Type - valid names are: BOOT_FROM,

NAND_ECC_MODE, NAND_PAGE_SIZE, SATA_PIO_MODE, DDR_INIT_DELAY, DATA, , spi, nand, sata, pex, uart

Review

Quoted 6 lines
---
 board/keymile/km_arm/kwbimage.cfg |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/board/keymile/km_arm/kwbimage.cfg

board/keymile/km_arm/kwbimage.cfg DATA 0xFFD01400 0x43000400 # SDRAM

Quoted 4 lines

index d6edd27..26d6aa0 100644

board/keymile/km_arm/kwbimage.cfg +0 -0
@@ -64,7 +64,6 @@ DATA 0xFFD01400 0x43000400	# SDRAM 

Configuration Register

board/keymile/km_arm/kwbimage.cfg DATA 0xFFD01400 0x43000400 # SDRAM Configuration Register

Quoted 7 lines
board/keymile/km_arm/kwbimage.cfg +0 -1
 # bit31-30: 01
 
 DATA 0xFFD01404 0x36343000	# DDR Controller Control Low
-		0x38543000
 # bit 3-0:  0 reserved
 # bit 4:    0=addr/cmd in smame cycle
 # bit 5:    0=clk is driven during self refresh, we don't 

care for APX

board/keymile/km_arm/kwbimage.cfg DATA 0xFFD0149C 0x0000E90F # CPU

Quoted 1 line
board/keymile/km_arm/kwbimage.cfg +0 -0
@@ -170,7 +169,7 @@ DATA 0xFFD0149C 0x0000E90F	# CPU 

ODT Control

Quoted 6 lines
board/keymile/km_arm/kwbimage.cfg +1 -1
 # bit11-10:2, DQ_ODTSel. ODT select turned on, 75 ohm
 
 DATA 0xFFD01480 0x00000001	# DDR Initialization Control
-#bit0=1, enable DDR init upon this register write
+# bit0=1, enable DDR init upon this register write
 
Quoted 8 lines
Quoted 4 lines

board/keymile/km_arm/kwbimage.cfg DATA 0xFFD0149C 0x0000E90F # CPU ODT Control · line 175

Quoted 2 lines
board/keymile/km_arm/kwbimage.cfg +0 -0
 # End of Header extension
 DATA 0x0 0x0

This patch did not fix any of the warnings I saw.
Please recheck.

Hi Tom
I am sorry to say,
it is not build warning but it is runtime stderr generated

during kwbimage.cfg parsing.

Quoted 1 line

This patch removes above mentioned "Invalid Kwbimage

Quoted 8 lines

command Type" error reported by mkimage tool during u-boot.kwb target creation for this board.

Quoted 1 line

Ah!
Ok that helps.
I did not hold up your pull request for this.
Would you like this to go into ARM now?

Yes. Its better, if you can pull this too ;-) otherwise Pls flag me if I need to send pull request

Regards..
Prafulla . .

Quoted 10 lines

Tom

Quoted 5 lines

Regards..
Prafulla . .

Quoted 2 lines

Tom

#5 lore raw

PATCH 1/1 arm: kirkwood: suen3: fixed build warning

Quoted 64 lines · Prafulla Wadaskar
Quoted 64 lines

-----Original Message-----
From: Tom [mailto:Tom.Rix at windriver.com]
Sent: Friday, March 05, 2010 7:49 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
Subject: Re: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning

Quoted 44 lines · Prafulla Wadaskar
Quoted 44 lines

-----Original Message-----
From: Tom [mailto:Tom.Rix at windriver.com]
Sent: Thursday, March 04, 2010 7:25 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
Subject: Re: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning

Quoted 3 lines · Prafulla Wadaskar

This patch fixes following build warning

Invalid Kwbimage command Type - valid names are: BOOT_FROM,

NAND_ECC_MODE, NAND_PAGE_SIZE, SATA_PIO_MODE, DDR_INIT_DELAY, DATA, , spi, nand, sata, pex, uart

Review

Quoted 6 lines
---
 board/keymile/km_arm/kwbimage.cfg |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/board/keymile/km_arm/kwbimage.cfg

board/keymile/km_arm/kwbimage.cfg DATA 0xFFD01400 0x43000400 # SDRAM

Quoted 4 lines

index d6edd27..26d6aa0 100644

board/keymile/km_arm/kwbimage.cfg +0 -0
@@ -64,7 +64,6 @@ DATA 0xFFD01400 0x43000400	# SDRAM 

Configuration Register

board/keymile/km_arm/kwbimage.cfg DATA 0xFFD01400 0x43000400 # SDRAM Configuration Register

Quoted 7 lines
board/keymile/km_arm/kwbimage.cfg +0 -1
 # bit31-30: 01
 
 DATA 0xFFD01404 0x36343000	# DDR Controller Control Low
-		0x38543000
 # bit 3-0:  0 reserved
 # bit 4:    0=addr/cmd in smame cycle
 # bit 5:    0=clk is driven during self refresh, we don't 

care for APX

board/keymile/km_arm/kwbimage.cfg DATA 0xFFD0149C 0x0000E90F # CPU

Quoted 1 line
board/keymile/km_arm/kwbimage.cfg +0 -0
@@ -170,7 +169,7 @@ DATA 0xFFD0149C 0x0000E90F	# CPU 

ODT Control

Quoted 6 lines
board/keymile/km_arm/kwbimage.cfg +1 -1
 # bit11-10:2, DQ_ODTSel. ODT select turned on, 75 ohm
 
 DATA 0xFFD01480 0x00000001	# DDR Initialization Control
-#bit0=1, enable DDR init upon this register write
+# bit0=1, enable DDR init upon this register write
 
Quoted 7 lines
Quoted 4 lines

board/keymile/km_arm/kwbimage.cfg DATA 0xFFD0149C 0x0000E90F # CPU ODT Control · line 175

Quoted 2 lines
board/keymile/km_arm/kwbimage.cfg +0 -0
 # End of Header extension
 DATA 0x0 0x0

This patch did not fix any of the warnings I saw.
Please recheck.

Hi Tom
I am sorry to say,
it is not build warning but it is runtime stderr generated

during kwbimage.cfg parsing.

Quoted 1 line

This patch removes above mentioned "Invalid Kwbimage

Quoted 9 lines
Quoted 6 lines

command Type" error reported by mkimage tool during u-boot.kwb target creation for this board. Ah!
Ok that helps.
I did not hold up your pull request for this. Would you like this to go into ARM now?

Yes. Its better, if you can pull this too ;-) otherwise Pls flag me if I need to send pull request

I have applied it to ARM
Thanks
Tom

Quoted 10 lines

Regards..
Prafulla . .

Quoted 7 lines

Tom

Quoted 5 lines

Regards..
Prafulla . .

Quoted 2 lines

Tom