ipg: Remove device claimed by dl2k from pci id table

Hi all -

This is a re-send of a patch I sent out nearly a month ago but didn't get a response[2]. Re-sent without the GPG signing bit.

I've seen this report a bunch of times but google didn't point to any resolution. I'm not really involved with network driver development, so I'm hoping that someone who knows the history here can speak up.

I have a report[1] where the D-Link DGE-550T is being associated with the ipg driver. It works for a very short amount of time and then fails. Unloading the driver and loading dl2k instead results in a working system. The DGE-550T is a DL2000 based card, but the ipg (IP1000) driver is claiming it and has been since the driver was added to the kernel in 2.6.24. dl2k has been claiming this ID since the 2.4 days.

Which driver is correct? Can we remove the PCI IDs associated with the wrong driver? Users keep working around this with module blacklisting but they shouldn't have to.

Thanks.

-Jeff

[1] https://bugzilla.novell.com/show_bug.cgi?id=579219
[2] http://marc.info/?l=linux-netdev&m=126592001219784&w=2

---

ipg: Remove device claimed by dl2k from pci id table

This patch removes D-Link DGE-550T PCI ID (1186:4000) from the ipg driver. The ipg driver is for IP2000-based cards and the DGE-550T is a DL2000-based card. The driver loads and works for a few moments, but once a real workload is applied it stops operating. The ipg driver claimed this ID since it was introduced in 2.6.24 and it's forced many users to blacklist it.

The correct driver for this hardware is the dl2k driver, which has been claiming this PCI ID since the 2.4 days.

---
 drivers/net/ipg.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

@@ -88,7 +88,6 @@ static const char *ipg_brand_name[] = {
 	"Sundance Technology ST2021 based NIC",
 	"Tamarack Microelectronics TC9020/9021 based NIC",
 	"Tamarack Microelectronics TC9020/9021 based NIC",
-	"D-Link NIC",
 	"D-Link NIC IP1000A"
 };
 @@ -97,8 +96,7 @@ static struct pci_device_id ipg_pci_tbl[

{ PCI_VDEVICE(SUNDANCE, 0x2021), 1 },
{ PCI_VDEVICE(SUNDANCE, 0x1021), 2 },
{ PCI_VDEVICE(DLINK, 0x9021), 3 },
- { PCI_VDEVICE(DLINK, 0x4000), 4 },
- { PCI_VDEVICE(DLINK, 0x4020), 5 },
+ { PCI_VDEVICE(DLINK, 0x4020), 4 },
{ 0, }
};

Jeff Mahoney
SUSE Labs

From: Jeff Mahoney <[email protected]>
Date: Mon, 08 Mar 2010 15:53:10 -0500

Please stop re-submitting this, it's already in the tree:

commit 25cca5352712561fba97bd37c495593d641c1d39

Author: Jeff Mahoney <[email protected]>
Date:   Thu Feb 11 10:26:38 2010 +0000

ipg: Remove device claimed by dl2k from pci id table

This patch removes D-Link DGE-550T PCI ID (1186:4000) from the ipg driver. The ipg driver is for IP2000-based cards and the DGE-550T is a DL2000-based card. The driver loads and works for a few moments, but once a real workload is applied it stops operating. The ipg driver claimed this ID since it was introduced in 2.6.24 and it's forced many users to blacklist it.

The correct driver for this hardware is the dl2k driver, which has been claiming this PCI ID since the 2.4 days.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Heh ok. You just asked me to re-send it since it was corrupted. I never got a response when I posted it the first time. Sorry for the noise.

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.13 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAkuVZRAACgkQLPWxlyuTD7LlYQCdHUd1KJTaHAmYc+MC822H/3Or qqEAn31TdDxLMiO4sUUgWtoTGZKCfh1j
=SJDe
-----END PGP SIGNATURE-----