Skip to contentSkip to conversation

take srcu lock before call to complete_pio()

PATCH Applied Gleb Natapov 2 participants 2 messages Mar 9, 2010

Subsystems (3)
x86 KVM KVM x86
lore
Share & tools
lore

Gleb Natapov

author
#0 lore raw

PATCH 1/1 take srcu lock before call to complete_pio()

complete_pio() may use slot table which is protected by srcu.

Signed-off-by Gleb Natapov <[email protected]>
arch/x86/kvm/x86.c +2 -0
index 703f637..3753c11 100644
@@ -4519,7 +4519,9 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run)
 		kvm_set_cr8(vcpu, kvm_run->cr8);
 
 	if (vcpu->arch.pio.cur_count) {
+		vcpu->srcu_idx = srcu_read_lock(&vcpu->kvm->srcu);
 		r = complete_pio(vcpu);
+		srcu_read_unlock(&vcpu->kvm->srcu, vcpu->srcu_idx);
 		if (r)
 			goto out;
 	}

--
Gleb.

Applied
#1 lore raw
Quoted 2 lines · Gleb Natapov

complete_pio() may use slot table which is protected by srcu.

Applied, thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function