Skip to contentSkip to conversation

proc01: read /proc/acpi/event failed if acpi daemon stopped

LTP Shi Weihua 2 participants 7 messages Mar 13, 2010 – Mar 23, 2010

lore
Share & tools
lore

Shi Weihua

author
#0 lore raw

An error message occured when i tested proc01.
---------
proc01 1 TFAIL : read failed: /proc/acpi/event: errno=EAGAIN(11): Resource temporarily unavailable
---------

If "service acpid start", this message will be turned to:
---------
proc01 0 TINFO : /proc/acpi/event: known issue: errno=EBUSY(16): Device or resource busy
---------

I think we should to add a check of acpi daemon's status in testcases/kernel/fs/proc/proc01.c.

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw
Quoted 11 lines · Shi Weihua

An error message occured when i tested proc01.
---------
proc01      1  TFAIL  :  read failed: /proc/acpi/event: errno=EAGAIN(11): Resource temporarily unavailable
---------

If "service acpid start", this message will be turned to:
---------
proc01      0  TINFO  :  /proc/acpi/event: known issue: errno=EBUSY(16): Device or resource busy
---------

I think we should to add a check of acpi daemon's status in testcases/kernel/fs/proc/proc01.c.

No, that's making things too complicated and won't scale as every
distro has developed a different means for specifying the status for a service. Why not just add EAGAIN for that /proc node? Thanks,
-Garrett

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#2 lore raw
Quoted 11 lines · Garrett Cooper
Quoted 10 lines · Shi Weihua

An error message occured when i tested proc01.
---------
proc01      1  TFAIL  :  read failed: /proc/acpi/event: errno=EAGAIN(11): Resource temporarily unavailable
---------

If "service acpid start", this message will be turned to:
---------
proc01      0  TINFO  :  /proc/acpi/event: known issue: errno=EBUSY(16): Device or resource busy
---------

Quoted 5 lines
Quoted 1 line

I think we should to add a check of acpi daemon's status in testcases/kernel/fs/proc/proc01.c.

   No, that's making things too complicated and won't scale as every distro has developed a different means for specifying the status for a service. Why not just add EAGAIN for that /proc node?

And FWIW the error condition is correct in my opinion if kernel
acpi hasn't been enabled, which was the case here. Thanks,
-Garrett

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

author
#3 lore raw

Hi Garrett

Quoted 12 lines · Garrett Cooper
Quoted 11 lines · Garrett Cooper
Quoted 10 lines · Shi Weihua

An error message occured when i tested proc01.
---------
proc01 1 TFAIL : read failed: /proc/acpi/event: errno=EAGAIN(11): Resource temporarily unavailable
---------

If "service acpid start", this message will be turned to:
---------
proc01 0 TINFO : /proc/acpi/event: known issue: errno=EBUSY(16): Device or resource busy
---------

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

I think we should to add a check of acpi daemon's status in testcases/kernel/fs/proc/proc01.c.

No, that's making things too complicated and won't scale as every
distro has developed a different means for specifying the status for a service. Why not just add EAGAIN for that /proc node?

And FWIW the error condition is correct in my opinion if kernel
acpi hasn't been enabled, which was the case here.

I think we should to give a warning message to LTP users. How do you think the following patch?

testcases/kernel/fs/proc/proc01.c +1 -0
index 2d4a5fd..62d44b1 100644
@@ -101,6 +101,7 @@ const Mapping known_issues[] = {
     {"read", "/proc/fs/nfsd/filehandle", EINVAL},
     {"read", "/proc/fs/nfsd/.getfs", EINVAL},
     {"read", "/proc/fs/nfsd/.getfd", EINVAL},
+    {"read", "/proc/acpi/event", EAGAIN}, //EAGAIN will be returned if acpi daemon disabled
     {"", "", 0}
 };
Quoted 4 lines

Thanks,
-Garrett

Signature · 12 lines
Shi Weihua

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
#4 lore raw
Quoted 32 lines · Shi Weihua

Hi Garrett

Quoted 12 lines · Garrett Cooper
Quoted 11 lines · Garrett Cooper
Quoted 10 lines · Shi Weihua

An error message occured when i tested proc01.
---------
proc01      1  TFAIL  :  read failed: /proc/acpi/event: errno=EAGAIN(11): Resource temporarily unavailable
---------

If "service acpid start", this message will be turned to:
---------
proc01      0  TINFO  :  /proc/acpi/event: known issue: errno=EBUSY(16): Device or resource busy
---------

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

I think we should to add a check of acpi daemon's status in testcases/kernel/fs/proc/proc01.c.

   No, that's making things too complicated and won't scale as every distro has developed a different means for specifying the status for a service. Why not just add EAGAIN for that /proc node?

    And FWIW the error condition is correct in my opinion if kernel acpi hasn't been enabled, which was the case here.

I think we should to give a warning message to LTP users. How do you think the following patch?

testcases/kernel/fs/proc/proc01.c +0 -0
index 2d4a5fd..62d44b1 100644

testcases/kernel/fs/proc/proc01.c const Mapping known_issues[] = { · line 106

Quoted 6 lines
testcases/kernel/fs/proc/proc01.c +1 -0
@@ -101,6 +101,7 @@ const Mapping known_issues[] = {
     {"read", "/proc/fs/nfsd/filehandle", EINVAL},
     {"read", "/proc/fs/nfsd/.getfs", EINVAL},
     {"read", "/proc/fs/nfsd/.getfd", EINVAL},
+    {"read", "/proc/acpi/event", EAGAIN}, //EAGAIN will be returned if acpi daemon disabled
     {"", "", 0}
  };

Looks good minus the C++ style comment ;).
Thanks again!
-Garrett

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

author
#5 lore raw
Quoted 28 lines · Garrett Cooper
Quoted 27 lines · Shi Weihua

Hi Garrett

Quoted 12 lines · Garrett Cooper
Quoted 11 lines · Garrett Cooper
Quoted 10 lines · Shi Weihua

An error message occured when i tested proc01.
---------
proc01 1 TFAIL : read failed: /proc/acpi/event: errno=EAGAIN(11): Resource temporarily unavailable
---------

If "service acpid start", this message will be turned to:
---------
proc01 0 TINFO : /proc/acpi/event: known issue: errno=EBUSY(16): Device or resource busy
---------

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

I think we should to add a check of acpi daemon's status in testcases/kernel/fs/proc/proc01.c.

No, that's making things too complicated and won't scale as every
distro has developed a different means for specifying the status for a service. Why not just add EAGAIN for that /proc node?

And FWIW the error condition is correct in my opinion if kernel
acpi hasn't been enabled, which was the case here.

I think we should to give a warning message to LTP users. How do you think the following patch?

Quoted 13 lines

testcases/kernel/fs/proc/proc01.c const Mapping known_issues[] = { · line 106

Quoted 11 lines
testcases/kernel/fs/proc/proc01.c +1 -0
index 2d4a5fd..62d44b1 100644
@@ -101,6 +101,7 @@ const Mapping known_issues[] = {
    {"read", "/proc/fs/nfsd/filehandle", EINVAL},
    {"read", "/proc/fs/nfsd/.getfs", EINVAL},
    {"read", "/proc/fs/nfsd/.getfd", EINVAL},
+    {"read", "/proc/acpi/event", EAGAIN}, //EAGAIN will be returned if acpi daemon disabled
    {"", "", 0}
 };

Looks good minus the C++ style comment ;).

ok, let's use C style comment.

testcases/kernel/fs/proc/proc01.c +1 -0
index 2d4a5fd..355b7dd 100644
@@ -101,6 +101,7 @@ const Mapping known_issues[] = {
     {"read", "/proc/fs/nfsd/filehandle", EINVAL},
     {"read", "/proc/fs/nfsd/.getfs", EINVAL},
     {"read", "/proc/fs/nfsd/.getfd", EINVAL},
+    {"read", "/proc/acpi/event", EAGAIN}, /* EAGAIN will be returned if acpi daemon disabled */
     {"", "", 0}
 };
Quoted 4 lines

Thanks again!
-Garrett

Signature · 12 lines
Shi Weihua

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Acked-by
#6 lore raw
Quoted 50 lines · Shi Weihua
Quoted 28 lines · Garrett Cooper
Quoted 27 lines · Shi Weihua

Hi Garrett

Quoted 12 lines · Garrett Cooper
Quoted 11 lines · Garrett Cooper
Quoted 10 lines · Shi Weihua

An error message occured when i tested proc01.
---------
proc01      1  TFAIL  :  read failed: /proc/acpi/event: errno=EAGAIN(11): Resource temporarily unavailable
---------

If "service acpid start", this message will be turned to:
---------
proc01      0  TINFO  :  /proc/acpi/event: known issue: errno=EBUSY(16): Device or resource busy
---------

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

I think we should to add a check of acpi daemon's status in testcases/kernel/fs/proc/proc01.c.

   No, that's making things too complicated and won't scale as every distro has developed a different means for specifying the status for a service. Why not just add EAGAIN for that /proc node?

    And FWIW the error condition is correct in my opinion if kernel acpi hasn't been enabled, which was the case here.

I think we should to give a warning message to LTP users. How do you think the following patch?

Quoted 13 lines

testcases/kernel/fs/proc/proc01.c const Mapping known_issues[] = { · line 106

Quoted 11 lines
testcases/kernel/fs/proc/proc01.c +1 -0
index 2d4a5fd..62d44b1 100644
@@ -101,6 +101,7 @@ const Mapping known_issues[] = {
     {"read", "/proc/fs/nfsd/filehandle", EINVAL},
     {"read", "/proc/fs/nfsd/.getfs", EINVAL},
     {"read", "/proc/fs/nfsd/.getfd", EINVAL},
+    {"read", "/proc/acpi/event", EAGAIN}, //EAGAIN will be returned if acpi daemon disabled
     {"", "", 0}
  };

    Looks good minus the C++ style comment ;).

ok, let's use C style comment.

testcases/kernel/fs/proc/proc01.c +0 -0
index 2d4a5fd..355b7dd 100644

testcases/kernel/fs/proc/proc01.c const Mapping known_issues[] = { · line 106

Quoted 6 lines
testcases/kernel/fs/proc/proc01.c +1 -0
@@ -101,6 +101,7 @@ const Mapping known_issues[] = {
     {"read", "/proc/fs/nfsd/filehandle", EINVAL},
     {"read", "/proc/fs/nfsd/.getfs", EINVAL},
     {"read", "/proc/fs/nfsd/.getfd", EINVAL},
+    {"read", "/proc/acpi/event", EAGAIN}, /* EAGAIN will be returned if acpi daemon disabled */
     {"", "", 0}
  };
Acked-by Garrett Cooper <[email protected]>

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list