Skip to contentSkip to conversation

cpuset: fix the problem that cpuset_mem_spread_node() returns an offline node - fix

PATCH New Miao Xie 1 participant 1 message Mar 15, 2010 Memory management

lore
Share & tools
lore

Miao Xie

author
#0 lore raw

PATCH v2 1/2 cpuset: fix the problem that cpuset_mem_spread_node() returns an offline node - fix

Changes from V1 to V2:
- none.

Remove unnecessary smp_wmb().

---
Against the following patch in mmotm-2010-03-11-13-13:
cpuset-fix-the-problem-that-cpuset_mem_spread_node-returns-an-offline-node.patch

---
 kernel/cpuset.c |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)
kernel/cpuset.c +0 -14
index b15c01c..f36e577 100644
@@ -933,23 +933,9 @@ static void cpuset_migrate_mm(struct mm_struct *mm, const nodemask_t *from,
 
 	tsk->mems_allowed = *to;
 
-	/*
-	 * After current->mems_allowed is set to a new value, current will
-	 * allocate new pages for the migrating memory region. So we must
-	 * ensure that update of current->mems_allowed have been completed
-	 * by this moment.
-	 */
-	smp_wmb();
 	do_migrate_pages(mm, from, to, MPOL_MF_MOVE_ALL);
 
 	guarantee_online_mems(task_cs(tsk),&tsk->mems_allowed);
-
-	/*
-	 * After doing migrate pages, current will allocate new pages for
-	 * itself not the other tasks. So we must ensure that update of
-	 * current->mems_allowed have been completed by this moment.
-	 */
-	smp_wmb();
 }
 
 /*
Signature · 1 line
1.6.5.2