Skip to contentSkip to conversation

Use correct array size!

PATCH New Malahal Naineni 2 participants 4 messages Mar 13, 2010 – Mar 15, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Use correct array size!

Signed-off-by Malahal Naineni (malahal at us.ibm.com)
daemons/dmeventd/dmeventd.c +1 -1
diff -r 5d08ba4ae8e8 -r 8db1b9ee17a8 daemons/dmeventd/dmeventd.c
@@ -1369,7 +1369,7 @@ static int _handle_request(struct dm_eve
 		{ DM_EVENT_CMD_ACTIVE, _active},
 	}, *req;
 
-	for (req = requests; req < requests + sizeof(requests); req++)
+	for (req = requests; req < requests + sizeof(requests) / sizeof(requests[0]); req++)
 		if (req->cmd == msg->cmd)
 			return req->f(message_data);
 
#1 lore raw

PATCH 1/1 Use correct array size!

daemons/dmeventd/dmeventd.c static int _handle_request(struct dm_eve · line 1374

Quoted 13 lines · Malahal Naineni
Signed-off-by Malahal Naineni (malahal at us.ibm.com)

diff -r 5d08ba4ae8e8 -r 8db1b9ee17a8 daemons/dmeventd/dmeventd.c

daemons/dmeventd/dmeventd.c +1 -1
@@ -1369,7 +1369,7 @@ static int _handle_request(struct dm_eve
 		{ DM_EVENT_CMD_ACTIVE, _active},
 	}, *req;
 
-	for (req = requests; req < requests + sizeof(requests); req++)
+	for (req = requests; req < requests + sizeof(requests) / sizeof(requests[0]); req++)
 		if (req->cmd == msg->cmd)
 			return req->f(message_data);

NACK

Moving via pointers - thus you need to check whether pointer passes array boundary (just like C++ vector() iterator)

see the difference:
for(req = 0; i < sizeof(requests) / sizeof(requests[0]); req++0

Zdenek

#2 lore raw

PATCH 1/1 Use correct array size!

Quoted 30 lines · Zdenek Kabelac

daemons/dmeventd/dmeventd.c static int _handle_request(struct dm_eve · line 1374

Quoted 13 lines · Malahal Naineni
Signed-off-by Malahal Naineni (malahal at us.ibm.com)

diff -r 5d08ba4ae8e8 -r 8db1b9ee17a8 daemons/dmeventd/dmeventd.c

daemons/dmeventd/dmeventd.c +1 -1
@@ -1369,7 +1369,7 @@ static int _handle_request(struct dm_eve
 		{ DM_EVENT_CMD_ACTIVE, _active},
 	}, *req;
 
-	for (req = requests; req < requests + sizeof(requests); req++)
+	for (req = requests; req < requests + sizeof(requests) / sizeof(requests[0]); req++)
 		if (req->cmd == msg->cmd)
 			return req->f(message_data);

NACK

Moving via pointers - thus you need to check whether pointer passes array boundary (just like C++ vector() iterator)

see the difference:
for(req = 0; i < sizeof(requests) / sizeof(requests[0]); req++0

Zdenek

--
lvm-devel mailing list
lvm-devel at redhat.com
https://www.redhat.com/mailman/listinfo/lvm-devel

#3 lore raw

PATCH 1/1 Use correct array size!

In reply to Zdenek Kabelac
Quoted 18 lines · Zdenek Kabelac

daemons/dmeventd/dmeventd.c static int _handle_request(struct dm_eve · line 1374

Quoted 13 lines · Malahal Naineni
Signed-off-by Malahal Naineni (malahal at us.ibm.com)

diff -r 5d08ba4ae8e8 -r 8db1b9ee17a8 daemons/dmeventd/dmeventd.c

daemons/dmeventd/dmeventd.c +1 -1
@@ -1369,7 +1369,7 @@ static int _handle_request(struct dm_eve
 		{ DM_EVENT_CMD_ACTIVE, _active},
 	}, *req;
 
-	for (req = requests; req < requests + sizeof(requests); req++)
+	for (req = requests; req < requests + sizeof(requests) / sizeof(requests[0]); req++)
 		if (req->cmd == msg->cmd)
 			return req->f(message_data);

NACK

Quoted 5 lines

Moving via pointers - thus you need to check whether pointer passes array boundary (just like C++ vector() iterator)

see the difference:
for(req = 0; i < sizeof(requests) / sizeof(requests[0]); req++0

Ahh, I've confused myself.

as req is pointer of the same type, pointer arithmetic applies here as well, so the patch is correct. We need to add number of array elements.

Zdenek