block: make CONFIG_BLK_CGROUP visible
PATCH 1/1 block: make CONFIG_BLK_CGROUP visible
Make the config visible, so we can choose from CONFIG_BLK_CGROUP=y and CONFIG_BLK_CGROUP=m when CONFIG_IOSCHED_CFQ=m.
--- block/Kconfig | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
block/Kconfig +3 -2
@@ -78,8 +78,9 @@ config BLK_DEV_INTEGRITY Protection. If in doubt, say N. config BLK_CGROUP - tristate + tristate "Block cgroup support" depends on CGROUPS + depends on CFQ_GROUP_IOSCHED default n ---help--- Generic block IO controller cgroup interface. This is the common
@@ -91,7 +92,7 @@ config BLK_CGROUP to such task groups. config DEBUG_BLK_CGROUP - bool + bool "Block cgroup debugging help" depends on BLK_CGROUP default n ---help---
Signature · 1 line
1.6.3
Quoted 36 lines · Li Zefan
Make the config visible, so we can choose from
CONFIG_BLK_CGROUP=yandCONFIG_BLK_CGROUP=mwhenCONFIG_IOSCHED_CFQ=m.Signed-off-by Li Zefan <[email protected]>--- block/Kconfig | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)block/Kconfig +3
-2@@ -78,8 +78,9 @@ config BLK_DEV_INTEGRITY Protection. If in doubt, say N. config BLK_CGROUP - tristate + tristate "Block cgroup support" depends on CGROUPS + depends on CFQ_GROUP_IOSCHED default n ---help--- Generic block IO controller cgroup interface. This is the common@@ -91,7 +92,7 @@ config BLK_CGROUP to such task groups. config DEBUG_BLK_CGROUP - bool + bool "Block cgroup debugging help" depends on BLK_CGROUP default n ---help---Signature · 1 line
1.6.3
LGTM.
Quoted 4 lines · Li Zefan
Make the config visible, so we can choose from
CONFIG_BLK_CGROUP=yandCONFIG_BLK_CGROUP=mwhenCONFIG_IOSCHED_CFQ=m.Signed-off-by Li Zefan <[email protected]>
What kernel is this against?
Quoted 31 lines
--- block/Kconfig | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)block/Kconfig +3
-2@@ -78,8 +78,9 @@ config BLK_DEV_INTEGRITY Protection. If in doubt, say N. config BLK_CGROUP - tristate + tristate "Block cgroup support" depends on CGROUPS + depends on CFQ_GROUP_IOSCHED default n ---help--- Generic block IO controller cgroup interface. This is the common@@ -91,7 +92,7 @@ config BLK_CGROUP to such task groups. config DEBUG_BLK_CGROUP - bool + bool "Block cgroup debugging help" depends on BLK_CGROUP default n ---help---Signature · 1 line
1.6.3
Signature · 1 line
Jens Axboe
Quoted 8 lines · Jens Axboe
Quoted 4 lines · Li Zefan
Make the config visible, so we can choose from
CONFIG_BLK_CGROUP=yandCONFIG_BLK_CGROUP=mwhenCONFIG_IOSCHED_CFQ=m.Signed-off-by Li Zefan <[email protected]>What kernel is this against?
It's against linus' tree. I've just checked the block tree, and found it needs to be synced, otherwise this patch can't be applied on it.
Quoted 5 lines · Li Zefan
Quoted 4 lines · Jens Axboe
Quoted 3 lines · Li Zefan
Make the config visible, so we can choose from
CONFIG_BLK_CGROUP=yandCONFIG_BLK_CGROUP=mwhenCONFIG_IOSCHED_CFQ=m.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Li Zefan <[email protected]>What kernel is this against?
It's against linus' tree. I've just checked the block tree, and found it needs to be synced, otherwise this patch can't be applied on it.
OK, I'll hand apply it.
Signature · 1 line
Jens Axboe
Quoted 13 lines · Li Zefan
Make the config visible, so we can choose from
CONFIG_BLK_CGROUP=yandCONFIG_BLK_CGROUP=mwhenCONFIG_IOSCHED_CFQ=m.Signed-off-by Li Zefan <[email protected]>--- block/Kconfig | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)block/Kconfig +0
-0
block/Kconfig config BLK_DEV_INTEGRITY · line 84
Quoted 8 lines
block/Kconfig +2
-1@@ -78,8 +78,9 @@ config BLK_DEV_INTEGRITY Protection. If in doubt, say N. config BLK_CGROUP - tristate + tristate "Block cgroup support" depends on CGROUPS + depends on CFQ_GROUP_IOSCHED default n
Hi Gui,
This part makes sense. If need to give user an option to keep BLK_CGROUP=y even if CFQ=m.
block/Kconfig config BLK_CGROUP · line 95
Quoted 8 lines
block/Kconfig +1
-1---help--- Generic block IO controller cgroup interface. This is the common@@ -91,7 +92,7 @@ config BLK_CGROUP to such task groups. config DEBUG_BLK_CGROUP - bool + bool "Block cgroup debugging help"
Why are you making DEBUG_BLK_CGROUP this as a user visible/configurable option? This is already controlled by DEBUG_CFQ_IOSCHED. If you don't want the DEBUG overhead, just set DEBUG_CFQ_IOSCHED=n and DEBUG_BLK_CGROUP will not be selected? Making it user visible does not seem to be buying us anything?
Thanks
Vivek
Quoted 5 lines
Quoted 5 lines
block/Kconfig +0
-0---help--- Generic block IO controller cgroup interface. This is the common@@ -91,7 +92,7 @@ config BLK_CGROUP to such task groups.
Quoted 11 lines
block/Kconfig config BLK_CGROUP · line 95
Quoted 3 lines
block/Kconfig +1
-1config DEBUG_BLK_CGROUP - bool + bool "Block cgroup debugging help"Why are you making
DEBUG_BLK_CGROUPthis as a user visible/configurable option? This is already controlled byDEBUG_CFQ_IOSCHED. If you don't want the DEBUG overhead, just set DEBUG_CFQ_IOSCHED=n andDEBUG_BLK_CGROUPwill not be selected? Making it user visible does not seem to be buying us anything?
Sounds reasonable. A minor question, since DEBUG_BLK_CGROUP is not visible, the help message for this config is not visible too, so we still keep it?
Quoted 17 lines · Li Zefan
Quoted 5 lines
Quoted 5 lines
block/Kconfig +0
-0---help--- Generic block IO controller cgroup interface. This is the common@@ -91,7 +92,7 @@ config BLK_CGROUP to such task groups.Quoted 11 lines
block/Kconfig config BLK_CGROUP · line 95
Quoted 3 lines
block/Kconfig +1
-1config DEBUG_BLK_CGROUP - bool + bool "Block cgroup debugging help"Why are you making
DEBUG_BLK_CGROUPthis as a user visible/configurable option? This is already controlled byDEBUG_CFQ_IOSCHED. If you don't want the DEBUG overhead, just set DEBUG_CFQ_IOSCHED=n andDEBUG_BLK_CGROUPwill not be selected? Making it user visible does not seem to be buying us anything?
Quoted 3 lines
Sounds reasonable. A minor question, since
DEBUG_BLK_CGROUPis not visible, the help message for this config is not visible too, so we still keep it?
Right now the message is only for developer if somebody opens the Kconfig file. I think it does not harm if somebody wants to understand what this config option is doing. But if you think that it should not be there, I have no strong opinion about it.
Thanks
Vivek