Skip to contentSkip to conversation

grip: Upgrade to 3.3.1

PATCH In review Scott Garman 2 participants 4 messages Mar 17, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 grip: Upgrade to 3.3.1

* Addresses CVE-2005-0706

---
 conf/checksums.ini                             |    4 ++++
 recipes/grip/grip-3.3.1/no-host-includes.patch |   10 ++++++++++
 recipes/grip/grip_3.3.1.bb                     |   15 +++++++++++++++
 3 files changed, 29 insertions(+), 0 deletions(-)
 create mode 100644 recipes/grip/grip-3.3.1/no-host-includes.patch
 create mode 100644 recipes/grip/grip_3.3.1.bb
conf/checksums.ini +4 -0
index 8dd9d6c..3f1f736 100644
@@ -11018,6 +11018,10 @@ sha256=5a51a67f2828aa679a46bbb95cdc5346d6d4516f8ba74b7744b6049ccbe805ca
 md5=9b51933a03dd7d7ddfbb3643fc82c2d0
 sha256=5a51a67f2828aa679a46bbb95cdc5346d6d4516f8ba74b7744b6049ccbe805ca
 
+[http://downloads.sourceforge.net/grip/3.3.1/grip-3.3.1.tar.gz]
+md5=4b4233999b9f2bc85c711092553ea9aa
+sha256=d46394a1062ed066f9c633b010fd1059e63d9ed791bbb7a85bc6567cf0fd66fd
+
 [http://ftp.gnu.org/gnu/groff/groff-1.19.1.tar.gz]
 md5=57d155378640c12a80642664dfdfc892
 sha256=e07c495a18679b79c7c6f6f475689a33ab2a8ee5af4783e915f08134d1f546d2
recipes/grip/grip-3.3.1/no-host-includes.patch new file +10 -0
new file mode 100644
index 0000000..6a733b1
@@ -0,0 +1,10 @@
+Index: grip-3.3.1/src/Makefile.am
+===================================================================
+--- grip-3.3.1.orig/src/Makefile.am	2010-03-16 14:46:01.651553829 +0800
++++ grip-3.3.1/src/Makefile.am	2010-03-16 14:46:05.240303128 +0800
+@@ -1,4 +1,4 @@
+-INCLUDES = -I$(top_srcdir) -I$(includedir) \
++INCLUDES = -I$(top_srcdir) \
+ 	-DGNOME_ICONDIR=\""$(datadir)/pixmaps"\" \
+          -DG_LOG_DOMAIN=\"grip\" -DGNOMELOCALEDIR=\""$(datadir)/locale"\" \
+         -I../intl -I$(top_srcdir)/intl \
recipes/grip/grip_3.3.1.bb new file +15 -0
new file mode 100644
index 0000000..56f7120
@@ -0,0 +1,15 @@
+# grip OE build file
+# Copyright (C) 2005, Advanced Micro Devices, Inc.  All Rights Reserved
+# Released under the MIT license (see packages/COPYING)
+
+HOMEPAGE="http://www.nostatic.org/grip/"
+LICENSE="GPL"
+
+SRC_URI="${SOURCEFORGE_MIRROR}/grip/${PV}/grip-${PV}.tar.gz \
+         file://no-host-includes.patch;patch=1 "
+
+DEPENDS="libgnomeui vte curl cdparanoia id3lib"
+
+PR = "r1"
+
+inherit autotools
Signature · 1 line
1.6.3.3
#2 lore raw
In reply to Scott Garman
Quoted 3 lines · On Wednesday 17 March 2010 07:51:01 Scott Garman wrote:

* Addresses CVE-2005-0706

I was upgrading grip to the latest stable version yesterday, I have no issue if you want to upgrade to the latest devel version, even debian is shipping that... I have some comments in line.

Quoted 2 lines
 create mode 100644 recipes/grip/grip-3.3.1/no-host-includes.patch
 create mode 100644 recipes/grip/grip_3.3.1.bb

Please git mv from grip_3.2.0 to grip_3.3.1

conf/checksums.ini sha256=5a51a67f2828aa679a46bbb95cdc5346d6d4516f8ba74b7744b6049ccbe805ca · line 11023

Quoted 3 lines

+[http://downloads.sourceforge.net/grip/3.3.1/grip-3.3.1.tar.gz]

conf/checksums.ini +2 -0
+md5=4b4233999b9f2bc85c711092553ea9aa
+sha256=d46394a1062ed066f9c633b010fd1059e63d9ed791bbb7a85bc6567cf0fd66fd

that is deprecated, please see grip_3.2.0.bb on how to put the checksums into the recipe.

I'm happy to review and push your updated recipe.

thanks for helping out.

	z.
#3 lore raw
Quoted 8 lines · Holger Hans Peter Freyther
Quoted 3 lines · On Wednesday 17 March 2010 07:51:01 Scott Garman wrote:

* Addresses CVE-2005-0706

I was upgrading grip to the latest stable version yesterday, I have no issue if you want to upgrade to the latest devel version, even debian is shipping that... I have some comments in line.

Thanks for the guidance. I will re-submit an improved patch later today based on your feedback.

Quoted 14 lines
Quoted 2 lines

create mode 100644 recipes/grip/grip-3.3.1/no-host-includes.patch create mode 100644 recipes/grip/grip_3.3.1.bb

Please git mv from grip_3.2.0 to grip_3.3.1

conf/checksums.ini sha256=5a51a67f2828aa679a46bbb95cdc5346d6d4516f8ba74b7744b6049ccbe805ca · line 11023

Quoted 3 lines

+[http://downloads.sourceforge.net/grip/3.3.1/grip-3.3.1.tar.gz]

conf/checksums.ini +2 -0
+md5=4b4233999b9f2bc85c711092553ea9aa
+sha256=d46394a1062ed066f9c633b010fd1059e63d9ed791bbb7a85bc6567cf0fd66fd

that is deprecated, please see grip_3.2.0.bb on how to put the checksums into the recipe.

Quoted 1 line

I'm happy to review and push your updated recipe.

Much appreciated!

Scott

Signature · 2 lines
Scott Garman
sgarman at zenlinux dot com