Skip to contentSkip to conversation

bfa: wrong fcport H2I message tested in bfa_fcport_isr()

PATCH In review Roel Kluin 2 participants 2 messages Mar 22, 2010

Subsystems (2)
SCSI Brocade BFA FC SCSI driver
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 bfa: wrong fcport H2I message tested in bfa_fcport_isr()

It appears that the wrong fcport H2I message was tested

Signed-off-by Roel Kluin <[email protected]>

---
Was this intended?

drivers/scsi/bfa/bfa_fcport.c +1 -1
index c589488..5e5e6fe 100644
@@ -1281,7 +1281,7 @@ bfa_fcport_isr(struct bfa_s *bfa, struct bfi_msg_s *msg)
 		break;
 
 	case BFI_FCPORT_I2H_DISABLE_RSP:
-		if (fcport->msgtag == i2hmsg.penable_rsp->msgtag)
+		if (fcport->msgtag == i2hmsg.pdisable_rsp->msgtag)
 			bfa_sm_send_event(fcport, BFA_FCPORT_SM_FWRSP);
 		break;
#1 lore raw

This is not intended. Using penable_rsp or pdisable_rsp in this case doesn't have functional difference since it is a union, but it is confusing and should be fixed.

Thanks

Jing

-----Original Message-----
From: Roel Kluin [mailto:[email protected]]
Sent: Monday, March 22, 2010 1:49 PM
To: Jing Huang; [email protected]; Andrew Morton; LKML
Subject: [PATCH] bfa: wrong fcport H2I message tested in bfa_fcport_isr()

It appears that the wrong fcport H2I message was tested

Signed-off-by Roel Kluin <[email protected]>

---
Was this intended?

drivers/scsi/bfa/bfa_fcport.c +1 -1
index c589488..5e5e6fe 100644
@@ -1281,7 +1281,7 @@ bfa_fcport_isr(struct bfa_s *bfa, struct bfi_msg_s *msg)
 		break;
 
 	case BFI_FCPORT_I2H_DISABLE_RSP:
-		if (fcport->msgtag == i2hmsg.penable_rsp->msgtag)
+		if (fcport->msgtag == i2hmsg.pdisable_rsp->msgtag)
 			bfa_sm_send_event(fcport, BFA_FCPORT_SM_FWRSP);
 		break;