Netfilter: Code cleanup on net/netfilter
Subsystems (2)
PATCH 1/1 Netfilter: Code cleanup on net/netfilter
Fix some coding styles and remove moduleparam.h
Signed-off-by Zhitong Wang <[email protected]>
--- net/ipv4/netfilter/nf_nat_h323.c | 1 - net/ipv4/netfilter/nf_nat_standalone.c | 3 +-- net/ipv4/netfilter/nf_nat_tftp.c | 1 - net/netfilter/nf_conntrack_proto.c | 2 -- 4 files changed, 1 insertions(+), 6 deletions(-)
net/ipv4/netfilter/nf_nat_h323.c +0 -1
@@ -10,7 +10,6 @@*/ #include <linux/module.h> -#include <linux/moduleparam.h> #include <linux/tcp.h> #include <net/tcp.h>
net/ipv4/netfilter/nf_nat_standalone.c +1 -2
@@ -137,9 +137,8 @@ nf_nat_fn(unsigned int hooknum, ret =nf_nat_rule_find (skb, hooknum, in, out, ct); -if (ret !=NF_ACCEPT ) { +if (ret !=NF_ACCEPT )return ret; - } }else pr_debug("Already setup manip %s for ct %p\n", maniptype == IP_NAT_MANIP_SRC ? "SRC" : "DST",
net/ipv4/netfilter/nf_nat_tftp.c +0 -1
@@ -6,7 +6,6 @@*/ #include <linux/module.h> -#include <linux/moduleparam.h> #include <linux/udp.h> #include <net/netfilter/nf_nat_helper.h>
net/netfilter/nf_conntrack_proto.c +0 -2
@@ -13,12 +13,10 @@#include <linux/netfilter.h> #include <linux/module.h> #include <linux/mutex.h> -#include <linux/skbuff.h> #include <linux/vmalloc.h> #include <linux/stddef.h> #include <linux/err.h> #include <linux/percpu.h> -#include <linux/moduleparam.h> #include <linux/notifier.h> #include <linux/kernel.h> #include <linux/netdevice.h>
Signature · 1 line
1.6.5.3
Quoted 1 line · [email protected] wrote:
Fix some coding styles and remove
moduleparam.h
I've already applied your patches to remove moduleparam.h. Please base your patches on
git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-next-2.6.git
ok, thx, i'll send a new patch soon.
Quoted 8 lines · Patrick McHardy
Quoted 1 line · [email protected] wrote:
Fix some coding styles and remove
moduleparam.hI've already applied your patches to remove
moduleparam.h. Please base your patches on
git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-next-2.6.git