Skip to contentSkip to conversation

e1000e: export some settings using ethtool private flags

PATCH In review Jeff Garzik 3 participants 5 messages Feb 27, 2010 – Mar 25, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 e1000e: export some settings using ethtool private flags

The ethtool private flags interface exists to get/set driver-specific settings at runtime, in a flexible manner.

Use this facility to export a couple e1000e features, that were previously only set at module initialization time.

---
 drivers/net/e1000e/ethtool.c |   27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
drivers/net/e1000e/ethtool.c +27 -0
index b33e3cb..4bda27f 100644
@@ -112,6 +112,30 @@ static const char e1000_gstrings_test[][ETH_GSTRING_LEN] = {
 };
 #define E1000_TEST_LEN ARRAY_SIZE(e1000_gstrings_test)
 
+enum e1000_pflags {
+	E1000_PF_SMART_POWERDOWN	= (1 << 0),
+	E1000_PF_RO_NVM			= (1 << 1),
+};
+
+#define E1000_N_PFLAGS ARRAY_SIZE(e1000_gstrings_pflags)
+static const char e1000_gstrings_pflags[][ETH_GSTRING_LEN] = {
+	"smart_power_down",
+	"read_only_nvm",
+};
+
+u32 e1000_get_priv_flags(struct net_device *netdev)
+{
+	struct e1000_adapter *adapter = netdev_priv(netdev);
+	u32 ret = 0;
+
+	if (adapter->flags & FLAG_SMART_POWER_DOWN)
+		ret |= E1000_PF_SMART_POWERDOWN;
+	if (adapter->flags & FLAG_READ_ONLY_NVM)
+		ret |= E1000_PF_RO_NVM;
+
+	return ret;
+}
+
 static int e1000_get_settings(struct net_device *netdev,
 			      struct ethtool_cmd *ecmd)
 {
@@ -1666,6 +1690,8 @@ static int e1000e_get_sset_count(struct net_device *netdev, int sset)
 		return E1000_TEST_LEN;
 	case ETH_SS_STATS:
 		return E1000_STATS_LEN;
+	case ETH_SS_PRIV_FLAGS:
+		return E1000_N_PFLAGS;
 	default:
 		return -EOPNOTSUPP;
 	}
@@ -2014,6 +2040,7 @@ static const struct ethtool_ops e1000_ethtool_ops = {
 	.set_coalesce		= e1000_set_coalesce,
 	.get_flags		= ethtool_op_get_flags,
 	.set_flags		= ethtool_op_set_flags,
+	.get_priv_flags		= e1000_get_priv_flags,
 };
 
 void e1000e_set_ethtool_ops(struct net_device *netdev)
#1 lore raw
Quoted 10 lines · Jeff Garzik

The ethtool private flags interface exists to get/set driver-specific settings at runtime, in a flexible manner.

Use this facility to export a couple e1000e features, that were previously only set at module initialization time.

---
 drivers/net/e1000e/ethtool.c |   27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

Jeff,

What is the use case for the ethtool private flags? At least I don't see an option in ethtool that would make use of them.

Thanks,
Emil

#2 lore raw
Quoted 7 lines · Emil S
Quoted 6 lines · Jeff Garzik

The ethtool private flags interface exists to get/set driver-specific settings at runtime, in a flexible manner.

Use this facility to export a couple e1000e features, that were previously only set at module initialization time.

Quoted 8 lines
Quoted 4 lines
---
  drivers/net/e1000e/ethtool.c |   27 +++++++++++++++++++++++++++
  1 file changed, 27 insertions(+)

Jeff,

What is the use case for the ethtool private flags?

It is stated in the changelog above :) It enables feature setting at setting, on an easy, per-network-interface basis, that were previously only settable at module initialization (ie. load) time.

Quoted 1 line

At least I don't see an option in ethtool that would make use of them.

This is added in a separate patch, since the above patch is the first to make use of the private-flags ethtool mechanism.

Jeff

#3 lore raw
Quoted 22 lines · Jeff Garzik
Quoted 7 lines · Emil S
Quoted 6 lines · Jeff Garzik

The ethtool private flags interface exists to get/set driver-specific settings at runtime, in a flexible manner.

Use this facility to export a couple e1000e features, that were previously only set at module initialization time.

Quoted 8 lines
Quoted 4 lines
---
  drivers/net/e1000e/ethtool.c |   27 +++++++++++++++++++++++++++
  1 file changed, 27 insertions(+)

Jeff,

What is the use case for the ethtool private flags?

It is stated in the changelog above :) It enables feature setting at setting, on an easy, per-network-interface basis, that were previously only settable at module initialization (ie. load) time.

Quoted 5 lines
Quoted 2 lines

At least I don't see an option in ethtool that would make use of them.

This is added in a separate patch, since the above patch is the first to make use of the private-flags ethtool mechanism.

Can you point me to it? It would really help me with testing.

Thanks,
Emil

#4 lore raw

http://lists.openwall.net/netdev/2007/08/10/114

Quoted 40 lines · Emil S
Quoted 22 lines · Jeff Garzik
Quoted 7 lines · Emil S
Quoted 6 lines · Jeff Garzik

The ethtool private flags interface exists to get/set driver-specific settings at runtime, in a flexible manner.

Use this facility to export a couple e1000e features, that were previously only set at module initialization time.

Quoted 8 lines
Quoted 4 lines

---
  drivers/net/e1000e/ethtool.c |   27 +++++++++++++++++++++++++++

  1 file changed, 27 insertions(+)

Jeff,

What is the use case for the ethtool private flags?

It is stated in the changelog above :)  It enables feature setting at setting, on an easy, per-network-interface basis, that were previously only settable at module initialization (ie. load) time.

Quoted 5 lines
Quoted 2 lines

At least I don't see an option in ethtool that would make use of them.

This is added in a separate patch, since the above patch is the first to make use of the private-flags ethtool mechanism.

Can you point me to it? It would really help me with testing.

Thanks,
Emil

--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html