Fix busted driftfix option
PATCH 1/1 Fix busted driftfix option
For some reason, this uses CONFIG_TARGET_I386 instead of TARGET_I386, so the code is dead.
CONFIG_TARGET_XXX is wrong
vl.c +1 -1
@@ -1565,7 +1565,7 @@ static void configure_rtc(QemuOpts *opts)exit (1 ); } } -#ifdef CONFIG_TARGET_I386 +#ifdef TARGET_I386 value =qemu_opt_get (opts,"driftfix" );if (value) {if (!strcmp (buf,"slew" )) {
Quoted 2 lines · Zachary Amsden
For some reason, this uses
CONFIG_TARGET_I386instead ofTARGET_I386, so
the code is dead.
The code is also broken: it references undefined variable 'buf' instead of 'value'.
Quoted 8 lines · Blue Swirl
Quoted 3 lines · Zachary Amsden
For some reason, this uses
CONFIG_TARGET_I386instead ofTARGET_I386, so
the code is dead.The code is also broken: it references undefined variable 'buf' instead of 'value'.
Sorry, that wasn't the case on the branch I ported from. Can you apply a trivial fix or should I send along a patch?
Thanks,
Zach
Quoted 6 lines · Zachary Amsden
Quoted 5 lines · Blue Swirl
Quoted 3 lines · Zachary Amsden
For some reason, this uses
CONFIG_TARGET_I386instead ofTARGET_I386, so
the code is dead.
Quoted 7 lines
Quoted 3 lines
The code is also broken: it references undefined variable 'buf' instead of 'value'.
Sorry, that wasn't the case on the branch I ported from. Can you apply
a trivial fix or should I send along a patch?
I've already committed the fix.