Skip to contentSkip to conversation

rcu: remove lock acquirement when very eary boot

PATCH In review Lai Jiangshan 2 participants 2 messages Mar 28, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rcu: remove lock acquirement when very eary boot

cleanup: remove lock acquirement when very eary boot

---

kernel/rcutree.c +0 -4
index 112edb5..e6014e1 100644
@@ -1646,13 +1646,10 @@ EXPORT_SYMBOL_GPL(rcu_barrier_sched);
 static void __init
 rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
 {
-	unsigned long flags;
 	int i;
 	struct rcu_data *rdp = rsp->rda[cpu];
-	struct rcu_node *rnp = rcu_get_root(rsp);
 
 	/* Set up local state, ensuring consistent view of global state. */
-	raw_spin_lock_irqsave(&rnp->lock, flags);
 	rdp->grpmask = 1UL << (cpu - rdp->mynode->grplo);
 	rdp->nxtlist = NULL;
 	for (i = 0; i < RCU_NEXT_SIZE; i++)
@@ -1662,7 +1659,6 @@ rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
 	rdp->dynticks = &per_cpu(rcu_dynticks, cpu);
 #endif /* #ifdef CONFIG_NO_HZ */
 	rdp->cpu = cpu;
-	raw_spin_unlock_irqrestore(&rnp->lock, flags);
 }
 
 /*
#1 lore raw
Quoted 2 lines · Lai Jiangshan

cleanup: remove lock acquirement when very eary boot

This is indeed a safe change, however, I am keeping this lock acquisition and release for documentation purposes. Call me paranoid, but...

Thanx, Paul

Quoted 29 lines

---

kernel/rcutree.c +0 -4
index 112edb5..e6014e1 100644
@@ -1646,13 +1646,10 @@ EXPORT_SYMBOL_GPL(rcu_barrier_sched);
 static void __init
 rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
 {
-	unsigned long flags;
 	int i;
 	struct rcu_data *rdp = rsp->rda[cpu];
-	struct rcu_node *rnp = rcu_get_root(rsp);
 
 	/* Set up local state, ensuring consistent view of global state. */
-	raw_spin_lock_irqsave(&rnp->lock, flags);
 	rdp->grpmask = 1UL << (cpu - rdp->mynode->grplo);
 	rdp->nxtlist = NULL;
 	for (i = 0; i < RCU_NEXT_SIZE; i++)
@@ -1662,7 +1659,6 @@ rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
 	rdp->dynticks = &per_cpu(rcu_dynticks, cpu);
 #endif /* #ifdef CONFIG_NO_HZ */
 	rdp->cpu = cpu;
-	raw_spin_unlock_irqrestore(&rnp->lock, flags);
 }
 
 /*