Skip to contentSkip to conversation

s5p6442: Support Samsung s5p6442 SoC

PATCH New Joonyoung Shim 3 participants 5 messages Mar 29, 2010 – Apr 9, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 s5p6442: Support Samsung s5p6442 SoC

This patch adds support s5p6442 SoC. The s5p6442 SoC is ARM1176 processor.

Cc Minkyu Kang <[email protected]>
Cc Kyungmin Park <[email protected]>
---
 cpu/arm1176/s5p64xx/Makefile         |   52 +++++++++
 cpu/arm1176/s5p64xx/clock.c          |  163 +++++++++++++++++++++++++++
 cpu/arm1176/s5p64xx/cpu_info.c       |   58 ++++++++++
 cpu/arm1176/s5p64xx/reset.S          |   35 ++++++
 cpu/arm1176/s5p64xx/timer.c          |  204 ++++++++++++++++++++++++++++++++++
 include/asm-arm/arch-s5p64xx/clk.h   |   38 +++++++
 include/asm-arm/arch-s5p64xx/clock.h |   69 ++++++++++++
 include/asm-arm/arch-s5p64xx/cpu.h   |   57 ++++++++++
 include/asm-arm/arch-s5p64xx/gpio.h  |  111 ++++++++++++++++++
 include/asm-arm/arch-s5p64xx/power.h |   76 +++++++++++++
 include/asm-arm/arch-s5p64xx/pwm.h   |   58 ++++++++++
 include/asm-arm/arch-s5p64xx/uart.h  |   47 ++++++++
 12 files changed, 968 insertions(+), 0 deletions(-)
 create mode 100644 cpu/arm1176/s5p64xx/Makefile
 create mode 100644 cpu/arm1176/s5p64xx/clock.c
 create mode 100644 cpu/arm1176/s5p64xx/cpu_info.c
 create mode 100644 cpu/arm1176/s5p64xx/reset.S
 create mode 100644 cpu/arm1176/s5p64xx/timer.c
 create mode 100644 include/asm-arm/arch-s5p64xx/clk.h
 create mode 100644 include/asm-arm/arch-s5p64xx/clock.h
 create mode 100644 include/asm-arm/arch-s5p64xx/cpu.h
 create mode 100644 include/asm-arm/arch-s5p64xx/gpio.h
 create mode 100644 include/asm-arm/arch-s5p64xx/power.h
 create mode 100644 include/asm-arm/arch-s5p64xx/pwm.h
 create mode 100644 include/asm-arm/arch-s5p64xx/uart.h
cpu/arm1176/s5p64xx/Makefile new file +52 -0
new file mode 100644
index 0000000..625d8f5
@@ -0,0 +1,52 @@
+#
+# (C) Copyright 2000-2003
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# (C) Copyright 2008
+# Guennadi Liakhovetki, DENX Software Engineering, <[email protected]>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB	= $(obj)lib$(SOC).a
+
+SOBJS	= reset.o
+
+COBJS	+= clock.o
+COBJS	+= cpu_info.o
+COBJS	+= timer.o
+
+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS) $(SOBJS))
+
+all:	 $(obj).depend $(LIB)
+
+$(LIB):	$(OBJS)
+	$(AR) $(ARFLAGS) $@ $(OBJS)
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
cpu/arm1176/s5p64xx/clock.c new file +163 -0

163 lines not on this page · raw message

cpu/arm1176/s5p64xx/cpu_info.c new file +58 -0

58 lines not on this page · raw message

cpu/arm1176/s5p64xx/reset.S new file +35 -0
new file mode 100644
index 0000000..96b2ba4
@@ -0,0 +1,35 @@
+/*
+ * Copyright (C) 2010 Samsung Electronics.
+ * Minkyu Kang <[email protected]>
+ * Joonyoung Shim <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <asm/arch/cpu.h>
+
+#define S5P6442_SWRESET			0xE0102000
+
+.globl reset_cpu
+reset_cpu:
+	ldr	r1, =S5P6442_SWRESET
+	mov	r2, #1
+	str	r2, [r1]
+_loop_forever:
+	b	_loop_forever
cpu/arm1176/s5p64xx/timer.c new file +204 -0

204 lines not on this page · raw message

include/asm-arm/arch-s5p64xx/clk.h new file +38 -0
new file mode 100644
index 0000000..a9dc5f1
@@ -0,0 +1,38 @@
+/*
+ * Copyright (C) 2010 Samsung Electronics
+ * Minkyu Kang <[email protected]>
+ * Joonyoung Shim <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ *
+ */
+
+#ifndef __ASM_ARM_ARCH_CLK_H_
+#define __ASM_ARM_ARCH_CLK_H_
+
+#define APLL	0
+#define MPLL	1
+#define EPLL	2
+#define HPLL	3
+#define VPLL	4
+
+void s5p64xx_clock_init(void);
+
+extern unsigned long (*get_pll_clk)(int pllreg);
+extern unsigned long (*get_arm_clk)(void);
+extern unsigned long (*get_pclk)(void);
+
+#endif
include/asm-arm/arch-s5p64xx/clock.h new file +69 -0

69 lines not on this page · raw message

include/asm-arm/arch-s5p64xx/cpu.h new file +57 -0

57 lines not on this page · raw message

include/asm-arm/arch-s5p64xx/gpio.h new file +111 -0

111 lines not on this page · raw message

include/asm-arm/arch-s5p64xx/power.h new file +76 -0

76 lines not on this page · raw message

include/asm-arm/arch-s5p64xx/pwm.h new file +58 -0

58 lines not on this page · raw message

include/asm-arm/arch-s5p64xx/uart.h new file +47 -0

47 lines not on this page · raw message

Signature · 1 line
1.6.3.3
#1 lore raw

PATCH 1/4 s5p6442: Support Samsung s5p6442 SoC

Dear Joonyoung Shim,

Quoted 144 lines · Joonyoung Shim

This patch adds support s5p6442 SoC. The s5p6442 SoC is ARM1176 processor.

Cc Minkyu Kang <[email protected]>
Cc Kyungmin Park <[email protected]>

---

?cpu/arm1176/s5p64xx/Makefile ? ? ? ? | ? 52 +++++++++
?cpu/arm1176/s5p64xx/clock.c ? ? ? ? ?| ?163 +++++++++++++++++++++++++++
?cpu/arm1176/s5p64xx/cpu_info.c ? ? ? | ? 58 ++++++++++
?cpu/arm1176/s5p64xx/reset.S ? ? ? ? ?| ? 35 ++++++
?cpu/arm1176/s5p64xx/timer.c ? ? ? ? ?| ?204 ++++++++++++++++++++++++++++++++++
?include/asm-arm/arch-s5p64xx/clk.h ? | ? 38 +++++++
?include/asm-arm/arch-s5p64xx/clock.h | ? 69 ++++++++++++
?include/asm-arm/arch-s5p64xx/cpu.h ? | ? 57 ++++++++++
?include/asm-arm/arch-s5p64xx/gpio.h ?| ?111 ++++++++++++++++++
?include/asm-arm/arch-s5p64xx/power.h | ? 76 +++++++++++++
?include/asm-arm/arch-s5p64xx/pwm.h ? | ? 58 ++++++++++
?include/asm-arm/arch-s5p64xx/uart.h ?| ? 47 ++++++++

?12 files changed, 968 insertions(+), 0 deletions(-) ?create mode 100644 cpu/arm1176/s5p64xx/Makefile ?create mode 100644 cpu/arm1176/s5p64xx/clock.c ?create mode 100644 cpu/arm1176/s5p64xx/cpu_info.c ?create mode 100644 cpu/arm1176/s5p64xx/reset.S ?create mode 100644 cpu/arm1176/s5p64xx/timer.c ?create mode 100644 include/asm-arm/arch-s5p64xx/clk.h ?create mode 100644 include/asm-arm/arch-s5p64xx/clock.h ?create mode 100644 include/asm-arm/arch-s5p64xx/cpu.h ?create mode 100644 include/asm-arm/arch-s5p64xx/gpio.h ?create mode 100644 include/asm-arm/arch-s5p64xx/power.h ?create mode 100644 include/asm-arm/arch-s5p64xx/pwm.h ?create mode 100644 include/asm-arm/arch-s5p64xx/uart.h

cpu/arm1176/s5p64xx/clock.c new file +105 -0
new file mode 100644
index 0000000..5fe0482
@@ -0,0 +1,163 @@
+/*
+ * Copyright (C) 2010 Samsung Electronics
+ * Minkyu Kang <[email protected]>
+ * Joonyoung Shim <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. ?See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <common.h>
+#include <asm/io.h>
+#include <asm/arch/clock.h>
+#include <asm/arch/clk.h>
+
+#ifndef CONFIG_SYS_CLK_FREQ_6442
+#define CONFIG_SYS_CLK_FREQ_6442 ? ? ? 12000000
+#endif
+
+unsigned long (*get_pclk)(void);
+unsigned long (*get_arm_clk)(void);
+unsigned long (*get_pll_clk)(int);
+
+/* s5p6442: return pll clock frequency */
+static unsigned long s5p6442_get_pll_clk(int pllreg)
+{
+ ? ? ? struct s5p6442_clock *clk = (struct s5p6442_clock *)S5P64XX_CLOCK_BASE;
+ ? ? ? unsigned long r, m, p, s, mask, fout;
+ ? ? ? unsigned int freq;
+
+ ? ? ? switch (pllreg) {
+ ? ? ? case APLL:
+ ? ? ? ? ? ? ? r = readl(&clk->apll_con);
+ ? ? ? ? ? ? ? break;
+ ? ? ? case MPLL:
+ ? ? ? ? ? ? ? r = readl(&clk->mpll_con);
+ ? ? ? ? ? ? ? break;
+ ? ? ? case EPLL:
+ ? ? ? ? ? ? ? r = readl(&clk->epll_con);
+ ? ? ? ? ? ? ? break;
+ ? ? ? case VPLL:
+ ? ? ? ? ? ? ? r = readl(&clk->vpll_con);
+ ? ? ? ? ? ? ? break;
+ ? ? ? default:
+ ? ? ? ? ? ? ? printf("Unsupported PLL (%d)\n", pllreg);
+ ? ? ? ? ? ? ? return 0;
+ ? ? ? }
+
+ ? ? ? /*
+ ? ? ? ?* APLL_CON: MIDV [25:16]
+ ? ? ? ?* MPLL_CON: MIDV [25:16]
+ ? ? ? ?* EPLL_CON: MIDV [24:16]
+ ? ? ? ?* VPLL_CON: MIDV [24:16]
+ ? ? ? ?*/
+ ? ? ? if (pllreg == APLL || pllreg == MPLL)
+ ? ? ? ? ? ? ? mask = 0x3ff;
+ ? ? ? else
+ ? ? ? ? ? ? ? mask = 0x1ff;
+
+ ? ? ? m = (r >> 16) & mask;
+
+ ? ? ? /* PDIV [13:8] */
+ ? ? ? p = (r >> 8) & 0x3f;
+ ? ? ? /* SDIV [2:0] */
+ ? ? ? s = r & 0x7;
+
+ ? ? ? freq = CONFIG_SYS_CLK_FREQ_6442;
+ ? ? ? if (pllreg == APLL) {
+ ? ? ? ? ? ? ? if (s < 1)
+ ? ? ? ? ? ? ? ? ? ? ? s = 1;
+ ? ? ? ? ? ? ? /* FOUT = MDIV * FIN / (PDIV * 2^(SDIV - 1)) */
+ ? ? ? ? ? ? ? fout = m * (freq / (p * (1 << (s - 1))));
+ ? ? ? } else {
+ ? ? ? ? ? ? ? /* FOUT = MDIV * FIN / (PDIV * 2^SDIV) */
+ ? ? ? ? ? ? ? fout = m * (freq / (p * (1 << s)));
+ ? ? ? }
+
+ ? ? ? return fout;
+}
+
+/* s5p6442: return ARM clock frequency */
+static unsigned long s5p6442_get_arm_clk(void)
+{
+ ? ? ? struct s5p6442_clock *clk = (struct s5p6442_clock *)S5P64XX_CLOCK_BASE;
+ ? ? ? unsigned long div;
+ ? ? ? unsigned long dout_apll, armclk;
+ ? ? ? unsigned int apll_ratio;
+
+ ? ? ? div = readl(&clk->div0);
+
+ ? ? ? /* APLL_RATIO: [2:0] */

cpu/arm1176/s5p64xx/clock.c line 115

Quoted 10 lines
cpu/arm1176/s5p64xx/clock.c new file +10 -0
+ ? ? ? apll_ratio = div & 0x7;
+
+ ? ? ? dout_apll = get_pll_clk(APLL) / (apll_ratio + 1);
+ ? ? ? armclk = dout_apll;
+
+ ? ? ? return armclk;
+}
+
+/* s5p6442: return D0CLK frequency */
+static unsigned long get_d0clk(void)

clock.c:116: warning: 'get_d0clk' defined but not used. Please remove this function, if didn't use.

Quoted 38 lines
cpu/arm1176/s5p64xx/clock.c new file +38 -0
+{
+ ? ? ? struct s5p6442_clock *clk = (struct s5p6442_clock *)S5P64XX_CLOCK_BASE;
+ ? ? ? unsigned long d0clk;
+ ? ? ? uint div, d0_bus_ratio;
+
+ ? ? ? div = readl(&clk->div0);
+ ? ? ? /* D0CLK_RATIO: [19:16] */
+ ? ? ? d0_bus_ratio = (div >> 16) & 0xf;
+
+ ? ? ? d0clk = get_arm_clk() / (d0_bus_ratio + 1);
+
+ ? ? ? return d0clk;
+}
+
+/* s5p6442: return P1CLK frequency */
+static unsigned long get_p1clk(void)
+{
+ ? ? ? struct s5p6442_clock *clk = (struct s5p6442_clock *)S5P64XX_CLOCK_BASE;
+ ? ? ? unsigned long d1_bus, p1clk;
+ ? ? ? uint div, d1_bus_ratio, p1clk_ratio;
+
+ ? ? ? div = readl(&clk->div0);
+ ? ? ? /* D1CLK_RATIO: [27:24] */
+ ? ? ? d1_bus_ratio = (div >> 24) & 0xf;
+ ? ? ? /* P1CLK_RATIO: [30:28] */
+ ? ? ? p1clk_ratio = (div >> 28) & 0x7;
+
+ ? ? ? /* ASYNC Mode */
+ ? ? ? d1_bus = get_pll_clk(MPLL) / (d1_bus_ratio + 1);
+ ? ? ? p1clk = d1_bus / (p1clk_ratio + 1);
+
+ ? ? ? return p1clk;
+}
+
+/* s5p6442: return peripheral clock frequency */
+static unsigned long s5p6442_get_pclk(void)
+{
+ ? ? ? return get_p1clk();

cpu/arm1176/s5p64xx/clock.c line 163

Quoted 10 lines
cpu/arm1176/s5p64xx/clock.c new file +10 -0
+}
+
+void s5p64xx_clock_init(void)
+{
+ ? ? ? if (cpu_is_s5p6442()) {
+ ? ? ? ? ? ? ? get_pll_clk = s5p6442_get_pll_clk;
+ ? ? ? ? ? ? ? get_arm_clk = s5p6442_get_arm_clk;
+ ? ? ? ? ? ? ? get_pclk = s5p6442_get_pclk;
+ ? ? ? }
+}

Thanks
Minkyu Kang

Signature · 2 lines
from. prom.
www.promsoft.net
#2 lore raw

PATCH 1/4 s5p6442: Support Samsung s5p6442 SoC

In reply to Joonyoung Shim

Dear Joonyoung Shim,

Quoted 6 lines · In message <[email protected]> you wrote:

This patch adds support s5p6442 SoC. The s5p6442 SoC is ARM1176 processor.

Cc Minkyu Kang <[email protected]>
Cc Kyungmin Park <[email protected]>

...

Quoted 1 line

+#define S5P6442_PWR_CFG 0xE010C000

...

Quoted 27 lines
include/asm-arm/arch-s5p64xx/power.h new file +27 -0
+#define S5P6442_EINT_WAKEUP_MASK	0xE010C004
+#define S5P6442_WAKEUP_MASK		0xE010C008
+#define S5P6442_PWR_MODE		0xE010C00C
+#define S5P6442_PWR_MODE_SLEEP		(1 << 2)
+#define S5P6442_NORMAL_CFG		0xE010C010
+#define S5P6442_IDLE_CFG		0xE010C020
+#define S5P6442_STOP_CFG		0xE010C030
+#define S5P6442_STOP_MEM_CFG		0xE010C034
+#define S5P6442_SLEEP_CFG		0xE010C040
+#define S5P6442_OSC_FREQ		0xE010C100
+#define S5P6442_OSC_STABLE		0xE010C104
+#define S5P6442_PWR_STABLE		0xE010C108
+#define S5P6442_MTC_STABLE		0xE010C110
+#define S5P6442_CLAMP_STABLE		0xE010C114
+#define S5P6442_WAKEUP_STAT		0xE010C200
+#define S5P6442_OTHERS			0xE010E000
+#define S5P6442_OTHERS_SYSCON_INT_DISABLE	(1 << 0)
+#define S5P6442_MIE_CONTROL		0xE010E800
+#define S5P6442_HDMI_CONTROL		0xE010E804
+#define S5P6442_USB_PHY_CON		0xE010E80C
+#define S5P6442_DAC_CONTROL		0xE010E810
+#define S5P6442_MIPI_DPHY_CONTROL	0xE010E814
+#define S5P6442_ADC_CONTROL		0xE010E818
+#define S5P6442_PS_HOLD_CONTROL		0xE010E81C
+#define S5P6442_PS_HOLD_DIR_OUTPUT	(1 << 9)
+#define S5P6442_PS_HOLD_DIR_INPUT	(0 << 9)
+#define S5P6442_PS_HOLD_DATA_HIGH	(1 << 8)

include/asm-arm/arch-s5p64xx/power.h line 74

Quoted 10 lines
include/asm-arm/arch-s5p64xx/power.h new file +10 -0
+#define S5P6442_PS_HOLD_DATA_LOW	(0 << 8)
+#define S5P6442_PS_HOLD_OUT_EN		(1 << 0)
+#define S5P6442_INFORM0			0xE010F000
+#define S5P6442_INFORM1			0xE010F004
+#define S5P6442_INFORM2			0xE010F008
+#define S5P6442_INFORM3			0xE010F00C
+#define S5P6442_INFORM4			0xE010F010
+#define S5P6442_INFORM5			0xE010F014
+#define S5P6442_INFORM6			0xE010F018
+#define S5P6442_INFORM7			0xE010F01C

Please use C structs to describe these registers.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Hiring experienced unix people is  like  a  built-in  filter  against
idiots. Hiring experienced NT people provides no such guarantee.
            -- Miguel Cruz in WgL96.349$CC.122704 at typhoon2.ba-dsg.net
#3 lore raw

PATCH 1/4 s5p6442: Support Samsung s5p6442 SoC

Dear Wolfgang Denk,

Quoted 43 lines · Wolfgang Denk

Dear Joonyoung Shim,

Quoted 6 lines · In message <[email protected]> you wrote:

This patch adds support s5p6442 SoC. The s5p6442 SoC is ARM1176 processor.

Cc Minkyu Kang <[email protected]>
Cc Kyungmin Park <[email protected]>

...

Quoted 1 line

+#define S5P6442_PWR_CFG ? ? ? ? ? ? ? ? ? ? ?0xE010C000

...

Quoted 31 lines
(quoted diff) +31 -0
+#define S5P6442_EINT_WAKEUP_MASK ? ? 0xE010C004
+#define S5P6442_WAKEUP_MASK ? ? ? ? ?0xE010C008
+#define S5P6442_PWR_MODE ? ? ? ? ? ? 0xE010C00C
+#define S5P6442_PWR_MODE_SLEEP ? ? ? ? ? ? ? (1 << 2)
+#define S5P6442_NORMAL_CFG ? ? ? ? ? 0xE010C010
+#define S5P6442_IDLE_CFG ? ? ? ? ? ? 0xE010C020
+#define S5P6442_STOP_CFG ? ? ? ? ? ? 0xE010C030
+#define S5P6442_STOP_MEM_CFG ? ? ? ? 0xE010C034
+#define S5P6442_SLEEP_CFG ? ? ? ? ? ?0xE010C040
+#define S5P6442_OSC_FREQ ? ? ? ? ? ? 0xE010C100
+#define S5P6442_OSC_STABLE ? ? ? ? ? 0xE010C104
+#define S5P6442_PWR_STABLE ? ? ? ? ? 0xE010C108
+#define S5P6442_MTC_STABLE ? ? ? ? ? 0xE010C110
+#define S5P6442_CLAMP_STABLE ? ? ? ? 0xE010C114
+#define S5P6442_WAKEUP_STAT ? ? ? ? ?0xE010C200
+#define S5P6442_OTHERS ? ? ? ? ? ? ? ? ? ? ? 0xE010E000
+#define S5P6442_OTHERS_SYSCON_INT_DISABLE ? ?(1 << 0)
+#define S5P6442_MIE_CONTROL ? ? ? ? ?0xE010E800
+#define S5P6442_HDMI_CONTROL ? ? ? ? 0xE010E804
+#define S5P6442_USB_PHY_CON ? ? ? ? ?0xE010E80C
+#define S5P6442_DAC_CONTROL ? ? ? ? ?0xE010E810
+#define S5P6442_MIPI_DPHY_CONTROL ? ?0xE010E814
+#define S5P6442_ADC_CONTROL ? ? ? ? ?0xE010E818
+#define S5P6442_PS_HOLD_CONTROL ? ? ? ? ? ? ?0xE010E81C
+#define S5P6442_PS_HOLD_DIR_OUTPUT ? (1 << 9)
+#define S5P6442_PS_HOLD_DIR_INPUT ? ?(0 << 9)
+#define S5P6442_PS_HOLD_DATA_HIGH ? ?(1 << 8)
+#define S5P6442_PS_HOLD_DATA_LOW ? ? (0 << 8)
+#define S5P6442_PS_HOLD_OUT_EN ? ? ? ? ? ? ? (1 << 0)
+#define S5P6442_INFORM0 ? ? ? ? ? ? ? ? ? ? ?0xE010F000
+#define S5P6442_INFORM1 ? ? ? ? ? ? ? ? ? ? ?0xE010F004
Quoted 9 lines

Review

Quoted 6 lines
(quoted diff) +6 -0
+#define S5P6442_INFORM2 ? ? ? ? ? ? ? ? ? ? ?0xE010F008
+#define S5P6442_INFORM3 ? ? ? ? ? ? ? ? ? ? ?0xE010F00C
+#define S5P6442_INFORM4 ? ? ? ? ? ? ? ? ? ? ?0xE010F010
+#define S5P6442_INFORM5 ? ? ? ? ? ? ? ? ? ? ?0xE010F014
+#define S5P6442_INFORM6 ? ? ? ? ? ? ? ? ? ? ?0xE010F018
+#define S5P6442_INFORM7 ? ? ? ? ? ? ? ? ? ? ?0xE010F01C

Please use C structs to describe these registers.

These registers are used at asm code.
So, can't make C struct.
But, It seemed to there are defined unused registers also.

Joonyoung,
Please remove unused defines.

Thanks
Minkyu Kang

Signature · 2 lines
from. prom.
www.promsoft.net
#4 lore raw

PATCH 1/4 s5p6442: Support Samsung s5p6442 SoC

Dear Minkyu Kang,

Quoted 2 lines · In message <[email protected]> you…

These registers are used at asm code.

Are they only used in assembler code? If so, these defines should be moved to a separate asm-offsets.h file. Keep in mind that this is considered to be a temporary workaround only. Later this file will be removed, and then auto-generated from the respective C structs. As soon as somebody finds time to adapt the respective code from Linux, that is.

Quoted 5 lines

So, can't make C struct.
But, It seemed to there are defined unused registers also.

Joonyoung,
Please remove unused defines.

And move this definition to asm-offsets.h (which must not be included in any C code).

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A wise person makes his  own  decisions,  a  weak  one  obeys  public
opinion.                                           -- Chinese proverb