Skip to contentSkip to conversation

No SPROM available!

BUG René Bolldorf 1 participant 2 messages Mar 29, 2010 Sonics silicon backplane driver (ssb)

lore
Share & tools
lore
#0 lore raw

Hi John,

since commit fcb54b0bf7d3fe730c2b72e224bc616e358f24cb, my b43 (4312) device doesn't work.

But the device have a sprom. Maybe the chip-status register check is wrong?

+/** Macros to determine SPROM presence based on Chip-Status register. */ +#define SSB_CHIPCO_CHST_4312_SPROM_PRESENT(status) \
+ ((status & SSB_CHIPCO_CHST_4325_SPROM_OTP_SEL) != \
+ SSB_CHIPCO_CHST_4325_OTP_SEL)

#1 lore raw

Review

Quoted 11 lines · René Bolldorf

Hi John,

since commit fcb54b0bf7d3fe730c2b72e224bc616e358f24cb, my b43 (4312) device doesn't work.

But the device have a sprom. Maybe the chip-status register check is wrong?

(quoted diff) +4 -0
+/** Macros to determine SPROM presence based on Chip-Status register. */
+#define SSB_CHIPCO_CHST_4312_SPROM_PRESENT(status) \
+ ((status & SSB_CHIPCO_CHST_4325_SPROM_OTP_SEL) != \
+ SSB_CHIPCO_CHST_4325_OTP_SEL)

I have talked with my colleague and he have the same problem. I have made a patch , for me it works and should work for others too. My colleague testing this in the late evening.

include/linux/ssb/ssb_driver_chipcommon.h +1 -0
index 2cdf249..1e0b9cd 100644
@@ -386,6 +386,7 @@
 
 
 /** Chip specific Chip-Status register contents. */
+#define SSB_CHIPCO_CHST_4312_SPROM_EXISTS	0x00000025
 #define SSB_CHIPCO_CHST_4322_SPROM_EXISTS	0x00000040 /* SPROM present */
 #define SSB_CHIPCO_CHST_4325_SPROM_OTP_SEL	0x00000003
 #define SSB_CHIPCO_CHST_4325_DEFCIS_SEL		0 /* OTP is powered up, use 

def. CIS, no SPROM */
@@ -403,7 +404,7 @@
/** Macros to determine SPROM presence based on Chip-Status register. */ #define SSB_CHIPCO_CHST_4312_SPROM_PRESENT(status) \
((status & SSB_CHIPCO_CHST_4325_SPROM_OTP_SEL) != \
- SSB_CHIPCO_CHST_4325_OTP_SEL)
+ SSB_CHIPCO_CHST_4312_SPROM_EXISTS)
#define SSB_CHIPCO_CHST_4322_SPROM_PRESENT(status) \
(status & SSB_CHIPCO_CHST_4322_SPROM_EXISTS)
#define SSB_CHIPCO_CHST_4325_SPROM_PRESENT(status) \