Skip to contentSkip to conversation

DM9000: fix build when debugging is enabled

PATCH New Mike Frysinger 2 participants 3 messages Mar 24, 2010 – Apr 6, 2010 Network drivers

lore
Share & tools
lore

Mike Frysinger

author
#0 lore raw

PATCH 1/1 DM9000: fix build when debugging is enabled

From: Brent Kandetzki <[email protected]>

The debug code uses the gcc __func__ define, but tries to use it as a static const string which no longer works. So treat it like a normal printf string argument.

Signed-off-by Brent Kandetzki <[email protected]>
Signed-off-by Mike Frysinger <[email protected]>
---
 drivers/net/dm9000x.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/dm9000x.c +1 -1
index 73dd335..a7fef56 100644
@@ -75,7 +75,7 @@ TODO: external MII is not functional, only internal at the moment.
 #define DM9000_DMP_PACKET(func,packet,length)  \
 	do { \
 		int i; 							\
-		printf(func ": length: %d\n", length);			\
+		printf("%s: length: %d\n", func, length);		\
 		for (i = 0; i < length; i++) {				\
 			if (i % 8 == 0)					\
 				printf("\n%s: %02x: ", func, i);	\
Signature · 1 line
1.7.0.2
#1 lore raw

PATCH 1/1 DM9000: fix build when debugging is enabled

Hi Mike,

Quoted 18 lines · Mike Frysinger

From: Brent Kandetzki<[email protected]>

The debug code uses the gcc __func__ define, but tries to use it as a static const string which no longer works. So treat it like a normal printf string argument.

Signed-off-by Brent Kandetzki<[email protected]>
Signed-off-by Mike Frysinger<[email protected]>
---
  drivers/net/dm9000x.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/dm9000x.c +0 -0
index 73dd335..a7fef56 100644

drivers/net/dm9000x.c TODO: external MII is not functional, only internal at the moment. · line 81

Quoted 8 lines
drivers/net/dm9000x.c +1 -1
@@ -75,7 +75,7 @@ TODO: external MII is not functional, only internal at the moment.
  #define DM9000_DMP_PACKET(func,packet,length)  \
  	do { \
  		int i; 							\
-		printf(func ": length: %d\n", length);			\
+		printf("%s: length: %d\n", func, length);		\
  		for (i = 0; i<  length; i++) {				\
  			if (i % 8 == 0)					\
  				printf("\n%s: %02x: ", func, i);	\

An identical patch was applied in December (commit 076cd24cb4278c125c8f36df386852dc0fcfefae). Am I missing something?

regards,
Ben

author
#2 lore raw

PATCH 1/1 DM9000: fix build when debugging is enabled

Quoted 30 lines · On Monday 05 April 2010 01:22:39 Ben Warren wrote:
Quoted 29 lines · Mike Frysinger

From: Brent Kandetzki<[email protected]>

The debug code uses the gcc __func__ define, but tries to use it as a static const string which no longer works. So treat it like a normal printf string argument.

Signed-off-by Brent Kandetzki<[email protected]>
Signed-off-by Mike Frysinger<[email protected]>

---

  drivers/net/dm9000x.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/dm9000x.c +0 -0
index 73dd335..a7fef56 100644
@@ -75,7 +75,7 @@ TODO: external MII is not functional, only internal at

the moment.

  #define DM9000_DMP_PACKET(func,packet,length)  \
  
  	do { \
  	
  		int i; 							\
drivers/net/dm9000x.c +1 -1
-		printf(func ": length: %d\n", length);			\
+		printf("%s: length: %d\n", func, length);		\
Quoted 8 lines
Quoted 5 lines
  		for (i = 0; i<  length; i++) {				\
  		
  			if (i % 8 == 0)					\
  			
  				printf("\n%s: %02x: ", func, i);	\

An identical patch was applied in December (commit 076cd24cb4278c125c8f36df386852dc0fcfefae). Am I missing something?

nope ... i was looking at the 2009.11 release apparently
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100406/ccbaba3a/attachment.pgp