Skip to contentSkip to conversation

eeepc-wmi: include slab.h

PATCH In review Tejun Heo 2 participants 3 messages Apr 5, 2010

Subsystems (2)
x86 platform drivers ASUS notebooks and eeepc ACPI/WMI extras drivers
lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 eeepc-wmi: include slab.h

eeepc-wmi uses kfree() but doesn't include slab.h. Include it.

Signed-off-by Tejun Heo <[email protected]>
Cc Yong Wang <[email protected]>

---
Hello,

I've committed this patch to percpu#slabh branch which breaks implicit slab interface availability. I'm gonna push the branch to Linus soonish.

Thanks.

 drivers/platform/x86/eeepc-wmi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/platform/x86/eeepc-wmi.c +1 -0
index 2466b7b..9f88226 100644
@@ -27,6 +27,7 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/types.h>
+#include <linux/slab.h>
 #include <linux/input.h>
 #include <linux/input/sparse-keymap.h>
 #include <acpi/acpi_bus.h>
Signature · 1 line
1.6.4.2
#1 lore raw
Quoted 28 lines

From: Tejun Heo [mailto:[email protected]]
Sent: Monday, April 05, 2010 10:41 AM
To: lkml
Cc: Wang, Yong Y
Subject: [PATCH] eeepc-wmi: include slab.h

eeepc-wmi uses kfree() but doesn't include slab.h. Include it.

Signed-off-by Tejun Heo <[email protected]>
Cc Yong Wang <[email protected]>

---
Hello,

I've committed this patch to percpu#slabh branch which breaks implicit slab interface availability. I'm gonna push the branch to Linus soonish.

Thanks.

 drivers/platform/x86/eeepc-wmi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/platform/x86/eeepc-wmi.c +0 -0
index 2466b7b..9f88226 100644

drivers/platform/x86/eeepc-wmi.c line 33

Quoted 7 lines
drivers/platform/x86/eeepc-wmi.c +1 -0
@@ -27,6 +27,7 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/types.h>
+#include <linux/slab.h>
 #include <linux/input.h>
 #include <linux/input/sparse-keymap.h>
 #include <acpi/acpi_bus.h>

<linux/module.h> includes <linux/percpu.h> which in turn includes <linux/slab.h>. Doesn't it?

Thanks
-Yong

author
#2 lore raw
Quoted 2 lines · Yong Y

<linux/module.h> includes <linux/percpu.h> which in turn includes <linux/slab.h>. Doesn't it?

Yeah, I'm trying to break that implicit dependency. :-)

Signature · 1 line
tejun